warp7: include/configs: use generic fs commands in CONFIG_EXTRA_ENV_SETTINGS

PATCH New Pierre-Jean TEXIER 4 participants 8 messages Mar 31, 2018 – Apr 27, 2018

lore

Share & tools

lore

Pierre-Jean TEXIER

author

2018-03-31 22:49 UTC #0 lore raw

PATCH v3 1/2 warp7: include/configs: use generic fs commands in CONFIG_EXTRA_ENV_SETTINGS

use the generic filesystem command 'load' rather
than 'fatload' to avoid per-fs specific commands.

Signed-off-by Pierre-Jean TEXIER <[email protected]>

---
Changes for v3:
- None

 include/configs/warp7.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

include/configs/warp7.h +3 -3

index fe96988..82dc629 100644
@@ -45,11 +45,11 @@
 	"mmcargs=setenv bootargs console=${console},${baudrate} " \
 		"root=PARTUUID=${uuid} rootwait rw\0" \
 	"loadbootscript=" \
-		"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
+		"load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
 	"bootscript=echo Running bootscript from mmc ...; " \
 		"source\0" \
-	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
-	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
+	"loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
+	"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
 	"mmcboot=echo Booting from mmc ...; " \
 		"run finduuid; " \
 		"run mmcargs; " \

Signature · 1 line

2.7.4

Pierre-Jean TEXIER

author

2018-03-31 22:49 UTC #1 lore raw

PATCH v3 2/2 warp7: configs: enable CONFIG_CMD_FS_GENERIC

This enable generic file system commands (load, ls).

Signed-off-by Pierre-Jean TEXIER <[email protected]>

---
Changes for v3:
- drop 'warp7_secure_defconfig'

 configs/warp7_defconfig | 1 +
 1 file changed, 1 insertion(+)

configs/warp7_defconfig +1 -0

index 29c4512..3856918 100644
@@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DFU_MMC=y
 CONFIG_USB=y

Signature · 1 line

2.7.4

Fabio Estevam

2018-03-31 23:01 UTC #2 lore raw

PATCH v3 2/2 warp7: configs: enable CONFIG_CMD_FS_GENERIC

Hi Pierre-Jean,

Quoted 3 lines · Pierre-Jean TEXIER

This enable generic file system commands (load, ls).
Signed-off-by Pierre-Jean TEXIER <[email protected]>

Thanks for sending this new version:

Reviewed-by Fabio Estevam <[email protected]>

Bryan O'Donoghue

2018-03-31 23:09 UTC #3 lore raw

PATCH v3 2/2 warp7: configs: enable CONFIG_CMD_FS_GENERIC

In reply to Pierre-Jean TEXIER

Quoted 16 lines · Pierre-Jean TEXIER

This enable generic file system commands (load, ls).
Signed-off-by Pierre-Jean TEXIER <[email protected]>
---
Changes for v3:
- drop 'warp7_secure_defconfig'
  configs/warp7_defconfig | 1 +
  1 file changed, 1 insertion(+)
configs/warp7_defconfig +0 -0
index 29c4512..3856918 100644

configs/warp7_defconfig CONFIG_CMD_EXT2=y · line 32

Quoted 7 lines

configs/warp7_defconfig +1 -0

@@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
  CONFIG_CMD_EXT4=y
  CONFIG_CMD_EXT4_WRITE=y
  CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
  CONFIG_NET_RANDOM_ETHADDR=y
  CONFIG_DFU_MMC=y
  CONFIG_USB=y

Acked-by Bryan O'Donoghue <[email protected]>

Stefano Babic

2018-04-27 08:47 UTC #4 lore raw

PATCH v3 2/2 warp7: configs: enable CONFIG_CMD_FS_GENERIC

In reply to Pierre-Jean TEXIER

Quoted 16 lines · Pierre-Jean TEXIER

This enable generic file system commands (load, ls).
Signed-off-by Pierre-Jean TEXIER <[email protected]>
---
Changes for v3:
- drop 'warp7_secure_defconfig'
 configs/warp7_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/warp7_defconfig +0 -0
index 29c4512..3856918 100644

configs/warp7_defconfig CONFIG_CMD_EXT2=y · line 32

Quoted 7 lines

configs/warp7_defconfig +1 -0

@@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DFU_MMC=y
 CONFIG_USB=y

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Fabio Estevam

2018-03-31 23:01 UTC #5 lore raw

PATCH v3 1/2 warp7: include/configs: use generic fs commands in CONFIG_EXTRA_ENV_SETTINGS

In reply to Pierre-Jean TEXIER

Quoted 4 lines · Pierre-Jean TEXIER

use the generic filesystem command 'load' rather
than 'fatload' to avoid per-fs specific commands.
Signed-off-by Pierre-Jean TEXIER <[email protected]>

Reviewed-by Fabio Estevam <[email protected]>

Bryan O'Donoghue

2018-03-31 23:10 UTC #6 lore raw

PATCH v3 1/2 warp7: include/configs: use generic fs commands in CONFIG_EXTRA_ENV_SETTINGS

In reply to Pierre-Jean TEXIER

Quoted 21 lines · Pierre-Jean TEXIER

use the generic filesystem command 'load' rather
than 'fatload' to avoid per-fs specific commands.
Signed-off-by Pierre-Jean TEXIER <[email protected]>
---
Changes for v3:
- None
  include/configs/warp7.h | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
include/configs/warp7.h +0 -1
index fe96988..82dc629 100644
@@ -45,11 +45,11 @@
  	"mmcargs=setenv bootargs console=${console},${baudrate} " \
  		"root=PARTUUID=${uuid} rootwait rw\0" \
  	"loadbootscript=" \
-		"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \

include/configs/warp7.h line 55

Quoted 10 lines

include/configs/warp7.h +3 -2

+		"load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
  	"bootscript=echo Running bootscript from mmc ...; " \
  		"source\0" \
-	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
-	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
+	"loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
+	"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
  	"mmcboot=echo Booting from mmc ...; " \
  		"run finduuid; " \
  		"run mmcargs; " \

Acked-by Bryan O'Donoghue <[email protected]>

Stefano Babic

2018-04-27 08:47 UTC #7 lore raw

PATCH v3 1/2 warp7: include/configs: use generic fs commands in CONFIG_EXTRA_ENV_SETTINGS

In reply to Pierre-Jean TEXIER

Quoted 21 lines · Pierre-Jean TEXIER

use the generic filesystem command 'load' rather
than 'fatload' to avoid per-fs specific commands.
Signed-off-by Pierre-Jean TEXIER <[email protected]>
---
Changes for v3:
- None
 include/configs/warp7.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
include/configs/warp7.h +0 -1
index fe96988..82dc629 100644
@@ -45,11 +45,11 @@
 	"mmcargs=setenv bootargs console=${console},${baudrate} " \
 		"root=PARTUUID=${uuid} rootwait rw\0" \
 	"loadbootscript=" \
-		"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \

include/configs/warp7.h line 55

Quoted 10 lines

include/configs/warp7.h +3 -2

+		"load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
 	"bootscript=echo Running bootscript from mmc ...; " \
 		"source\0" \
-	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
-	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
+	"loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
+	"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
 	"mmcboot=echo Booting from mmc ...; " \
 		"run finduuid; " \
 		"run mmcargs; " \

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================