staging: mt7621-eth: Fix sparse warning in ethtool.c

Include the local ethtool.h header file in mtk_eth_soc.h so implementation files have centralized access to it.

This fixes the following sparse warning:

drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol 'mtk_set_ethtool_ops' was not declared. Should it be static?

Signed-off-by Chris Coffey <[email protected]>

---
 drivers/staging/mt7621-eth/mtk_eth_soc.c | 1 -
 drivers/staging/mt7621-eth/mtk_eth_soc.h | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

drivers/staging/mt7621-eth/mtk_eth_soc.c +0 -0

index cbc7339843..0574e71573 100644

This fixes the following sparse warning:

drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol 'mtk_set_ethtool_ops' was not declared. Should it be static?

Signed-off-by Chris Coffey <[email protected]>

---
Changes in v2:
- Per GregKH's feedback (thanks!), don't add unnecessary new .h file dependencies. This patch version reverts those changes and fixes the problem directly in ethtool.c (which is that it didn't include ethtool.h anywhere -- mtk_set_ethtool_ops is not static).

 drivers/staging/mt7621-eth/ethtool.c | 1 +
 1 file changed, 1 insertion(+)

drivers/staging/mt7621-eth/ethtool.c +1 -0

index 38ba0c040a..5268c5ca09 100644
@@ -13,6 +13,7 @@
  */
 
 #include "mtk_eth_soc.h"
+#include "ethtool.h"
 
 static const char mtk_gdma_str[][ETH_GSTRING_LEN] = {
 #define _FE(x...)	# x,

Signature · 1 line

2.11.0

Quoted 5 lines · Chris Coffey

This fixes the following sparse warning:

drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol 'mtk_set_ethtool_ops' was not declared. Should it be static?

Quoted 1 line

Signed-off-by Chris Coffey <[email protected]>

Reviewed-by NeilBrown <[email protected]>

Thanks,
NeilBrown

Quoted 25 lines

---
Changes in v2:
- Per GregKH's feedback (thanks!), don't add unnecessary new .h file dependencies. This patch version reverts those changes and fixes the problem directly in ethtool.c (which is that it didn't include ethtool.h anywhere -- mtk_set_ethtool_ops is not static).

 drivers/staging/mt7621-eth/ethtool.c | 1 +
 1 file changed, 1 insertion(+)

drivers/staging/mt7621-eth/ethtool.c +1 -0

index 38ba0c040a..5268c5ca09 100644
@@ -13,6 +13,7 @@
  */
 
 #include "mtk_eth_soc.h"
+#include "ethtool.h"
 
 static const char mtk_gdma_str[][ETH_GSTRING_LEN] = {
 #define _FE(x...)	# x,

Signature · 1 line

2.11.0

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

Quoted 7 lines · NeilBrown

Quoted 5 lines · Chris Coffey

This fixes the following sparse warning:

drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol 'mtk_set_ethtool_ops' was not declared. Should it be static?

Quoted 7 lines

Quoted 1 line

Signed-off-by Chris Coffey <[email protected]>

Reviewed-by NeilBrown <[email protected]>

Thanks,
NeilBrown

Hi, Neil

Forgive me I cannot find the cover letter in the original series in my mailbox to make a reply, so I rudely made here just letting you know something good to the growth of mt7621 support in upstream.

do you have maintained an out-of-tree branch to boot the mt7621 machine with those staging patches?

If so, it would become a bit easier for me that maybe I could give a hand for migrating these staging driver for mt7621 to mainline. I thought mmc, pci, ethernet, gsw and hsdma all could probably reuse the current mainline code.

Quoted 10 lines · Sean Wang

Hi, Neil

Forgive me I cannot find the cover letter in the original series in my mailbox to make a reply, so I rudely made here just letting you know something good to the growth of mt7621 support in upstream.

If so, it would become a bit easier for me that maybe I could give a hand for migrating these staging driver for mt7621 to mainline. I thought mmc, pci, ethernet, gsw and hsdma all could probably reuse the current mainline code.

I agree that it is quite likely that several of these drivers could and should reuse current mainline code. I would love to have some help sorting this out. I won't have much time myself to dig into it for several weeks, but I'll make time to review and test any code that is contributed.

Thanks,
NeilBrown

Quoted 12 lines · NeilBrown

Quoted 10 lines · Sean Wang

Hi, Neil

Forgive me I cannot find the cover letter in the original series in my mailbox to make a reply, so I rudely made here just letting you know something good to the growth of mt7621 support in upstream.

If so, it would become a bit easier for me that maybe I could give a hand for migrating these staging driver for mt7621 to mainline. I thought mmc, pci, ethernet, gsw and hsdma all could probably reuse the current mainline code.

Quoted 8 lines

I agree that it is quite likely that several of these drivers could and should reuse current mainline code. I would love to have some help sorting this out. I won't have much time myself to dig into it for several weeks, but I'll make time to review and test any code that is contributed.

Thanks,
NeilBrown

Hi,

I have started a patch series for the mmc driver that is currently in staging, that makes some of the first cleanups (whitespace, indent,..) and also starts to clean up the code, to make the similarities and differences to the current mainline code clearer. The series is far from being complete, but I think I'm going to send it out today, so you can look and comment.

I would suggest that we continue cleaning the code that is currently in staging to remove the dead parts and make the diff to the mainline code obvious. Do you agree with that proposal or do you suggest a different plan?