Skip to contentSkip to conversation

Patch "ACPI, PCI, irq: remove redundant check for null string pointer" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Apr 3, 2018

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ACPI, PCI, irq: remove redundant check for null string pointer

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
acpi-pci-irq-remove-redundant-check-for-null-string-pointer.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 45288978859119c019eff93f0cb838a0de100bcc Mon Sep 17 00:00:00 2001

From: Colin Ian King <[email protected]>
Date: Tue, 5 Jan 2016 10:57:11 +0000
Subject: ACPI, PCI, irq: remove redundant check for null string pointer

From: Colin Ian King <[email protected]>

commit 45288978859119c019eff93f0cb838a0de100bcc upstream.

source is decleared as a 4 byte char array in struct acpi_pci_routing_table so !prt->source is a redundant null string pointer check. Detected with smatch:

drivers/acpi/pci_irq.c:134 do_prt_fixups() warn: this array is probably
non-NULL. 'prt->source'

---
 drivers/acpi/pci_irq.c |    3 ---
 1 file changed, 3 deletions(-)
drivers/acpi/pci_irq.c +0 -3
@@ -131,9 +131,6 @@ static void do_prt_fixups(struct acpi_pr
 		quirk = &prt_quirks[i];
 
 		/* All current quirks involve link devices, not GSIs */
-		if (!prt->source)
-			continue;
-
 		if (dmi_check_system(quirk->system) &&
 		    entry->id.segment == quirk->segment &&
 		    entry->id.bus == quirk->bus &&

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/acpi-pci-irq-remove-redundant-check-for-null-string-pointer.patch