WTF: patch "[PATCH] Bluetooth: hci_bcm: Add irq_polarity module option" was seriously submitted to be applied to the 4.16-stable tree?

From e09070c51b280567695022237e57c428e548b355 Mon Sep 17 00:00:00 2001

The patch below was submitted to be applied to the 4.16-stable tree.

I fail to see how this patch meets the stable kernel rules as found at Documentation/process/stable-kernel-rules.rst.

I could be totally wrong, and if so, please respond to <[email protected]> and let me know why this patch should be applied. Otherwise, it is now dropped from my patch queues, never to be seen again.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From e09070c51b280567695022237e57c428e548b355 Mon Sep 17 00:00:00 2001
From: Hans de Goede <[email protected]>
Date: Fri, 16 Mar 2018 21:28:07 +0100
Subject: [PATCH] Bluetooth: hci_bcm: Add irq_polarity module option

Add irq_polarity module option for easier troubleshooting of irq-polarity issues.

Cc [email protected]

Signed-off-by Hans de Goede <[email protected]>

Signed-off-by Marcel Holtmann <[email protected]>

drivers/bluetooth/hci_bcm.c +15 -5

index ff7535e85dea..50c8523f8653 100644
@@ -126,6 +126,10 @@ struct bcm_data {
  static DEFINE_MUTEX(bcm_device_lock);
  static LIST_HEAD(bcm_device_list);
 
+static int irq_polarity = -1;
+module_param(irq_polarity, int, 0444);
+MODULE_PARM_DESC(irq_polarity, "IRQ polarity 0: active-high 1: active-low");
+
  static inline void host_set_baudrate(struct hci_uart *hu, unsigned int speed)
  {
  	if (hu->serdev)

@@ -989,11 +993,17 @@ static int bcm_acpi_probe(struct bcm_device *dev)
  	}
  	acpi_dev_free_resource_list(&resources);
 
-	dmi_id = dmi_first_match(bcm_active_low_irq_dmi_table);
-	if (dmi_id) {
-		dev_warn(dev->dev, "%s: Overwriting IRQ polarity to active low",
-			    dmi_id->ident);
-		dev->irq_active_low = true;
+	if (irq_polarity != -1) {
+		dev->irq_active_low = irq_polarity;
+		dev_warn(dev->dev, "Overwriting IRQ polarity to active %s by module-param\n",
+			 dev->irq_active_low ? "low" : "high");
+	} else {
+		dmi_id = dmi_first_match(bcm_active_low_irq_dmi_table);
+		if (dmi_id) {
+			dev_warn(dev->dev, "%s: Overwriting IRQ polarity to active low",
+				 dmi_id->ident);
+			dev->irq_active_low = true;
+		}
  	}
 
  	return 0;