Skip to contentSkip to conversation

scripts : sync the var type between memory and print

PATCH In review Wenle Chen 2 participants 2 messages Apr 7, 2018

lore
Share & tools
lore

Wenle Chen

author
#0 lore raw

PATCH 1/1 scripts : sync the var type between memory and print

From: Wenle Chen <[email protected]>

The %d in printf need get a int
But the real type of these vars is unsigned.
It may let some compilers show a warning.

---
 scripts/recordmcount.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
scripts/recordmcount.c +3 -3
index 8c9691c..6f900fa 100644
@@ -459,7 +459,7 @@ do_file(char const *const fname)
 	switch (ehdr->e_ident[EI_DATA]) {
 		static unsigned int const endian = 1;
 	default:
-		fprintf(stderr, "unrecognized ELF data encoding %d: %s\n",
+		fprintf(stderr, "unrecognized ELF data encoding %u: %s\n",
 			ehdr->e_ident[EI_DATA], fname);
 		fail_file();
 		break;
@@ -500,7 +500,7 @@ do_file(char const *const fname)
 	gpfx = 0;
 	switch (w2(ehdr->e_machine)) {
 	default:
-		fprintf(stderr, "unrecognized e_machine %d %s\n",
+		fprintf(stderr, "unrecognized e_machine %u %s\n",
 			w2(ehdr->e_machine), fname);
 		fail_file();
 		break;
@@ -541,7 +541,7 @@ do_file(char const *const fname)
 
 	switch (ehdr->e_ident[EI_CLASS]) {
 	default:
-		fprintf(stderr, "unrecognized ELF class %d %s\n",
+		fprintf(stderr, "unrecognized ELF class %u %s\n",
 			ehdr->e_ident[EI_CLASS], fname);
 		fail_file();
 		break;
Signature · 1 line
2.7.4
#1 lore raw
Quoted 5 lines · On Sat, 7 Apr 2018 18:01:35 +0800 Wenle Chen <[email protected]> wrote:

From: Wenle Chen <[email protected]>

The %d in printf need get a int
But the real type of these vars is unsigned.
It may let some compilers show a warning.

Thanks but the merge window is currently open. It's best to not send patches during it. Please send this again after 4.17-rc1 is released.

-- Steve