Patch "IB/ipoib: Fix for notify send CQ failure messages" has been added to the 4.15-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
IB/ipoib: Fix for notify send CQ failure messages
to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ib-ipoib-fix-for-notify-send-cq-failure-messages.patch
and it can be found in the queue-4.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Mon Apr 9 10:16:32 CEST 2018
From: Alex Estrin <[email protected]>
Date: Wed, 3 Jan 2018 07:39:50 -0500
Subject: IB/ipoib: Fix for notify send CQ failure messages
From: Alex Estrin <[email protected]>
[ Upstream commit 809cb6955650d892c6ef95f1d55f28fceded0ce1 ]
If IB_CQ_REPORT_MISSED_EVENTS flag is passed in ib_req_notify_cq() it may return positive value indicating non-empty CQ. If return code not verified the log might be flooded with false warning messages "request notify on send CQ failed".
--- drivers/infiniband/ulp/ipoib/ipoib_cm.c | 10 ++++++---- drivers/infiniband/ulp/ipoib/ipoib_ib.c | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-)
drivers/infiniband/ulp/ipoib/ipoib_cm.c +6 -4
@@ -766,12 +766,14 @@ void ipoib_cm_send(struct net_device *deskb_orphan (skb);skb_dst_drop (skb); -if (netif_queue_stopped (dev)) -if (ib_req_notify_cq (priv->send_cq,IB_CQ_NEXT_COMP | -IB_CQ_REPORT_MISSED_EVENTS )) { +if (netif_queue_stopped (dev)) { + rc =ib_req_notify_cq (priv->send_cq,IB_CQ_NEXT_COMP | +IB_CQ_REPORT_MISSED_EVENTS ); +if (unlikely (rc <0 ))ipoib_warn (priv,"IPoIB/CM:request notify on send CQ failed\n" ); +else if (rc)napi_schedule (&priv->send_napi); - } + } rc =post_send (priv, tx, tx->tx_head & (ipoib_sendq_size -1 ), tx_req);if (unlikely (rc)) {
drivers/infiniband/ulp/ipoib/ipoib_ib.c +1 -1
@@ -644,7 +644,7 @@ int ipoib_send(struct net_device *dev, sif (netif_queue_stopped (dev))if (ib_req_notify_cq (priv->send_cq,IB_CQ_NEXT_COMP | -IB_CQ_REPORT_MISSED_EVENTS )) +IB_CQ_REPORT_MISSED_EVENTS ) <0 )ipoib_warn (priv,"request notify on send CQ failed\n" ); rc = post_send(priv, priv->tx_head & (ipoib_sendq_size - 1),
Patches currently in stable-queue which might be from [email protected] are
queue-4.15/ib-ipoib-fix-for-notify-send-cq-failure-messages.patch