Patch "virtio_net: check return value of skb_to_sgvec always" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
virtio_net: check return value of skb_to_sgvec always
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
virtio_net-check-return-value-of-skb_to_sgvec-always.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
e2fcad58fd230f635a74e4e983c6f4ea893642d2Mon Sep 17 00:00:00 2001
From: "Jason A. Donenfeld" <[email protected]>
Date: Sun, 4 Jun 2017 04:16:26 +0200
Subject: virtio_net: check return value of skb_to_sgvec always
From: Jason A. Donenfeld <[email protected]>
commit e2fcad58fd230f635a74e4e983c6f4ea893642d2 upstream.
--- drivers/net/virtio_net.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/net/virtio_net.c +7 -2
@@ -831,7 +831,7 @@ static int xmit_skb(struct send_queue *sstruct virtio_net_hdr_mrg_rxbuf *hdr;const unsigned char *dest = ((struct ethhdr *)skb->data)->h_dest;struct virtnet_info *vi = sq->vq->vdev->priv; -unsigned num_sg; +int num_sg;unsigned hdr_len = vi->hdr_len;bool can_push;
@@ -858,11 +858,16 @@ static int xmit_skb(struct send_queue *sif (can_push) {__skb_push (skb, hdr_len); num_sg =skb_to_sgvec (skb, sq->sg,0 , skb->len); +if (unlikely (num_sg <0 )) +return num_sg;/* Pull header back to avoid skew in tx bytes calculations. */ __skb_pull (skb, hdr_len); }else {sg_set_buf (sq->sg, hdr, hdr_len); - num_sg =skb_to_sgvec (skb, sq->sg +1 ,0 , skb->len) +1 ; + num_sg =skb_to_sgvec (skb, sq->sg +1 ,0 , skb->len); +if (unlikely (num_sg <0 )) +return num_sg; + num_sg++; }return virtqueue_add_outbuf (sq->vq, sq->sg, num_sg, skb,GFP_ATOMIC ); }
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/ipsec-check-return-value-of-skb_to_sgvec-always.patch queue-4.9/skbuff-return-emsgsize-in-skb_to_sgvec-to-prevent-overflow.patch queue-4.9/rxrpc-check-return-value-of-skb_to_sgvec-always.patch queue-4.9/virtio_net-check-return-value-of-skb_to_sgvec-always.patch queue-4.9/macsec-check-return-value-of-skb_to_sgvec-always.patch queue-4.9/virtio_net-check-return-value-of-skb_to_sgvec-in-one-more-location.patch