Patch "net/mlx5: avoid build warning for uniprocessor" has been added to the 4.4-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
net/mlx5: avoid build warning for uniprocessor
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-mlx5-avoid-build-warning-for-uniprocessor.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Tue Apr 10 10:31:53 CEST 2018
From: Arnd Bergmann <[email protected]>
Date: Mon, 29 May 2017 15:00:17 +0200
Subject: net/mlx5: avoid build warning for uniprocessor
From: Arnd Bergmann <[email protected]>
[ Upstream commit f0d7ae95fff4ab444b8433f07afc4b077ef1a285 ]
Building the driver with CONFIG_SMP disabled results in a harmless warning:
ethernet/mellanox/mlx5/core/main.c: In function 'mlx5_irq_set_affinity_hint':ethernet/mellanox/mlx5/core/main.c:615:6: error: unused variable 'irq' [-Werror=unused-variable]
It's better to express the conditional compilation using IS_ENABLED() here, as that lets the compiler see what the intented use for the variable is, and that it can be silently discarded.
--- drivers/net/ethernet/mellanox/mlx5/core/main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/main.c +2 -3
@@ -522,10 +522,9 @@ static int mlx5_irq_set_affinity_hint(stcpumask_set_cpu (cpumask_local_spread (i, priv->numa_node), priv->irq_info[i].mask); -#ifdef CONFIG_SMP -if (irq_set_affinity_hint (irq, priv->irq_info[i].mask)) +if (IS_ENABLED (CONFIG_SMP ) && +irq_set_affinity_hint (irq, priv->irq_info[i].mask))mlx5_core_warn (mdev,"irq_set_affinity_hint failed, irq 0x%.4x" , irq); -#endif return 0 ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/net-mlx5-avoid-build-warning-for-uniprocessor.patch queue-4.4/xen-avoid-type-warning-in-xchg_xen_ulong.patch