Skip to contentSkip to conversation

qemu_2.11.%.bbappend: fix broken qemu build for mingw

PATCH In review Juro Bystricky 3 participants 5 messages Apr 12, 2018 – Apr 13, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qemu_2.11.%.bbappend: fix broken qemu build for mingw

The commit "qemu: Bump to version 2.11.0" in oe-core broke the build of qemu for mingw, due to using "socketpair", which is not supported by mingw. "socketpair" is used in a local patch, not in the qemu upstream code. The original local patch had conditional code to exclude "socketpair" for _WIN32, but the modified patch for qemu 2.11.0 removed this.

The fix is to simply remove the offending patch.

---
 recipes-devtools/qemu/qemu_2.11.%.bbappend | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 recipes-devtools/qemu/qemu_2.11.%.bbappend
recipes-devtools/qemu/qemu_2.11.%.bbappend new file +4 -0
new file mode 100644
index 0000000..764b500
@@ -0,0 +1,4 @@
+
+
+SRC_URI_remove_mingw32 = "file://chardev-connect-socket-to-a-spawned-command.patch"
+         
Signature · 1 line
2.7.4
#1 lore raw

Is it feasible to fix the original patch?

Ross

Quoted 33 lines · Juro Bystricky

The commit "qemu: Bump to version 2.11.0" in oe-core broke the build of qemu for mingw, due to using "socketpair", which is not supported by mingw. "socketpair" is used in a local patch, not in the qemu upstream code. The original local patch had conditional code to exclude "socketpair" for _WIN32, but the modified patch for qemu 2.11.0 removed this.

The fix is to simply remove the offending patch.

---
 recipes-devtools/qemu/qemu_2.11.%.bbappend | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 recipes-devtools/qemu/qemu_2.11.%.bbappend
recipes-devtools/qemu/qemu_2.11.%.bbappend new file +4 -1
new file mode 100644
index 0000000..764b500
@@ -0,0 +1,4 @@
+
+
+SRC_URI_remove_mingw32 = "file://chardev-connect-socket-to-a-spawned-command.patch"
+
--

2.7.4

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#2 lore raw

yes, I've done it before:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=sumo&id=bc112b8368eb3842ccb2430fdf17e736ea39a742
I'll do it gain. Hopefully it will last longer this time.

________________________________________
From: Burton, Ross [[email protected]]
Sent: Friday, April 13, 2018 5:50 AM
To: Bystricky, Juro
Cc: Yocto-mailing-list; Juro Bystricky; Alistair Francis
Subject: Re: [yocto] [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw

Is it feasible to fix the original patch?

Ross

Quoted 33 lines · Juro Bystricky

The commit "qemu: Bump to version 2.11.0" in oe-core broke the build of qemu for mingw, due to using "socketpair", which is not supported by mingw. "socketpair" is used in a local patch, not in the qemu upstream code. The original local patch had conditional code to exclude "socketpair" for _WIN32, but the modified patch for qemu 2.11.0 removed this.

The fix is to simply remove the offending patch.

---
 recipes-devtools/qemu/qemu_2.11.%.bbappend | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 recipes-devtools/qemu/qemu_2.11.%.bbappend
recipes-devtools/qemu/qemu_2.11.%.bbappend new file +4 -1
new file mode 100644
index 0000000..764b500
@@ -0,0 +1,4 @@
+
+
+SRC_URI_remove_mingw32 = "file://chardev-connect-socket-to-a-spawned-command.patch"
+
--

2.7.4

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#3 lore raw

Thanks Juro. I'll remember to keep an eye out for the ifdefs disappearing.

Ross

Quoted 50 lines · Juro

yes, I've done it before:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=sumo&id=bc112b8368eb3842ccb2430fdf17e736ea39a742
I'll do it gain. Hopefully it will last longer this time.

________________________________________
From: Burton, Ross [[email protected]]
Sent: Friday, April 13, 2018 5:50 AM
To: Bystricky, Juro
Cc: Yocto-mailing-list; Juro Bystricky; Alistair Francis
Subject: Re: [yocto] [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw

Is it feasible to fix the original patch?

Ross

Quoted 33 lines · Juro Bystricky

The commit "qemu: Bump to version 2.11.0" in oe-core broke the build of qemu for mingw, due to using "socketpair", which is not supported by mingw. "socketpair" is used in a local patch, not in the qemu upstream code. The original local patch had conditional code to exclude "socketpair" for _WIN32, but the modified patch for qemu 2.11.0 removed this.

The fix is to simply remove the offending patch.

---
 recipes-devtools/qemu/qemu_2.11.%.bbappend | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 recipes-devtools/qemu/qemu_2.11.%.bbappend
recipes-devtools/qemu/qemu_2.11.%.bbappend new file +4 -1
new file mode 100644
index 0000000..764b500
@@ -0,0 +1,4 @@
+
+
+SRC_URI_remove_mingw32 = "file://chardev-connect-socket-to-a-spawned-command.patch"
+
--

2.7.4

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#4 lore raw
Quoted 1 line · Ross

Thanks Juro. I'll remember to keep an eye out for the ifdefs disappearing.

Maybe add some comments in the patch to ensure whoever is working with it knows why they are there.

Alistair

Quoted 59 lines

Ross

Quoted 45 lines · Juro

yes, I've done it before:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=sumo&id=bc112b8368eb3842ccb2430fdf17e736ea39a742
I'll do it gain. Hopefully it will last longer this time.

________________________________________
From: Burton, Ross [[email protected]]
Sent: Friday, April 13, 2018 5:50 AM
To: Bystricky, Juro
Cc: Yocto-mailing-list; Juro Bystricky; Alistair Francis
Subject: Re: [yocto] [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw

Is it feasible to fix the original patch?

Ross

Quoted 28 lines · Juro Bystricky

The commit "qemu: Bump to version 2.11.0" in oe-core broke the build of qemu for mingw, due to using "socketpair", which is not supported by mingw. "socketpair" is used in a local patch, not in the qemu upstream code. The original local patch had conditional code to exclude "socketpair" for _WIN32, but the modified patch for qemu 2.11.0 removed this.

The fix is to simply remove the offending patch.

---
 recipes-devtools/qemu/qemu_2.11.%.bbappend | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 recipes-devtools/qemu/qemu_2.11.%.bbappend
recipes-devtools/qemu/qemu_2.11.%.bbappend new file +4 -1
new file mode 100644
index 0000000..764b500
@@ -0,0 +1,4 @@
+
+
+SRC_URI_remove_mingw32 = "file://chardev-connect-socket-to-a-spawned-command.patch"
+
--

2.7.4

Quoted 5 lines
Quoted 5 lines

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto