Skip to contentSkip to conversation

net/nfp: fix possible resource leak

PATCH Applied Yangchao Zhou 3 participants 3 messages Apr 17, 2018 Network drivers

lore
Share & tools
lore

Yangchao Zhou

author
#0 lore raw

PATCH 1/1 net/nfp: fix possible resource leak

Signed-off-by Yangchao Zhou <[email protected]>
---
 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c +1 -0
index ad6ce72..f2fcc4a 100644
@@ -816,6 +816,7 @@ struct nfp6000_area_priv {
 
 	if (fscanf(fp, "0x%lx 0x%lx 0x%lx", &start, &end, &flags) == 0) {
 		printf("error reading resource file for bar size\n");
+		fclose(fp);
 		return -1;
 	}
Signature · 1 line
1.7.1
Acked-by on v1 1/1
#1 lore raw
Acked-by Alejandro Lucero <[email protected]>
Quoted 22 lines · Yangchao Zhou
Signed-off-by Yangchao Zhou <[email protected]>
---
 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c +1 -1
index ad6ce72..f2fcc4a 100644
@@ -816,6 +816,7 @@ struct nfp6000_area_priv {
 
        if (fscanf(fp, "0x%lx 0x%lx 0x%lx", &start, &end, &flags) == 0) {
                printf("error reading resource file for bar size\n");
+               fclose(fp);
                return -1;
        }
 
--

1.7.1