Skip to contentSkip to conversation

drm/i915/audio: Fix audio detection issue on GLK

PATCH In review Gaurav K Singh 5 participants 7 messages Apr 17, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/audio: Fix audio detection issue on GLK

On Geminilake, sometimes audio card is not getting detected after reboot. This is a spurious issue happening on Geminilake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked for GLK. Extending this fix to GLK as well.

Tested by Du,Wenkai on GLK board.

Bspec: 21829

v2: Instead of checking GEN9_BC, BXT and GLK macros, use IS_GEN9 macro

---
 drivers/gpu/drm/i915/intel_audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_audio.c +1 -1
index 656f6c931341..3ea566f99450 100644
@@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
 	struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
 	u32 tmp;
 
-	if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
+	if (!IS_GEN9(dev_priv))
 		return;
 
 	i915_audio_component_get_power(kdev);
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 6 lines · Gaurav K Singh

On Geminilake, sometimes audio card is not getting detected after reboot. This is a spurious issue happening on Geminilake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked for GLK. Extending this fix to GLK as well.

Quoted 8 lines

Tested by Du,Wenkai on GLK board.

Bspec: 21829

v2: Instead of checking GEN9_BC, BXT and GLK macros, use IS_GEN9 macro

That Reviewed-by is jumping to conclusions I'm afraid. Giving review comments does not mean Reviewed-by. Only explicit Reviewed-by reply does.

I can only say that this is the right approach *if* glk is to be covered here, but I have no data to actually say if that's the right thing to do.

BR,
Jani.

Quoted 17 lines
---
 drivers/gpu/drm/i915/intel_audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_audio.c +1 -1
index 656f6c931341..3ea566f99450 100644
@@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
 	struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
 	u32 tmp;
 
-	if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
+	if (!IS_GEN9(dev_priv))
 		return;
 
 	i915_audio_component_get_power(kdev);
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

✗ Fi.CI.BAT: failure for drm/i915/audio: Fix audio detection issue on GLK (rev2)

In reply to Gaurav K Singh
== Series Details ==

== Series Details ==

Series: drm/i915/audio: Fix audio detection issue on GLK (rev2)
URL : https://patchwork.freedesktop.org/series/41334/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4058 -> Patchwork_8701 =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_8701 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_8701, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/41334/revisions/2/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_8701:

=== IGT changes ===

    ==== Possible regressions ====

    igt@gem_exec_suspend@basic-s3:
      fi-ivb-3520m:       PASS -> DMESG-WARN

    
    ==== Warnings ====

    igt@prime_vgem@basic-fence-flip:
      fi-cnl-y3:          SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_8701 that come from known issues:

=== IGT changes ===

    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-bxt-dsi:         INCOMPLETE (fdo#103927) -> PASS

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927

== Participating hosts (35 -> 33) ==

Additional (1): fi-glk-1
Missing (3): fi-ilk-m540 fi-cnl-psr fi-skl-6700hq

== Build changes ==

* Linux: CI_DRM_4058 -> Patchwork_8701

CI_DRM_4058: 241d827c86078c4709c00251d22ea8f7554e3e36 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4432: 8b77704db49167f7ebfd1c470d9c129d3b862cb6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8701: 55226f577b074d07d717a4894646ead57dfd4cf2 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4432: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit

== Linux commits ==

55226f577b07 drm/i915/audio: Fix audio detection issue on GLK

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8701/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Re: ✗ Fi.CI.BAT: failure for drm/i915/audio: Fix audio detection issue on GLK (rev2)

Quoted 23 lines · Patchwork

== Series Details ==

Series: drm/i915/audio: Fix audio detection issue on GLK (rev2)
URL : https://patchwork.freedesktop.org/series/41334/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4058 -> Patchwork_8701 =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_8701 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_8701, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/41334/revisions/2/mbox/

== Possible new issues ==

Quoted 8 lines

Here are the unknown changes that may have been introduced in Patchwork_8701:

=== IGT changes ===

    ==== Possible regressions ====

    igt@gem_exec_suspend@basic-s3:
      fi-ivb-3520m:       PASS -> DMESG-WARN

https://bugs.freedesktop.org/show_bug.cgi?id=106084

I re-queued the testing to get the shards.

Quoted 47 lines
    
    ==== Warnings ====

    igt@prime_vgem@basic-fence-flip:
      fi-cnl-y3:          SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_8701 that come from known issues:

=== IGT changes ===

    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-bxt-dsi:         INCOMPLETE (fdo#103927) -> PASS

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927

== Participating hosts (35 -> 33) ==

Additional (1): fi-glk-1
Missing (3): fi-ilk-m540 fi-cnl-psr fi-skl-6700hq

== Build changes ==

* Linux: CI_DRM_4058 -> Patchwork_8701

CI_DRM_4058: 241d827c86078c4709c00251d22ea8f7554e3e36 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4432: 8b77704db49167f7ebfd1c470d9c129d3b862cb6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8701: 55226f577b074d07d717a4894646ead57dfd4cf2 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4432: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit

== Linux commits ==

55226f577b07 drm/i915/audio: Fix audio detection issue on GLK

Quoted 8 lines

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8701/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

✓ Fi.CI.BAT: success for drm/i915/audio: Fix audio detection issue on GLK (rev2)

In reply to Gaurav K Singh
== Series Details ==

== Series Details ==

Series: drm/i915/audio: Fix audio detection issue on GLK (rev2)
URL : https://patchwork.freedesktop.org/series/41334/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4058 -> Patchwork_8702 =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_8702 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_8702, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/41334/revisions/2/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_8702:

=== IGT changes ===

    ==== Warnings ====

    igt@prime_vgem@basic-fence-flip:
      fi-cnl-y3:          SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_8702 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-ivb-3520m:       PASS -> DMESG-WARN (fdo#106084)

    igt@vgem_basic@dmabuf-fence-before:
      fi-glk-1:           NOTRUN -> INCOMPLETE (k.org#198133, fdo#103359)

    
    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@gem_mmap_gtt@basic-small-bo-tiledx:
      fi-gdg-551:         FAIL (fdo#102575) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-bxt-dsi:         INCOMPLETE (fdo#103927) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-ivb-3520m:       DMESG-WARN (fdo#106084) -> PASS

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133

== Participating hosts (35 -> 33) ==

Additional (1): fi-glk-1
Missing (3): fi-ilk-m540 fi-cnl-psr fi-skl-6700hq

== Build changes ==

* Linux: CI_DRM_4058 -> Patchwork_8702

CI_DRM_4058: 241d827c86078c4709c00251d22ea8f7554e3e36 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4432: 8b77704db49167f7ebfd1c470d9c129d3b862cb6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8702: 6dad30273262e306bac397d83d45f603da5607f0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4432: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit

== Linux commits ==

6dad30273262 drm/i915/audio: Fix audio detection issue on GLK

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8702/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

✗ Fi.CI.IGT: failure for drm/i915/audio: Fix audio detection issue on GLK (rev2)

In reply to Gaurav K Singh
== Series Details ==

== Series Details ==

Series: drm/i915/audio: Fix audio detection issue on GLK (rev2)
URL : https://patchwork.freedesktop.org/series/41334/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4058_full -> Patchwork_8702_full =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_8702_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_8702_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/41334/revisions/2/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_8702_full:

=== IGT changes ===

    ==== Possible regressions ====

    igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible:
      shard-apl:          PASS -> FAIL

    
    ==== Warnings ====

    igt@gem_mocs_settings@mocs-rc6-ctx-render:
      shard-kbl:          SKIP -> PASS

    igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
      shard-snb:          PASS -> SKIP +1

== Known issues ==

Here are the changes found in Patchwork_8702_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_store@cachelines-bsd:
      shard-hsw:          PASS -> FAIL (fdo#100007)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-hsw:          FAIL (fdo#105189) -> PASS

    igt@kms_flip@blocking-wf_vblank:
      shard-hsw:          FAIL (fdo#103928) -> PASS

fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#105189 https://bugs.freedesktop.org/show_bug.cgi?id=105189
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

== Participating hosts (6 -> 4) ==

Missing (2): shard-glk shard-glkb

== Build changes ==

* Linux: CI_DRM_4058 -> Patchwork_8702

CI_DRM_4058: 241d827c86078c4709c00251d22ea8f7554e3e36 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4432: 8b77704db49167f7ebfd1c470d9c129d3b862cb6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8702: 6dad30273262e306bac397d83d45f603da5607f0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4432: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8702/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#6 lore raw
In reply to Gaurav K Singh
Quoted 6 lines · Gaurav K Singh

On Geminilake, sometimes audio card is not getting detected after reboot. This is a spurious issue happening on Geminilake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked for GLK. Extending this fix to GLK as well.

Quoted 8 lines

Tested by Du,Wenkai on GLK board.

Bspec: 21829

v2: Instead of checking GEN9_BC, BXT and GLK macros, use IS_GEN9 macro

Quoted 9 lines
---
  drivers/gpu/drm/i915/intel_audio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_audio.c +0 -0
index 656f6c931341..3ea566f99450 100644

drivers/gpu/drm/i915/intel_audio.c static void i915_audio_component_codec_wake_override(struct device *kdev, · line 735

Quoted 8 lines
drivers/gpu/drm/i915/intel_audio.c +1 -1
@@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
  	struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
  	u32 tmp;
 
-	if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
+	if (!IS_GEN9(dev_priv))
  		return;
 
  	i915_audio_component_get_power(kdev);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx