Patch "MIPS: generic: Fix machine compatible matching" has been added to the 4.14-stable tree
[email protected]
AppliedThis is a note to let you know that I've just added the patch titled
MIPS: generic: Fix machine compatible matching
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mips-generic-fix-machine-compatible-matching.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line · On Tue, Apr 24, 2018 at 05:01:06PM +0200, [email protected] wrote:
We now have a platform (Ranchu) in the "generic" platform which matches
The reason I didn't tag stable was because Ranchu was added in 4.16 ...
Review
Quoted 2 lines
(quoted diff) +0
-0if (!mach->matches) return NULL;
... so mach->matches will always be NULL before 4.16 ...
Review
Quoted 3 lines
(quoted diff) +1
-1- for (match = mach->matches; match->compatible; match++) { + for (match = mach->matches; match->compatible[0]; match++) {
... so this can't get hit.
Feel free to drop, otherwise it does no harm, its dead code.
Cheers
James
Quoted 11 lines · James Hogan
Quoted 1 line · On Tue, Apr 24, 2018 at 05:01:06PM +0200, [email protected] wrote:
We now have a platform (Ranchu) in the "generic" platform which matches
The reason I didn't tag stable was because Ranchu was added in 4.16 ...
Review
Quoted 2 lines
(quoted diff) +0
-0if (!mach->matches) return NULL;... so
mach->matcheswill always be NULL before 4.16 ...Quoted 1 line
Quoted 6 lines
Review
Quoted 2 lines
(quoted diff) +1
-1- for (match = mach->matches; match->compatible; match++) { + for (match = mach->matches; match->compatible[0]; match++) {... so this can't get hit.
Feel free to drop, otherwise it does no harm, its dead code.
Now dropped, thanks for letting me know.
greg k-h