trace: initcall: Ordered comparison of function pointers
PATCH 1/1 trace: initcall: Ordered comparison of function pointers
Using initcall_t in the __field macro generates the follwing warning with clang version 6.0:
include/trace/events/initcall.h:34:3: warning: ordered comparison of function pointers ('initcall_t' (aka 'int (*)(void)') and 'initcall_t')
__field macro expands to __field_ext macro which does is_signed_type check on the type argument. Since initcall_t is defined as a function pointer, using it as the type in the __field macro, leads to an ordered comparison of function pointer warning, inside the check. Using __field_struct macro avoids the issue.
Signed-off-by Rishabh Bhatnagar <[email protected]>
--- include/trace/events/initcall.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/trace/events/initcall.h +2 -2
@@ -31,7 +31,7 @@TP_ARGS (func),TP_STRUCT__entry ( -__field (initcall_t, func) +__field_struct (initcall_t, func) ), TP_fast_assign(
@@ -48,7 +48,7 @@TP_ARGS (func, ret),TP_STRUCT__entry ( - __field(initcall_t, func) + __field_struct(initcall_t, func)__field (int, ret) ),
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project