Skip to contentSkip to conversation

net/axgbe: fix coverity issue 277239

PATCH Applied Ravi Kumar 2 participants 2 messages May 2, 2018 Network drivers

lore
Share & tools
lore

Ravi Kumar

author
#0 lore raw

PATCH 1/1 net/axgbe: fix coverity issue 277239

Stored register value to enable jumbo frame was always overwritten. Assigning value based on rx_buf_size.

---
 drivers/net/axgbe/axgbe_dev.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/axgbe/axgbe_dev.c +0 -1
index d05f9c8..707f1ee 100644
@@ -1019,7 +1019,6 @@ static void axgbe_config_jumbo_enable(struct axgbe_port *pdata)
 	unsigned int val;
 
 	val = (pdata->rx_buf_size > AXGMAC_STD_PACKET_MTU) ? 1 : 0;
-	val = 1;
 
 	AXGMAC_IOWRITE_BITS(pdata, MAC_RCR, JE, val);
 }
Signature · 1 line
2.7.4
Applied
#1 lore raw
Quoted 4 lines · Ravi Kumar

Stored register value to enable jumbo frame was always overwritten. Assigning value based on rx_buf_size.

Updated as:
net/axgbe: fix value always overwritten

Stored register value to enable jumbo frame was always overwritten. Assigning value based on rx_buf_size.

Coverity issue: 277239

Fixes 7c4158a5b592 ("net/axgbe: add DMA programming and start/stop")

Applied to dpdk-next-net/master, thanks.