Skip to contentSkip to conversation

openobex: explicitly set ASNEEDED from openobex recipe

PATCH In review Andre McCurdy 2 participants 3 messages May 4, 2018 – May 8, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 openobex: explicitly set ASNEEDED from openobex recipe

Up to now, an openobex specific over-ride for ASNEEDED has been provided by oe-core (from as-needed.inc). If ASNEEDED does need to be over-ridden in order to build openobex it's not ideal that the over-ride comes from a different layer so define it directly in the meta-oe recipe.

---
 meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb +2 -0
index 2db48f3..1b56685 100644
@@ -25,6 +25,8 @@ EXTRA_OECMAKE += "-DBUILD_DOCUMENTATION=OFF"
 
 #--enable-apps --enable-syslog
 
+ASNEEDED = ""
+
 do_install_append () {
     rmdir ${D}${bindir}
 }
Signature · 1 line
1.9.1
#1 lore raw
Quoted 6 lines · Andre McCurdy

Up to now, an openobex specific over-ride for ASNEEDED has been provided by oe-core (from as-needed.inc). If ASNEEDED does need to be over-ridden in order to build openobex it's not ideal that the over-ride comes from a different layer so define it directly in the meta-oe recipe.

Hi,

don't we have a special include for this purpose?
/meta/conf/distro/include/as-needed.inc
What want we do? ASNEEDED in the recipe or include the as_needed.inc?

For me, patch is ok, all in the recipe (there are just few cases).

Cheers
Andrea

Quoted 26 lines
---
 meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb +2 -1
index 2db48f3..1b56685 100644
@@ -25,6 +25,8 @@ EXTRA_OECMAKE += "-DBUILD_DOCUMENTATION=OFF"
 
 #--enable-apps --enable-syslog
 
+ASNEEDED = ""
+
 do_install_append () {
     rmdir ${D}${bindir}
 }
--

1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw
Quoted 7 lines · Andrea Adami
Quoted 6 lines · Andre McCurdy

Up to now, an openobex specific over-ride for ASNEEDED has been provided by oe-core (from as-needed.inc). If ASNEEDED does need to be over-ridden in order to build openobex it's not ideal that the over-ride comes from a different layer so define it directly in the meta-oe recipe.

Quoted 5 lines

Hi,

don't we have a special include for this purpose?
/meta/conf/distro/include/as-needed.inc
What want we do? ASNEEDED in the recipe or include the as_needed.inc?

We want to move the ASNEEDED over-ride from as_needed.inc into the recipe. For a short time during the transition the over-ride will be applied from both places.

Quoted 31 lines

For me, patch is ok, all in the recipe (there are just few cases).

Cheers
Andrea

Quoted 26 lines
---
 meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb +2 -1
index 2db48f3..1b56685 100644
@@ -25,6 +25,8 @@ EXTRA_OECMAKE += "-DBUILD_DOCUMENTATION=OFF"
 
 #--enable-apps --enable-syslog
 
+ASNEEDED = ""
+
 do_install_append () {
     rmdir ${D}${bindir}
 }
--

1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel