MAINTAINERS: Add trace-events and qemu-option-trace.texi to tracing section
PATCH 1/1 MAINTAINERS: Add trace-events and qemu-option-trace.texi to tracing section
The "trace-events" and "qemu-option-trace.texi" files in the top directory are currently "unmaintained" according to scripts/get_maintainer.pl. They obviously belong to the Tracing section, so add an entry for them there.
--- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
@@ -1656,6 +1656,8 @@ Tracing M: Stefan Hajnoczi <[email protected]> S: Maintained F: trace/ +F: trace-events +F: qemu-option-trace.texi F: scripts/tracetool.py F: scripts/tracetool/ F: docs/devel/tracing.txt
Signature · 1 line
1.8.3.1
Hi Thomas,
Quoted 3 lines · Thomas Huth
The "trace-events" and "qemu-option-trace.texi" files in the top directory are currently "unmaintained" according to
scripts/get_maintainer.pl. They obviously belong to the Tracing section, so add an entry for them there.
I agree qemu-option-trace.texi belongs to the Tracing section, however I think trace-events is not specific to Tracing but belongs to everybody maintaining a C file in the top directory... Since they'll need to modify this file.
Quoted 10 lines
Signed-off-by Thomas Huth <[email protected]>--- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+)MAINTAINERS +0
-0
MAINTAINERS Tracing · line 1659
Quoted 4 lines
MAINTAINERS +1
-0@@ -1656,6 +1656,8 @@ Tracing M: Stefan Hajnoczi <[email protected]> S: Maintained F: trace/ +F: trace-events
So without "trace-events":
Quoted 5 lines
MAINTAINERS +1
-0+F: qemu-option-trace.texi F: scripts/tracetool.py F: scripts/tracetool/ F: docs/devel/tracing.txt
Quoted 11 lines · Philippe Mathieu-Daudé
Hi Thomas,
Quoted 3 lines · Thomas Huth
The "trace-events" and "qemu-option-trace.texi" files in the top directory are currently "unmaintained" according to
scripts/get_maintainer.pl. They obviously belong to the Tracing section, so add an entry for them there.I agree qemu-option-trace.texi belongs to the Tracing section, however I think trace-events is not specific to Tracing but belongs to everybody maintaining a C file in the top directory... Since they'll need to modify this file.
Right ... but what do you do if you just want to fix something in the generic comments of that file? Who's then responsible for picking up the patch? ... well, updates to comments could maybe go through qemu-trivial, too, so I'm also fine if we do not list trace-events in MAINTAINERS. I'll leave this up to Stefan to decide.
Thomas
Quoted 11 lines · Philippe Mathieu-Daudé
Hi Thomas,
Quoted 3 lines · Thomas Huth
The "trace-events" and "qemu-option-trace.texi" files in the top directory are currently "unmaintained" according to
scripts/get_maintainer.pl. They obviously belong to the Tracing section, so add an entry for them there.I agree qemu-option-trace.texi belongs to the Tracing section, however I think trace-events is not specific to Tracing but belongs to everybody maintaining a C file in the top directory... Since they'll need to modify this file.
I'd rather hear Stefan's opinion before outright nixing the addition of trace-events to his section - personally, I think any patch touching a trace-events is fair game for review by the tracing tree, even if it ends up going in through another tree.
Signature · 3 lines
Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
Stefan Hajnoczi
AppliedQuoted 8 lines · Thomas Huth
The "trace-events" and "qemu-option-trace.texi" files in the top directory are currently "unmaintained" according to
scripts/get_maintainer.pl. They obviously belong to the Tracing section, so add an entry for them there.Signed-off-by Thomas Huth <[email protected]>--- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+)
Thanks for the discussion!
I'm happy to serve as a catch-all for trace-events patches (especially trace events in unmaintained code). It is preferrable for trace-events changes to go via the subsystem, if there is a maintainer.
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan