Skip to contentSkip to conversation

PCI: keystone: Do not treat link up message as error

PATCH Applied Fabio Estevam 3 participants 3 messages May 9, 2018 – May 14, 2018 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: keystone: Do not treat link up message as error

From: Fabio Estevam <[email protected]>

The "Link already up" message does not indicate any error, so change it to dev_info() level instead.

---
 drivers/pci/dwc/pci-keystone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/dwc/pci-keystone.c +1 -1
index d55ae07..3722a5f 100644
@@ -89,7 +89,7 @@ static int ks_pcie_establish_link(struct keystone_pcie *ks_pcie)
 	dw_pcie_setup_rc(pp);
 
 	if (dw_pcie_link_up(pci)) {
-		dev_err(dev, "Link already up\n");
+		dev_info(dev, "Link already up\n");
 		return 0;
 	}
 
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 16 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The "Link already up" message does not indicate any error, so change it to dev_info() level instead.

---
 drivers/pci/dwc/pci-keystone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/dwc/pci-keystone.c +0 -0
index d55ae07..3722a5f 100644

drivers/pci/dwc/pci-keystone.c static int ks_pcie_establish_link(struct keystone_pcie *ks_pcie) · line 95

Quoted 8 lines
drivers/pci/dwc/pci-keystone.c +1 -1
@@ -89,7 +89,7 @@ static int ks_pcie_establish_link(struct keystone_pcie *ks_pcie)
 	dw_pcie_setup_rc(pp);
 
 	if (dw_pcie_link_up(pci)) {
-		dev_err(dev, "Link already up\n");
+		dev_info(dev, "Link already up\n");
 		return 0;
 	}
 
#2 lore raw
In reply to Fabio Estevam
Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The "Link already up" message does not indicate any error, so change it to dev_info() level instead.

---
 drivers/pci/dwc/pci-keystone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/dwc for v4.18, thanks.

Lorenzo

Quoted 16 lines
drivers/pci/dwc/pci-keystone.c +1 -1
index d55ae07..3722a5f 100644
@@ -89,7 +89,7 @@ static int ks_pcie_establish_link(struct keystone_pcie *ks_pcie)
 	dw_pcie_setup_rc(pp);
 
 	if (dw_pcie_link_up(pci)) {
-		dev_err(dev, "Link already up\n");
+		dev_info(dev, "Link already up\n");
 		return 0;
 	}
 
Signature · 1 line
2.7.4