Skip to contentSkip to conversation

qemu: add gettext to DEPENDS

PATCH Superseded Chris Patterson 3 participants 5 messages May 11, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qemu: add gettext to DEPENDS

From: Chris Patterson <[email protected]>

Otherwise QEMU build may fail with missing msgfmt command.

| make -C po install
|   GEN     bg.mo
|   GEN     tr.mo
|   GEN     de_DE.mo
| /bin/sh: msgfmt: command not found
| /bin/sh: msgfmt: command not found
---
 meta/recipes-devtools/qemu/qemu.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/qemu/qemu.inc +1 -1
index dc73df8..ba1b9b2 100644
@@ -1,7 +1,7 @@
 SUMMARY = "Fast open source processor emulator"
 HOMEPAGE = "http://qemu.org"
 LICENSE = "GPLv2 & LGPLv2.1"
-DEPENDS = "glib-2.0 zlib pixman"
+DEPENDS = "glib-2.0 zlib pixman gettext"
 RDEPENDS_${PN}_class-target += "bash"
 
 require qemu-targets.inc
Signature · 1 line
2.1.4
#1 lore raw

This is not a correct fix. We have a gettext bbclass for a reason.

Quoted 39 lines · Chris Patterson

From: Chris Patterson <[email protected]>

Otherwise QEMU build may fail with missing msgfmt command.

| make -C po install
|   GEN     bg.mo
|   GEN     tr.mo
|   GEN     de_DE.mo
| /bin/sh: msgfmt: command not found
| /bin/sh: msgfmt: command not found
---
 meta/recipes-devtools/qemu/qemu.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/qemu/qemu.inc +1 -2
index dc73df8..ba1b9b2 100644
@@ -1,7 +1,7 @@
 SUMMARY = "Fast open source processor emulator"
 HOMEPAGE = "http://qemu.org"
 LICENSE = "GPLv2 & LGPLv2.1"
-DEPENDS = "glib-2.0 zlib pixman"
+DEPENDS = "glib-2.0 zlib pixman gettext"
 RDEPENDS_${PN}_class-target += "bash"
 
 require qemu-targets.inc
--

2.1.4

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 4 lines
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
#2 lore raw
Quoted 2 lines · Christopher Larson

This is not a correct fix. We have a gettext bbclass for a reason.

I did look at that prior to doing this. It was my initial approach, but inheriting gettext causes qemu build to fail when it modifies the EXTRA_OECONF options with the nls flag (that qemu doesn't process). There are quite a few other recipes using gettext-native in their DEPENDS, and the reason for one over the other isn't quite clear.

In the other thread (v2), Khem requested it only be added conditionally if the gtk packageconfig flag is enabled. Do you think it would be appropriate to check packageconfig flag, then conditionally inherit, then resolve (scrub) the unsupported configure flags? Or modify the class such that modifying the OECONF is prevented to begin with?

Cheers!

#3 lore raw
Quoted 10 lines · Chris Patterson
Quoted 2 lines · Christopher Larson

This is not a correct fix. We have a gettext bbclass for a reason.

I did look at that prior to doing this. It was my initial approach, but inheriting gettext causes qemu build to fail when it modifies the EXTRA_OECONF options with the nls flag (that qemu doesn't process). There are quite a few other recipes using gettext-native in their DEPENDS, and the reason for one over the other isn't quite clear.

Quoted 6 lines

In the other thread (v2), Khem requested it only be added conditionally if the gtk packageconfig flag is enabled. Do you think it would be appropriate to check packageconfig flag, then conditionally inherit, then resolve (scrub) the unsupported configure flags? Or modify the class such that modifying the OECONF is prevented to begin with?

Are you using gtk PACKAGECONFIG for qemu-native (or nativesdk-qemu)? Last time I've tried I've found that there are many things missing to make it usable, see last few commits at:
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/qemu

I haven't tried gtk(3) for target build, it probably works better there.

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw
Quoted 18 lines · Martin Jansa
Quoted 10 lines · Chris Patterson
Quoted 2 lines · Christopher Larson

This is not a correct fix. We have a gettext bbclass for a reason.

I did look at that prior to doing this. It was my initial approach, but inheriting gettext causes qemu build to fail when it modifies the EXTRA_OECONF options with the nls flag (that qemu doesn't process). There are quite a few other recipes using gettext-native in their DEPENDS, and the reason for one over the other isn't quite clear.

Quoted 6 lines

In the other thread (v2), Khem requested it only be added conditionally if the gtk packageconfig flag is enabled. Do you think it would be appropriate to check packageconfig flag, then conditionally inherit, then resolve (scrub) the unsupported configure flags? Or modify the class such that modifying the OECONF is prevented to begin with?

Quoted 7 lines

Are you using gtk PACKAGECONFIG for qemu-native (or nativesdk-qemu)? Last time I've tried I've found that there are many things missing to make it usable, see last few commits at:
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/qemu

I haven't tried gtk(3) for target build, it probably works better there.

I was looking to use it in my image (non-native). Thank you for the info!