Skip to contentSkip to conversation

ARM: dts: imx51-babbage: Fix USB PHY duplicate unit-address

PATCH Superseded Fabio Estevam 3 participants 4 messages May 14, 2018 – May 22, 2018

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 ARM: dts: imx51-babbage: Fix USB PHY duplicate unit-address

From: Fabio Estevam <[email protected]>

Currently the following DTC warning is seen with W=1:

arch/arm/boot/dts/imx51-babbage.dtb: Warning (unique_unit_address): /usbphy/usbphy at 0: duplicate unit-address (also used in node /usbphy/usbh1phy at 0)

Fix it by moving the USB PHY node outside of simple-bus and drop the unneeded unit-address.

---
 arch/arm/boot/dts/imx51-babbage.dts | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)
arch/arm/boot/dts/imx51-babbage.dts +7 -14
index b8ca73d..de46906 100644
@@ -170,20 +170,13 @@
 		mux-ext-port = <3>;
 	};
 
-	usbphy {
-		#address-cells = <1>;
-		#size-cells = <0>;
-		compatible = "simple-bus";
-
-		usbh1phy: usbh1phy at 0 {
-			compatible = "usb-nop-xceiv";
-			reg = <0>;
-			clocks = <&clk_usb>;
-			clock-names = "main_clk";
-			reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
-			vcc-supply = <&vusb_reg>;
-			#phy-cells = <0>;
-		};
+	usbh1phy: usbphy1 {
+		compatible = "usb-nop-xceiv";
+		clocks = <&clk_usb>;
+		clock-names = "main_clk";
+		reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
+		vcc-supply = <&vusb_reg>;
+		#phy-cells = <0>;
 	};
 };
 
Signature · 1 line
2.7.4
author reviewer
#1 lore raw

PATCH 2/2 ARM: dts: iimx51-eukrea-mbimxsd51-baseboard: Fix USB PHY duplicate unit-address

From: Fabio Estevam <[email protected]>

Currently the following DTC warning is seen with W=1:

arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dtb: Warning (unique_unit_address): /usbphy/usbphy at 0: duplicate unit-address (also used in node /usbphy/usbh1phy at 0)

Fix it by moving the USB PHY node outside of simple-bus and drop the unneeded unit-address.

---
 .../arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)
arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts +6 -13
index b3d952f..29b0b7b 100644
@@ -83,19 +83,12 @@
 		fsl,mux-ext-port = <3>;
 	};
 
-	usbphy {
-		#address-cells = <1>;
-		#size-cells = <0>;
-		compatible = "simple-bus";
-
-		usbh1phy: usbh1phy at 0 {
-			compatible = "usb-nop-xceiv";
-			reg = <0>;
-			clocks = <&clks IMX5_CLK_USB_PHY_GATE>;
-			clock-names = "main_clk";
-			clock-frequency = <19200000>;
-			#phy-cells = <0>;
-		};
+	usbh1phy: usbphy {
+		compatible = "usb-nop-xceiv";
+		clocks = <&clks IMX5_CLK_USB_PHY_GATE>;
+		clock-names = "main_clk";
+		clock-frequency = <19200000>;
+		#phy-cells = <0>;
 	};
 };
 
Signature · 1 line
2.7.4
#2 lore raw

PATCH 1/2 ARM: dts: imx51-babbage: Fix USB PHY duplicate unit-address

In reply to Fabio Estevam
Quoted 33 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Currently the following DTC warning is seen with W=1:

arch/arm/boot/dts/imx51-babbage.dtb: Warning (unique_unit_address): /usbphy/usbphy at 0: duplicate unit-address (also used in node /usbphy/usbh1phy at 0)

Fix it by moving the USB PHY node outside of simple-bus and drop the unneeded unit-address.

---
 arch/arm/boot/dts/imx51-babbage.dts | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)
arch/arm/boot/dts/imx51-babbage.dts +0 -11
index b8ca73d..de46906 100644
@@ -170,20 +170,13 @@
 		mux-ext-port = <3>;
 	};
 
-	usbphy {
-		#address-cells = <1>;
-		#size-cells = <0>;
-		compatible = "simple-bus";
-
-		usbh1phy: usbh1phy at 0 {
-			compatible = "usb-nop-xceiv";
-			reg = <0>;
-			clocks = <&clk_usb>;
-			clock-names = "main_clk";
-			reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;

arch/arm/boot/dts/imx51-babbage.dts line 179

Quoted 10 lines
arch/arm/boot/dts/imx51-babbage.dts +7 -3
-			vcc-supply = <&vusb_reg>;
-			#phy-cells = <0>;
-		};
+	usbh1phy: usbphy1 {
+		compatible = "usb-nop-xceiv";
+		clocks = <&clk_usb>;
+		clock-names = "main_clk";
+		reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
+		vcc-supply = <&vusb_reg>;
+		#phy-cells = <0>;

This should be considered as a whole together with usbphy in imx51.dtsi. Also, I would like to get some input from DT folks on how we should name the node uniquely. @Rob.

Shawn

Quoted 6 lines
arch/arm/boot/dts/imx51-babbage.dts +0 -0
 	};
 };
 
Signature · 1 line
2.7.4
maintainer
#3 lore raw

PATCH 1/2 ARM: dts: imx51-babbage: Fix USB PHY duplicate unit-address

Quoted 40 lines · Shawn Guo
Quoted 39 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Currently the following DTC warning is seen with W=1:

arch/arm/boot/dts/imx51-babbage.dtb: Warning (unique_unit_address): /usbphy/usbphy at 0: duplicate unit-address (also used in node /usbphy/usbh1phy at 0)

Fix it by moving the USB PHY node outside of simple-bus and drop the unneeded unit-address.

---
 arch/arm/boot/dts/imx51-babbage.dts | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)
arch/arm/boot/dts/imx51-babbage.dts +3 -14
index b8ca73d..de46906 100644
@@ -170,20 +170,13 @@
 		mux-ext-port = <3>;
 	};
 
-	usbphy {
-		#address-cells = <1>;
-		#size-cells = <0>;
-		compatible = "simple-bus";
-
-		usbh1phy: usbh1phy at 0 {
-			compatible = "usb-nop-xceiv";
-			reg = <0>;
-			clocks = <&clk_usb>;
-			clock-names = "main_clk";
-			reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
-			vcc-supply = <&vusb_reg>;
-			#phy-cells = <0>;
-		};
+	usbh1phy: usbphy1 {
+		compatible = "usb-nop-xceiv";
+		clocks = <&clk_usb>;
Quoted 8 lines

arch/arm/boot/dts/imx51-babbage.dts line 179

Quoted 4 lines
arch/arm/boot/dts/imx51-babbage.dts +4 -0
+		clock-names = "main_clk";
+		reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
+		vcc-supply = <&vusb_reg>;
+		#phy-cells = <0>;

This should be considered as a whole together with usbphy in imx51.dtsi. Also, I would like to get some input from DT folks on how we should name the node uniquely. @Rob.

'usbphy1' is fine. I don't have a better suggestion...

Rob