ARM: dts: imx51-babbage: Fix USB PHY duplicate unit-address
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/2 ARM: dts: imx51-babbage: Fix USB PHY duplicate unit-address
From: Fabio Estevam <[email protected]>
Currently the following DTC warning is seen with W=1:
arch/arm/boot/dts/imx51-babbage.dtb: Warning (unique_unit_address): /usbphy/usbphy at 0: duplicate unit-address (also used in node /usbphy/usbh1phy at 0)
Fix it by moving the USB PHY node outside of simple-bus and drop the unneeded unit-address.
--- arch/arm/boot/dts/imx51-babbage.dts | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-)
arch/arm/boot/dts/imx51-babbage.dts +7 -14
@@ -170,20 +170,13 @@ mux-ext-port = <3>; }; - usbphy { - #address-cells = <1>; - #size-cells = <0>; - compatible = "simple-bus"; - - usbh1phy: usbh1phy at 0 { - compatible = "usb-nop-xceiv"; - reg = <0>; - clocks = <&clk_usb>; - clock-names = "main_clk"; - reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>; - vcc-supply = <&vusb_reg>; - #phy-cells = <0>; - }; + usbh1phy: usbphy1 { + compatible = "usb-nop-xceiv"; + clocks = <&clk_usb>; + clock-names = "main_clk"; + reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>; + vcc-supply = <&vusb_reg>; + #phy-cells = <0>; }; };
Signature · 1 line
2.7.4
Fabio Estevam
reviewerPATCH 2/2 ARM: dts: iimx51-eukrea-mbimxsd51-baseboard: Fix USB PHY duplicate unit-address
From: Fabio Estevam <[email protected]>
Currently the following DTC warning is seen with W=1:
arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dtb: Warning (unique_unit_address): /usbphy/usbphy at 0: duplicate unit-address (also used in node /usbphy/usbh1phy at 0)
Fix it by moving the USB PHY node outside of simple-bus and drop the unneeded unit-address.
--- .../arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-)
arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts +6 -13
@@ -83,19 +83,12 @@ fsl,mux-ext-port = <3>; }; - usbphy { - #address-cells = <1>; - #size-cells = <0>; - compatible = "simple-bus"; - - usbh1phy: usbh1phy at 0 { - compatible = "usb-nop-xceiv"; - reg = <0>; - clocks = <&clks IMX5_CLK_USB_PHY_GATE>; - clock-names = "main_clk"; - clock-frequency = <19200000>; - #phy-cells = <0>; - }; + usbh1phy: usbphy { + compatible = "usb-nop-xceiv"; + clocks = <&clks IMX5_CLK_USB_PHY_GATE>; + clock-names = "main_clk"; + clock-frequency = <19200000>; + #phy-cells = <0>; }; };
Signature · 1 line
2.7.4
PATCH 1/2 ARM: dts: imx51-babbage: Fix USB PHY duplicate unit-address
In reply to Fabio EstevamQuoted 33 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Currently the following DTC warning is seen with W=1:
arch/arm/boot/dts/imx51-babbage.dtb: Warning (unique_unit_address): /usbphy/usbphy at 0: duplicate unit-address (also used in node /usbphy/usbh1phy at 0)Fix it by moving the USB PHY node outside of simple-bus and drop the unneeded unit-address.
Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/boot/dts/imx51-babbage.dts | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-)arch/arm/boot/dts/imx51-babbage.dts +0
-11@@ -170,20 +170,13 @@ mux-ext-port = <3>; }; - usbphy { - #address-cells = <1>; - #size-cells = <0>; - compatible = "simple-bus"; - - usbh1phy: usbh1phy at 0 { - compatible = "usb-nop-xceiv"; - reg = <0>; - clocks = <&clk_usb>; - clock-names = "main_clk"; - reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
arch/arm/boot/dts/imx51-babbage.dts line 179
Quoted 10 lines
arch/arm/boot/dts/imx51-babbage.dts +7
-3- vcc-supply = <&vusb_reg>; - #phy-cells = <0>; - }; + usbh1phy: usbphy1 { + compatible = "usb-nop-xceiv"; + clocks = <&clk_usb>; + clock-names = "main_clk"; + reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>; + vcc-supply = <&vusb_reg>; + #phy-cells = <0>;
This should be considered as a whole together with usbphy in imx51.dtsi. Also, I would like to get some input from DT folks on how we should name the node uniquely. @Rob.
Shawn
Quoted 6 lines
arch/arm/boot/dts/imx51-babbage.dts +0
-0}; };Signature · 1 line
2.7.4
Rob Herring
maintainerPATCH 1/2 ARM: dts: imx51-babbage: Fix USB PHY duplicate unit-address
Quoted 40 lines · Shawn Guo
Quoted 39 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Currently the following DTC warning is seen with W=1:
arch/arm/boot/dts/imx51-babbage.dtb: Warning (unique_unit_address): /usbphy/usbphy at 0: duplicate unit-address (also used in node /usbphy/usbh1phy at 0)Fix it by moving the USB PHY node outside of simple-bus and drop the unneeded unit-address.
Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/boot/dts/imx51-babbage.dts | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-)arch/arm/boot/dts/imx51-babbage.dts +3
-14@@ -170,20 +170,13 @@ mux-ext-port = <3>; }; - usbphy { - #address-cells = <1>; - #size-cells = <0>; - compatible = "simple-bus"; - - usbh1phy: usbh1phy at 0 { - compatible = "usb-nop-xceiv"; - reg = <0>; - clocks = <&clk_usb>; - clock-names = "main_clk"; - reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>; - vcc-supply = <&vusb_reg>; - #phy-cells = <0>; - }; + usbh1phy: usbphy1 { + compatible = "usb-nop-xceiv"; + clocks = <&clk_usb>;
Quoted 8 lines
arch/arm/boot/dts/imx51-babbage.dts line 179
Quoted 4 lines
arch/arm/boot/dts/imx51-babbage.dts +4
-0+ clock-names = "main_clk"; + reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>; + vcc-supply = <&vusb_reg>; + #phy-cells = <0>;This should be considered as a whole together with usbphy in
imx51.dtsi. Also, I would like to get some input from DT folks on how we should name the node uniquely. @Rob.
'usbphy1' is fine. I don't have a better suggestion...
Rob