Skip to contentSkip to conversation

iio: dac: fix missing of_match_table assignment in LTC2632 device

PATCH Superseded Silvan Murer 3 participants 3 messages May 15, 2018 – May 20, 2018 IIO

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Silvan Murer

author
#0 lore raw

PATCH 1/1 iio: dac: fix missing of_match_table assignment in LTC2632 device

This patch fix a missing og_match_table assignment in the LTC2632 device

Signed-off-by Silvan Murer <[email protected]>

---
 drivers/iio/dac/ltc2632.c | 19 ++++++++++---------

 1 file changed, 10 insertions(+), 9 deletions(-)
drivers/iio/dac/ltc2632.c +0 -0
index ac5e05f..d322b78 100644
@@ -276,15 +276,6 @@ static const struct spi_device_id ltc2632_id[] = {

 };
 MODULE_DEVICE_TABLE(spi, ltc2632_id);

-static struct spi_driver ltc2632_driver = {
- .driver = {
- .name = "ltc2632",
- },
- .probe = ltc2632_probe,
- .id_table = ltc2632_id,
-};
-module_spi_driver(ltc2632_driver);
-
 static const struct of_device_id ltc2632_of_match[] = {
  {
  .compatible = "lltc,ltc2632-l12",
@@ -309,6 +300,16 @@ static const struct of_device_id ltc2632_of_match[] = { };
 MODULE_DEVICE_TABLE(of, ltc2632_of_match);

+static struct spi_driver ltc2632_driver = {
+ .driver = {
+ .name = "ltc2632",
+ .of_match_table = of_match_ptr(ltc2632_of_match),
+ },
+ .probe = ltc2632_probe,
+ .id_table = ltc2632_id,
+};
+module_spi_driver(ltc2632_driver);
+
 MODULE_AUTHOR("Maxime Roussin-Belanger <[email protected]>"); MODULE_DESCRIPTION("LTC2632 DAC SPI driver"); MODULE_LICENSE("GPL v2");
--
2.7.4

maintainer
#2 lore raw
In reply to Silvan Murer
Quoted 3 lines · On Tue, 15 May 2018 16:33:02 +0200 Silvan Murer <[email protected]> wrote:

This patch fix a missing og_match_table assignment in the LTC2632 device =20

Signed-off-by Silvan Murer <[email protected]>

Hi Silvan

It is useful, until you have your work flow sorted out if you try applying the patches locally as by saving them out from your email. It just sanity checks that nothing has gone wrong.

Something very odd has gone on here. Firstly I'm seeing some unusual replacements for leading spaces and secondly some of the patch offsets etc seem to be wrong.

Please have another go but definitely test you can save out your email and successfully apply it to a clean tree.

Thanks,

Jonathan

drivers/iio/dac/ltc2632.c static const struct of_device_id ltc2632_of_match[] =

Quoted 25 lines

---
=C2=A0drivers/iio/dac/ltc2632.c | 19 ++++++++++--------- =C2=A01 file changed, 10 insertions(+), 9 deletions(-) =20

drivers/iio/dac/ltc2632.c +0 -0
index ac5e05f..d322b78 100644
@@ -276,15 +276,6 @@ static const struct spi_device_id ltc2632_id[] =3D {
 =C2=A0};
 =C2=A0MODULE_DEVICE_TABLE(spi, ltc2632_id);

=C2=A0

drivers/iio/dac/ltc2632.c +0 -9
-static struct spi_driver ltc2632_driver =3D {
-	.driver		=3D {
-		.name	=3D "ltc2632",
-	},
-	.probe		=3D ltc2632_probe,
-	.id_table	=3D ltc2632_id,
-};
-module_spi_driver(ltc2632_driver);
-

=C2=A0static const struct of_device_id ltc2632_of_match[] =3D {
=C2=A0 {
=C2=A0 .compatible =3D "lltc,ltc2632-l12",

drivers/iio/dac/ltc2632.c +0 -0
@@ -309,6 +300,16 @@ static const struct of_device_id ltc2632_of_match[] =

=3D {

Quoted 13 lines
drivers/iio/dac/ltc2632.c +0 -0
 =C2=A0};
 =C2=A0MODULE_DEVICE_TABLE(of, ltc2632_of_match);

=C2=A0

drivers/iio/dac/ltc2632.c +10 -0
+static struct spi_driver ltc2632_driver =3D {
+	.driver		=3D {
+		.name	=3D "ltc2632",
+		.of_match_table =3D of_match_ptr(ltc2632_of_match),
+	},
+	.probe		=3D ltc2632_probe,
+	.id_table	=3D ltc2632_id,
+};
+module_spi_driver(ltc2632_driver);
+
Quoted 1 line

=C2=A0MODULE_AUTHOR("Maxime Roussin-Belanger <maxime.roussinbelanger@gmai=

l.com>");

Quoted 8 lines

=C2=A0MODULE_DESCRIPTION("LTC2632 DAC SPI driver"); =C2=A0MODULE_LICENSE("GPL v2");
--=C2=A0
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html