jdepend: Update download hashes
PATCH 1/1 jdepend: Update download hashes
When Bitbake downloads jdepend-2.9.1.zip itself and I download
https://github.com/clarkware/jdepend/blob/master/dist/jdepend-2.9.1.zip , the calculated hashes don't match the ones included in the recipe.
The hashes were last changed in commit dd5c43fca8289b8795a9214aee616775e1493109 on 1st March, but GitHub claims that the file being downloaded was published on 20th January, so I can't explain why they are wrong.
Nevertheless, let's update the recipe to use hashes that match the current download.
--- recipes-core/jdepend/jdepend_2.9.1.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
recipes-core/jdepend/jdepend_2.9.1.bb +2 -2
@@ -18,7 +18,7 @@ do_compile() { fastjar cf ${JARFILENAME} -C build . } -SRC_URI[md5sum] = "9b91efe1d770e023893f89f4dde8434e" -SRC_URI[sha256sum] = "536b5082d64e4f4dddd514ce30178f36c7a31b34d969275f278f72e522e7f7c9" +SRC_URI[md5sum] = "0cbaf43493cd30838bee261f69e76fe9" +SRC_URI[sha256sum] = "b9f34236aaea5ddc070caa29794d2f5ae79bc12e199bec6ebba6c29093a17a9e" BBCLASSEXTEND = "native"
Signature · 1 line
2.11.0
Quoted 8 lines · Mike Crowe
When Bitbake downloads jdepend-2.9.1.zip itself and I download
https://github.com/clarkware/jdepend/blob/master/dist/jdepend-2.9.1.zip , the calculated hashes don't match the ones included in the recipe.The hashes were last changed in commit
dd5c43fca8289b8795a9214aee616775e1493109on 1st March, but GitHub claims that the file being downloaded was published on 20th January, so I can't explain why they are wrong.
Yeah no one knows how these archives are generated but we know that they can change with out notice. Perhaps we should switch to using git fetcher pointing srcrev to same release SHA
And hope that remains consistent
Quoted 38 lines
Nevertheless, let's update the recipe to use hashes that match the current download.
Signed-off-by Mike Crowe <[email protected]>Cc André Draszik <[email protected]>--- recipes-core/jdepend/jdepend_2.9.1.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)recipes-core/jdepend/ renamed from recipes-core/jdepend/jdepend_2.9.1.bb +0
-0jdepend_2.9.1.bb
index 5f09a8b..a924f1d 100644recipes-core/jdepend/jdepend_2.9.1.bb +0
-2@@ -18,7 +18,7 @@ do_compile() { fastjar cf ${JARFILENAME} -C build . } -SRC_URI[md5sum] = "9b91efe1d770e023893f89f4dde8434e" -SRC_URI[sha256sum] ="
536b5082d64e4f4dddd514ce30178f36c7a31b34d969275f278f72e522e7f7c9"recipes-core/jdepend/jdepend_2.9.1.bb +2
-0+SRC_URI[md5sum] = "0cbaf43493cd30838bee261f69e76fe9" +SRC_URI[sha256sum] ="
b9f34236aaea5ddc070caa29794d2f5ae79bc12e199bec6ebba6c29093a17a9e"BBCLASSEXTEND = "native"
--
2.11.0--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
PATCH v2 1/1 jdepend: Retrieve source from Git rather than tarball
In reply to Mike CroweWhen Bitbake downloads jdepend-2.9.1.zip itself and I download
https://github.com/clarkware/jdepend/blob/master/dist/jdepend-2.9.1.zip , the calculated hashes don't match the ones included in the recipe.
The hashes were last changed in commit dd5c43fca8289b8795a9214aee616775e1493109 on 1st March, but GitHub claims that the file being downloaded was published on 20th January, so I can't explain why they are wrong.
It seems that we can't really rely on these tarballs to remain unchanged, so let's download the Git hash that corresponds to v2.9.1 instead. This should always remain valid.
--- recipes-core/jdepend/jdepend_2.9.1.bb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
I'll let whoever wants to merge this decide whether to take v1 with the updated hashes or v2 using the Git repository.
recipes-core/jdepend/jdepend_2.9.1.bb +3 -4
@@ -6,7 +6,9 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=f5777d32a7709d558c2877d4a6616230" HOMEPAGE = "https://github.com/clarkware/jdepend" -SRC_URI = "https://github.com/clarkware/jdepend/archive/${PV}.zip;downloadfilename=${BP}.zip" +SRC_URI = "git://github.com/clarkware/jdepend" +SRCREV = "57980590313a5dbde236a3eb2c8958e9e53e6a10" +S = "${WORKDIR}/git" inherit java-library
@@ -18,7 +20,4 @@ do_compile() { fastjar cf ${JARFILENAME} -C build . } -SRC_URI[md5sum] = "9b91efe1d770e023893f89f4dde8434e" -SRC_URI[sha256sum] = "536b5082d64e4f4dddd514ce30178f36c7a31b34d969275f278f72e522e7f7c9" - BBCLASSEXTEND = "native"
Signature · 1 line
2.11.0
Re: [meta-java][PATCHv2] jdepend: Retrieve source from Git rather than tarball
Quoted 4 lines · Mike Crowe
When Bitbake downloads jdepend-2.9.1.zip itself and I download
https://github.com/clarkware/jdepend/blob/master/dist/jdepend-2.9.1.zip , the calculated hashes don't match the ones included in the recipe.
Quoted 9 lines
The hashes were last changed in commit
dd5c43fca8289b8795a9214aee616775e1493109on 1st March, but GitHub claims that the file being downloaded was published on 20th January, so I can't explain why they are wrong.It seems that we can't really rely on these tarballs to remain unchanged, so let's download the Git hash that corresponds to v2.9.1 instead. This should always remain valid.
LGTM.
Quoted 37 lines
Cc André Draszik <[email protected]>Cc Khem Raj <[email protected]>Signed-off-by Mike Crowe <[email protected]>--- recipes-core/jdepend/jdepend_2.9.1.bb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)I'll let whoever wants to merge this decide whether to take v1 with the updated hashes or v2 using the Git repository.
recipes-core/jdepend/jdepend_2.9.1.bb +3
-5@@ -6,7 +6,9 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=f5777d32a7709d558c2877d4a6616230" HOMEPAGE = "https://github.com/clarkware/jdepend" -SRC_URI = "https://github.com/clarkware/jdepend/archive/${PV}.zip;downloadfilename=${BP}.zip" +SRC_URI = "git://github.com/clarkware/jdepend" +SRCREV = "57980590313a5dbde236a3eb2c8958e9e53e6a10" +S = "${WORKDIR}/git" inherit java-library@@ -18,7 +20,4 @@ do_compile() { fastjar cf ${JARFILENAME} -C build . } -SRC_URI[md5sum] = "9b91efe1d770e023893f89f4dde8434e" -SRC_URI[sha256sum] = "536b5082d64e4f4dddd514ce30178f36c7a31b34d969275f278f72e522e7f7c9" - BBCLASSEXTEND = "native" --2.11.0
Re: [meta-java][PATCHv2] jdepend: Retrieve source from Git rather than tarball
In reply to Mike Crowehttp://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html,
fwiw
Ross
Quoted 60 lines · Mike Crowe
When Bitbake downloads jdepend-2.9.1.zip itself and I download
https://github.com/clarkware/jdepend/blob/master/dist/jdepend-2.9.1.zip , the calculated hashes don't match the ones included in the recipe.The hashes were last changed in commit
dd5c43fca8289b8795a9214aee616775e1493109on 1st March, but GitHub claims that the file being downloaded was published on 20th January, so I can't explain why they are wrong.It seems that we can't really rely on these tarballs to remain unchanged, so let's download the Git hash that corresponds to v2.9.1 instead. This should always remain valid.
Cc André Draszik <[email protected]>Cc Khem Raj <[email protected]>Signed-off-by Mike Crowe <[email protected]>--- recipes-core/jdepend/jdepend_2.9.1.bb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)I'll let whoever wants to merge this decide whether to take v1 with the updated hashes or v2 using the Git repository.
recipes-core/jdepend/ renamed from recipes-core/jdepend/jdepend_2.9.1.bb +0
-0jdepend_2.9.1.bb
index 5f09a8b..dfbf493 100644recipes-core/jdepend/jdepend_2.9.1.bb +0
-0@@ -6,7 +6,9 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=
f5777d32a7709d558c2877d4a6616230"HOMEPAGE = "https://github.com/clarkware/jdepend"
-SRC_URI = "https://github.com/clarkware/jdepend/archive/${PV}.zip; downloadfilename=${BP}.zip"
recipes-core/jdepend/jdepend_2.9.1.bb +3
-2+SRC_URI = "git://github.com/clarkware/jdepend" +SRCREV = "57980590313a5dbde236a3eb2c8958e9e53e6a10" +S = "${WORKDIR}/git" inherit java-library@@ -18,7 +20,4 @@ do_compile() { fastjar cf ${JARFILENAME} -C build . } -SRC_URI[md5sum] = "9b91efe1d770e023893f89f4dde8434e" -SRC_URI[sha256sum] = "536b5082d64e4f4dddd514ce30178f
36c7a31b34d969275f278f72e522e7f7c9"
-
BBCLASSEXTEND = "native"
--
2.11.0--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
PATCH v3 1/1 jdepend: Retrieve source from Git rather than tarball
When Bitbake downloads jdepend-2.9.1.zip itself and I download
https://github.com/clarkware/jdepend/blob/master/dist/jdepend-2.9.1.zip , the calculated hashes don't match the ones included in the recipe.
The hashes were last changed in commit dd5c43fca8289b8795a9214aee616775e1493109 on 1st March, but GitHub claims that the file being downloaded was published on 20th January, so I can't explain why they are wrong. Ross Burton has provided a plausible reason in
http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html
where he also advocates switching to using Git repositories rather than GitHub-generated tarballs.
It seems that we can't really rely on these tarballs to remain unchanged, so let's download the Git hash that corresponds to v2.9.1 instead. This should always remain valid.
--- recipes-core/jdepend/jdepend_2.9.1.bb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
recipes-core/jdepend/jdepend_2.9.1.bb +3 -4
@@ -6,7 +6,9 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=f5777d32a7709d558c2877d4a6616230" HOMEPAGE = "https://github.com/clarkware/jdepend" -SRC_URI = "https://github.com/clarkware/jdepend/archive/${PV}.zip;downloadfilename=${BP}.zip" +SRC_URI = "git://github.com/clarkware/jdepend" +SRCREV = "57980590313a5dbde236a3eb2c8958e9e53e6a10" +S = "${WORKDIR}/git" inherit java-library
@@ -18,7 +20,4 @@ do_compile() { fastjar cf ${JARFILENAME} -C build . } -SRC_URI[md5sum] = "9b91efe1d770e023893f89f4dde8434e" -SRC_URI[sha256sum] = "536b5082d64e4f4dddd514ce30178f36c7a31b34d969275f278f72e522e7f7c9" - BBCLASSEXTEND = "native"
Signature · 1 line
2.11.0
Re: [meta-java][PATCHv3] jdepend: Retrieve source from Git rather than tarball
The change below doesn't seem to have been merged. Is there anything else that I need to do?
Thanks.
Mike.
Quoted 56 lines · Mike Crowe
When Bitbake downloads jdepend-2.9.1.zip itself and I download
https://github.com/clarkware/jdepend/blob/master/dist/jdepend-2.9.1.zip , the calculated hashes don't match the ones included in the recipe.The hashes were last changed in commit
dd5c43fca8289b8795a9214aee616775e1493109on 1st March, but GitHub claims that the file being downloaded was published on 20th January, so I can't explain why they are wrong. Ross Burton has provided a plausible reason in
http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html
where he also advocates switching to using Git repositories rather than GitHub-generated tarballs.It seems that we can't really rely on these tarballs to remain unchanged, so let's download the Git hash that corresponds to v2.9.1 instead. This should always remain valid.
Cc André Draszik <[email protected]>Cc Khem Raj <[email protected]>Cc Ross Burton <[email protected]>Signed-off-by Mike Crowe <[email protected]>--- recipes-core/jdepend/jdepend_2.9.1.bb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)recipes-core/jdepend/jdepend_2.9.1.bb +3
-4@@ -6,7 +6,9 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=f5777d32a7709d558c2877d4a6616230" HOMEPAGE = "https://github.com/clarkware/jdepend" -SRC_URI = "https://github.com/clarkware/jdepend/archive/${PV}.zip;downloadfilename=${BP}.zip" +SRC_URI = "git://github.com/clarkware/jdepend" +SRCREV = "57980590313a5dbde236a3eb2c8958e9e53e6a10" +S = "${WORKDIR}/git" inherit java-library@@ -18,7 +20,4 @@ do_compile() { fastjar cf ${JARFILENAME} -C build . } -SRC_URI[md5sum] = "9b91efe1d770e023893f89f4dde8434e" -SRC_URI[sha256sum] = "536b5082d64e4f4dddd514ce30178f36c7a31b34d969275f278f72e522e7f7c9" - BBCLASSEXTEND = "native"Signature · 8 lines
2.11.0 -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [meta-java][PATCHv3] jdepend: Retrieve source from Git rather than tarball
In reply to Mike CroweHi,
although the old checksum matches with the current github archive for me please feel free to add:
and
regards;Richard.L
Quoted 48 lines · Mike Crowe
When Bitbake downloads jdepend-2.9.1.zip itself and I download
https://github.com/clarkware/jdepend/blob/master/dist/jdepend-2.9.1.zip , the calculated hashes don't match the ones included in the recipe.The hashes were last changed in commit
dd5c43fca8289b8795a9214aee616775e1493109on 1st March, but GitHub claims that the file being downloaded was published on 20th January, so I can't explain why they are wrong. Ross Burton has provided a plausible reason in
http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html
where he also advocates switching to using Git repositories rather than GitHub-generated tarballs.It seems that we can't really rely on these tarballs to remain unchanged, so let's download the Git hash that corresponds to v2.9.1 instead. This should always remain valid.
Cc André Draszik <[email protected]>Cc Khem Raj <[email protected]>Cc Ross Burton <[email protected]>Signed-off-by Mike Crowe <[email protected]>--- recipes-core/jdepend/jdepend_2.9.1.bb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)recipes-core/jdepend/jdepend_2.9.1.bb +3
-4@@ -6,7 +6,9 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=f5777d32a7709d558c2877d4a6616230" HOMEPAGE = "https://github.com/clarkware/jdepend" -SRC_URI = "https://github.com/clarkware/jdepend/archive/${PV}.zip;downloadfilename=${BP}.zip" +SRC_URI = "git://github.com/clarkware/jdepend" +SRCREV = "57980590313a5dbde236a3eb2c8958e9e53e6a10" +S = "${WORKDIR}/git" inherit java-library@@ -18,7 +20,4 @@ do_compile() { fastjar cf ${JARFILENAME} -C build . } -SRC_URI[md5sum] = "9b91efe1d770e023893f89f4dde8434e" -SRC_URI[sha256sum] = "536b5082d64e4f4dddd514ce30178f36c7a31b34d969275f278f72e522e7f7c9" - BBCLASSEXTEND = "native"
Re: [meta-java][PATCHv3] jdepend: Retrieve source from Git rather than tarball
In reply to Mike CroweHi,
this is a note to let you know that I've just added this patch to the master-next branch of the meta-java repository at
git://git.yoctoproject.org/meta-java
As soon as it has gone through some more testing it will likely be merged to the master branch.
If you have any questions, please let me know.
regards;Richard.L
Quoted 48 lines · Mike Crowe
When Bitbake downloads jdepend-2.9.1.zip itself and I download
https://github.com/clarkware/jdepend/blob/master/dist/jdepend-2.9.1.zip , the calculated hashes don't match the ones included in the recipe.The hashes were last changed in commit
dd5c43fca8289b8795a9214aee616775e1493109on 1st March, but GitHub claims that the file being downloaded was published on 20th January, so I can't explain why they are wrong. Ross Burton has provided a plausible reason in
http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html
where he also advocates switching to using Git repositories rather than GitHub-generated tarballs.It seems that we can't really rely on these tarballs to remain unchanged, so let's download the Git hash that corresponds to v2.9.1 instead. This should always remain valid.
Cc André Draszik <[email protected]>Cc Khem Raj <[email protected]>Cc Ross Burton <[email protected]>Signed-off-by Mike Crowe <[email protected]>--- recipes-core/jdepend/jdepend_2.9.1.bb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)recipes-core/jdepend/jdepend_2.9.1.bb +3
-4@@ -6,7 +6,9 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=f5777d32a7709d558c2877d4a6616230" HOMEPAGE = "https://github.com/clarkware/jdepend" -SRC_URI = "https://github.com/clarkware/jdepend/archive/${PV}.zip;downloadfilename=${BP}.zip" +SRC_URI = "git://github.com/clarkware/jdepend" +SRCREV = "57980590313a5dbde236a3eb2c8958e9e53e6a10" +S = "${WORKDIR}/git" inherit java-library@@ -18,7 +20,4 @@ do_compile() { fastjar cf ${JARFILENAME} -C build . } -SRC_URI[md5sum] = "9b91efe1d770e023893f89f4dde8434e" -SRC_URI[sha256sum] = "536b5082d64e4f4dddd514ce30178f36c7a31b34d969275f278f72e522e7f7c9" - BBCLASSEXTEND = "native"
Re: [meta-java][PATCHv2] jdepend: Retrieve source from Git rather than tarball
In reply to Burton, RossWould it be useful to add a check to patchreview.py (or elsewhere?) to reject patches that contain references to github archive URLs in the recipe?
Cheers,
Andre'
Quoted 71 lines · Ross
http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/
114916.html,
fwiwRoss
Quoted 63 lines · Mike Crowe
When Bitbake downloads jdepend-2.9.1.zip itself and I download
https://github.com/clarkware/jdepend/blob/master/dist/jdepend-2.9.1.zip
,
the calculated hashes don't match the ones included in the recipe.The hashes were last changed in commit
dd5c43fca8289b8795a9214aee616775e1493109on 1st March, but GitHub claims that the file being downloaded was published on 20th January, so I can't explain why they are wrong.It seems that we can't really rely on these tarballs to remain unchanged,
so let's download the Git hash that corresponds to v2.9.1 instead. This should always remain valid.Cc André Draszik <[email protected]>Cc Khem Raj <[email protected]>Signed-off-by Mike Crowe <[email protected]>--- recipes-core/jdepend/jdepend_2.9.1.bb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)I'll let whoever wants to merge this decide whether to take v1 with the updated hashes or v2 using the Git repository.
recipes- renamed from recipes-core/jdepend/jdepend_2.9.1.bb +0
-0core/jdepend/
jdepend_2.9.1.bb
index 5f09a8b..dfbf493 100644recipes-core/jdepend/jdepend_2.9.1.bb +0
-0@@ -6,7 +6,9 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=
f5777d32a7709d558c2877d4a6616230"HOMEPAGE = "https://github.com/clarkware/jdepend"
-SRC_URI = "https://github.com/clarkware/jdepend/archive/${PV}.zip; downloadfilename=${BP}.zip"
recipes-core/jdepend/jdepend_2.9.1.bb +3
-2+SRC_URI = "git://github.com/clarkware/jdepend" +SRCREV = "57980590313a5dbde236a3eb2c8958e9e53e6a10" +S = "${WORKDIR}/git" inherit java-library@@ -18,7 +20,4 @@ do_compile() { fastjar cf ${JARFILENAME} -C build . } -SRC_URI[md5sum] = "9b91efe1d770e023893f89f4dde8434e" -SRC_URI[sha256sum] = "536b5082d64e4f4dddd514ce30178f
36c7a31b34d969275f278f72e522e7f7c9"
-
BBCLASSEXTEND = "native"
--
2.11.0--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [meta-java][PATCHv2] jdepend: Retrieve source from Git rather than tarball
Quoted 2 lines · André Draszik
Would it be useful to add a check to
patchreview.py(or elsewhere?) to reject patches that contain references to github archive URLs in the recipe?
patchtest. Yes, it would!
Ross
Re: [meta-java][PATCHv2] jdepend: Retrieve source from Git rather than tarball
Quoted 5 lines · Ross
Quoted 2 lines · André Draszik
Would it be useful to add a check to
patchreview.py(or elsewhere?) to reject patches that contain references to github archive URLs in the recipe?patchtest. Yes, it would!
Bug files: https://bugzilla.yoctoproject.org/show_bug.cgi?id=12752
If anyone wants to explore patchtest, this is a good starting point.
Ross
While I realise that you sent a v2 and v3, as another interesting point I still (today / right now) get files with the hashes as they are in the recipe before you touched the recipe (when downloading manually using wget).
Cheers,
Andre'
Quoted 39 lines · Mike Crowe
When Bitbake downloads jdepend-2.9.1.zip itself and I download
https://github.com/clarkware/jdepend/blob/master/dist/jdepend-2.9.1.zip , the calculated hashes don't match the ones included in the recipe.The hashes were last changed in commit
dd5c43fca8289b8795a9214aee616775e1493109on 1st March, but GitHub claims that the file being downloaded was published on 20th January, so I can't explain why they are wrong.Nevertheless, let's update the recipe to use hashes that match the current download.
Signed-off-by Mike Crowe <[email protected]>Cc André Draszik <[email protected]>--- recipes-core/jdepend/jdepend_2.9.1.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)recipes- renamed from recipes-core/jdepend/jdepend_2.9.1.bb +0
-0core/jdepend/jdepend_2.9.1.bb
index 5f09a8b..a924f1d 100644recipes-core/jdepend/jdepend_2.9.1.bb +0
-2@@ -18,7 +18,7 @@ do_compile() { fastjar cf ${JARFILENAME} -C build . } -SRC_URI[md5sum] = "9b91efe1d770e023893f89f4dde8434e" -SRC_URI[sha256sum] ="
536b5082d64e4f4dddd514ce30178f36c7a31b34d969275f278f72e522e7f7c9"recipes-core/jdepend/jdepend_2.9.1.bb +2
-0+SRC_URI[md5sum] = "0cbaf43493cd30838bee261f69e76fe9" +SRC_URI[sha256sum] ="
b9f34236aaea5ddc070caa29794d2f5ae79bc12e199bec6ebba6c29093a17a9e"BBCLASSEXTEND = "native"
Signature · 1 line
2.11.0