Skip to contentSkip to conversation

gstreamer1.0: let autotools.bbclass handle --disable-dependency-tracking

PATCH New Andre McCurdy 1 participant 3 messages May 18, 2018

lore
Share & tools
lore

Andre McCurdy

author
#0 lore raw

PATCH 1/3 gstreamer1.0: let autotools.bbclass handle --disable-dependency-tracking

autotools.bbclass adds --disable-dependency-tracking to the configure command line by default, so there's no need for individual recipes to do so.

Signed-off-by Andre McCurdy <[email protected]>
---
 meta/recipes-multimedia/gstreamer/gstreamer1.0_1.14.0.bb | 1 -
 1 file changed, 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0_1.14.0.bb +0 -1
index b4398c8..dec1783 100644
@@ -38,7 +38,6 @@ PACKAGECONFIG[unwind] = "--with-unwind,--without-unwind,libunwind"
 PACKAGECONFIG[dw] = "--with-dw,--without-dw,elfutils"
 
 EXTRA_OECONF = " \
-    --disable-dependency-tracking \
     --disable-examples \
 "
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/3 pinentry: let autotools.bbclass handle --disable-dependency-tracking

autotools.bbclass adds --disable-dependency-tracking to the configure command line by default, so there's no need for individual recipes to do so.

Also make some minor recipe formatting cleanups.

Signed-off-by Andre McCurdy <[email protected]>
---
 meta/recipes-support/pinentry/pinentry_1.1.0.bb | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
meta/recipes-support/pinentry/pinentry_1.1.0.bb +6 -5
index 1eaa261..4116efc 100644
@@ -8,8 +8,6 @@ HOMEPAGE = "http://www.gnupg.org/related_software/pinentry/index.en.html"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=cbbd794e2a0a289b9dfcc9f513d1996e"
 
-inherit autotools pkgconfig
-
 DEPENDS = "gettext-native libassuan libgpg-error"
 
 UPSTREAM_CHECK_URI = "https://gnupg.org/download/index.html"

@@ -21,9 +19,7 @@ SRC_URI = "${GNUPG_MIRROR}/${BPN}/${BPN}-${PV}.tar.bz2 \
 SRC_URI[md5sum] = "3829315cb0a1e9cedc05ffe6def7a2c6"
 SRC_URI[sha256sum] = "68076686fa724a290ea49cdf0d1c0c1500907d1b759a3bcbfbec0293e8f56570"
 
-EXTRA_OECONF = "--disable-rpath --disable-dependency-tracking \
-                --disable-pinentry-qt5  \
-"
+inherit autotools pkgconfig
 
 PACKAGECONFIG ??= "ncurses libcap"
 

@@ -35,4 +31,9 @@ PACKAGECONFIG[gtk2] = "--enable-pinentry-gtk2, --disable-pinentry-gtk2, gtk+ gli
 #To use libsecret, add meta-gnome
 PACKAGECONFIG[secret] = "--enable-libsecret, --disable-libsecret, libsecret"
 
+EXTRA_OECONF = " \
+    --disable-rpath \
+    --disable-pinentry-qt5 \
+"
+
 BBCLASSEXTEND = "native"
Signature · 1 line
1.9.1
author
#2 lore raw

PATCH 3/3 externalsrc.bbclass: don't configure with --disable-dependency-tracking

In reply to Andre McCurdy

One of the uses of externalsrc is to enable iterative editing and rebuilding of source files during development. In such situations, disabling Automake dependency tracking can lead to sources not being rebuilt even though files they depend on have been modified.

Signed-off-by Andre McCurdy <[email protected]>
---
 meta/classes/externalsrc.bbclass | 3 +++
 1 file changed, 3 insertions(+)
meta/classes/externalsrc.bbclass +3 -0
index c9f5cf7..ad87d85 100644
@@ -77,6 +77,9 @@ python () {
             # Dummy value because the default function can't be called with blank SRC_URI
             d.setVar('SRCPV', '999')
 
+        if d.getVar('CONFIGUREOPT_DEPTRACK') == '--disable-dependency-tracking':
+            d.setVar('CONFIGUREOPT_DEPTRACK', '')
+
         tasks = filter(lambda k: d.getVarFlag(k, "task"), d.keys())
 
         for task in tasks:
Signature · 1 line
1.9.1