nfp: restore the unlink operation
PATCH 1/1 nfp: restore the unlink operation
For the stable versions of DPDK, the NFP driver's NSP user space driver was modified to account for non-root usage. When that happened, commit 515933ad8385 ("nfp: allow for non-root user") inadvertently removed the unlink() call.
--- drivers/net/nfp/nfp_nfpu.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/nfp/nfp_nfpu.c +1 -0
@@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc)close (desc->lock);nspu_get_lockfile_path (lockname,sizeof (lockname), desc); +unlink (lockname);return 0 ; }
Signature · 1 line
2.14.3
Quoted 4 lines · Aaron Conole
For the stable versions of DPDK, the NFP driver's NSP user space driver was modified to account for non-root usage. When that happened, commit
515933ad8385("nfp: allow for non-root user") inadvertently removed theunlink()call.
Alejandro Lucero
Acked-byQuoted 11 lines · Eelco Chaudron
Quoted 5 lines · Aaron Conole
For the stable versions of DPDK, the NFP driver's NSP user space driver was modified to account for non-root usage. When that happened, commit
515933ad8385("nfp: allow for non-root user") inadvertently removed theunlink()call.Acked-by Eelco Chaudron <[email protected]>
Quoted 4 lines · Aaron Conole
For the stable versions of DPDK, the NFP driver's NSP user space driver was modified to account for non-root usage. When that happened, commit
515933ad8385("nfp: allow for non-root user") inadvertently removed theunlink()call.
This patch is for stable tree.
Which stable branches are effected? Only 18.02?
And a generic stable tree question, is there a easy way to find out which stable versions has a fix? For this example which versions get "nfp: allow for non-root user" fix?
Quoted 23 lines
Fixes 515933ad8385 ("nfp: allow for non-root user")Cc Alejandro Lucero <[email protected]>Cc Luca Boccassi <[email protected]>Cc Eelco Chaudron <[email protected]>Cc Yuanhan Liu <[email protected]>Signed-off-by Aaron Conole <[email protected]>--- drivers/net/nfp/nfp_nfpu.c | 1 + 1 file changed, 1 insertion(+)drivers/net/nfp/nfp_nfpu.c +1
-0@@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc)close (desc->lock);nspu_get_lockfile_path (lockname,sizeof (lockname), desc); +unlink (lockname);return 0 ; }
Quoted 9 lines · Ferruh Yigit
Quoted 4 lines · Aaron Conole
For the stable versions of DPDK, the NFP driver's NSP user space driver was modified to account for non-root usage. When that happened, commit
515933ad8385("nfp: allow for non-root user") inadvertently removed theunlink()call.This patch is for stable tree.
Which stable branches are effected? Only 18.02?
At this time, just 18.02
Quoted 4 lines
And a generic stable tree question, is there a easy way to find out which stable versions has a fix? For this example which versions get "nfp: allow for non-root user" fix?
I'm not sure if there is something in
http://dpdk.org/browse/tools/stable-scripts/ that might automatically find the dependency?
Quoted 23 lines
Quoted 23 lines
Fixes 515933ad8385 ("nfp: allow for non-root user")Cc Alejandro Lucero <[email protected]>Cc Luca Boccassi <[email protected]>Cc Eelco Chaudron <[email protected]>Cc Yuanhan Liu <[email protected]>Signed-off-by Aaron Conole <[email protected]>--- drivers/net/nfp/nfp_nfpu.c | 1 + 1 file changed, 1 insertion(+)drivers/net/nfp/nfp_nfpu.c +1
-0@@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc)close (desc->lock);nspu_get_lockfile_path (lockname,sizeof (lockname), desc); +unlink (lockname);return 0 ; }
Quoted 24 lines · Aaron Conole
For the stable versions of DPDK, the NFP driver's NSP user space driver was modified to account for non-root usage. When that happened, commit
515933ad8385("nfp: allow for non-root user") inadvertently removed theunlink()call.Fixes 515933ad8385 ("nfp: allow for non-root user")Cc Alejandro Lucero <[email protected]>Cc Luca Boccassi <[email protected]>Cc Eelco Chaudron <[email protected]>Cc Yuanhan Liu <[email protected]>Signed-off-by Aaron Conole <[email protected]>---
drivers/net/nfp/nfp_nfpu.c | 1 +1 file changed, 1 insertion(+)drivers/net/nfp/nfp_nfpu.c +0
-0@@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc) close(desc->lock);
nspu_get_lockfile_path(lockname, sizeof(lockname), desc);drivers/net/nfp/nfp_nfpu.c +1
-0+unlink (lockname);
Quoted 2 lines
return 0;
}
Applied and pushed to stable/18.02
Next time, please send patches that are only for stable to stable@dpdk. org and do not include [email protected]
Also use --subject-prefix='PATCH <branch>' so that we can understand for which branches a patch is
Signature · 2 lines
Kind regards, Luca Boccassi
Quoted 16 lines · Luca Boccassi
Quoted 15 lines · Aaron Conole
For the stable versions of DPDK, the NFP driver's NSP user space driver was modified to account for non-root usage. When that happened, commit
515933ad8385("nfp: allow for non-root user") inadvertently removed theunlink()call.Fixes 515933ad8385 ("nfp: allow for non-root user")Cc Alejandro Lucero <[email protected]>Cc Luca Boccassi <[email protected]>Cc Eelco Chaudron <[email protected]>Cc Yuanhan Liu <[email protected]>Signed-off-by Aaron Conole <[email protected]>---
drivers/net/nfp/nfp_nfpu.c | 1 +1 file changed, 1 insertion(+)
Quoted 13 lines
Quoted 11 lines
drivers/net/nfp/nfp_nfpu.c +0
-0@@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc) close(desc->lock);
nspu_get_lockfile_path(lockname, sizeof(lockname), desc);drivers/net/nfp/nfp_nfpu.c +1
-0+unlink (lockname);return 0;
}Applied and pushed to stable/18.02
Thanks, Luca!
Quoted 2 lines
Next time, please send patches that are only for stable to stable@dpdk. org and do not include [email protected]
Will do.
Quoted 2 lines
Also use --subject-prefix='PATCH <branch>' so that we can understand for which branches a patch is
Thanks. I'll keep this in mind.