patch "usb: gadget: udc: renesas_usb3: should call pm_runtime_enable()" added to usb-testing
Subsystems (2)
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: renesas_usb3: should call pm_runtime_enable()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will be merged to the usb-next branch sometime soon, after it passes testing, and the merge window is open.
If you have any questions about this process, please let me know.
Quoted 1 line
From
d998844016b24a8d71b9aa5eae7e51d70f2de438Mon Sep 17 00:00:00 2001
From: Yoshihiro Shimoda <[email protected]>
Date: Tue, 10 Apr 2018 14:38:51 +0900
Subject: usb: gadget: udc: renesas_usb3: should call pm_runtime_enable()
before add udc
This patch fixes an issue that this driver causes panic if a gadget driver is already loaded because usb_add_gadget_udc() might call renesas_usb3_start() via .udc_start, and then pm_runtime_get_sync() in renesas_usb3_start() doesn't work correctly.
Note that the usb3_to_dev() macro should not be called at this timing because the macro uses the gadget structure.
--- drivers/usb/gadget/udc/renesas_usb3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/udc/renesas_usb3.c +1 -1
@@ -2634,6 +2634,7 @@ static int renesas_usb3_probe(struct platform_device *pdev)if (ret <0 ) goto err_alloc_prd; +pm_runtime_enable (&pdev->dev); ret =usb_add_gadget_udc (&pdev->dev, &usb3->gadget);if (ret <0 ) goto err_add_udc;
@@ -2655,7 +2656,6 @@ static int renesas_usb3_probe(struct platform_device *pdev)renesas_usb3_debugfs_init (usb3, &pdev->dev);dev_info (&pdev->dev,"probed%s\n" , usb3->phy ?" with phy" :"" ); -pm_runtime_enable (usb3_to_dev (usb3));return 0 ;
Signature · 1 line
2.17.0