patch "usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add" added to usb-testing
Subsystems (2)
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will be merged to the usb-next branch sometime soon, after it passes testing, and the merge window is open.
If you have any questions about this process, please let me know.
Quoted 1 line
From
003bc1dee216b1fb8e02040a95672bea0f1fe797Mon Sep 17 00:00:00 2001
From: Yoshihiro Shimoda <[email protected]>
Date: Tue, 10 Apr 2018 14:38:52 +0900
Subject: usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add
udc
This patch fixes an issue that this driver cannot call phy_init() if a gadget driver is alreadly loaded because usb_add_gadget_udc() might call renesas_usb3_start() via .udc_start.
This patch also revises the typo (s/an optional/optional/).
--- drivers/usb/gadget/udc/renesas_usb3.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/usb/gadget/udc/renesas_usb3.c +8 -8
@@ -2634,6 +2634,14 @@ static int renesas_usb3_probe(struct platform_device *pdev)if (ret <0 ) goto err_alloc_prd; +/* +* This is optional. So, if this driver cannot get a phy, +* this driver will not handle a phy anymore. +*/ + usb3->phy =devm_phy_get (&pdev->dev,"usb" ); +if (IS_ERR (usb3->phy)) + usb3->phy =NULL ; +pm_runtime_enable (&pdev->dev); ret =usb_add_gadget_udc (&pdev->dev, &usb3->gadget);if (ret <0 )
@@ -2643,14 +2651,6 @@ static int renesas_usb3_probe(struct platform_device *pdev)if (ret <0 ) goto err_dev_create; -/* -* This is an optional. So, if this driver cannot get a phy, -* this driver will not handle a phy anymore. -*/ - usb3->phy =devm_phy_get (&pdev->dev,"usb" ); -if (IS_ERR (usb3->phy)) - usb3->phy =NULL ; - usb3->workaround_for_vbus = priv->workaround_for_vbus;renesas_usb3_debugfs_init (usb3, &pdev->dev);
Signature · 1 line
2.17.0