Skip to contentSkip to conversation

yocto-autobuilder2: add missing __init__.py to top level

PATCH In review Armin Kuster 2 participants 4 messages Jun 4, 2018 – Jun 11, 2018

lore
Share & tools
lore

Armin Kuster

author
#0 lore raw

PATCH 1/2 yocto-autobuilder2: add missing __init__.py to top level

This fixes the import of modules when starting buildbot
as master.cfg has:
from yoctoabb import builders, config, schedulers, workers, services, www

Signed-off-by Armin Kuster <[email protected]>
---
 __init__.py | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 __init__.py
__init__.py new file +0 -0
new file mode 100644
index 0000000..e69de29
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 2/2 README.md: cleanup installation setup

yoctoabb is currently hardcode so clone repo there.

Signed-off-by Armin Kuster <[email protected]>
---
 README.md | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
README.md +4 -1
index 4926969..e0652c7 100644
@@ -75,7 +75,7 @@ Refer to the buildbot documentation for information on how to correctly configur
 ```
 $ buildbot create-master <yocto-controller>
 $ cd <yocto-controller>
-$ git clone <yoctoabb repo>
+$ git clone https://git.yoctoproject.org/git/yocto-autobuilder2 yoctoabb
 $ cd ..
 $ ln -rs <yocto-controller>/yoctoabb/master.cfg <yocto-controller>/master.cfg
 $ $EDITOR <yocto-controller>/yoctoabb/master.cfg

@@ -87,6 +87,9 @@ $ $EDITOR <yocto-controller>/yoctoabb/www.py
 $ $EDITOR <yocto-controller>/yoctoabb/config.py
 <Modify configuration options such as worker configuration, etc.>
 $ buildbot start <yocto-controller>
+$ cd ..
+## should be above <yocto-controller> location
+git clone https://git.yoctoproject.org/git/yocto-autobuilder-helper
 ```
 
 #### on the worker
Signature · 1 line
2.7.4
#2 lore raw
In reply to Armin Kuster

__init__.py

Quoted 14 lines · Armin Kuster

This fixes the import of modules when starting buildbot
as master.cfg has:
from yoctoabb import builders, config, schedulers, workers, services, www

Signed-off-by Armin Kuster <[email protected]>
---
 __init__.py | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 __init__.py
__init__.py new file +0 -0
new file mode 100644
index 0000000..e69de29

I've merged the other patch (2/2). I've now realised this issue is due to the use of python2 when we've been testing with python3. Rather than trying to support both, I'd prefer to simply suggest people use python3 at this point.

Fancy sending a patch to document this? :)

It'd be useful to me to be cc'd on patches for the autobuilder stuff too if that isn't too much trouble as I sometimes don't get though all the mailing lists as often as I'd like.

Cheers,

Richard

author
#3 lore raw
Quoted 20 lines · Richard Purdie

__init__.py

Quoted 14 lines · Armin Kuster

This fixes the import of modules when starting buildbot
as master.cfg has:
from yoctoabb import builders, config, schedulers, workers, services, www

Signed-off-by Armin Kuster <[email protected]>
---
 __init__.py | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 __init__.py
__init__.py new file +0 -0
new file mode 100644
index 0000000..e69de29

I've merged the other patch (2/2). I've now realised this issue is due to the use of python2 when we've been testing with python3. Rather than trying to support both, I'd prefer to simply suggest people use python3 at this point.

Quoted 1 line

Fancy sending a patch to document this? :)

Sure no problem.

- armin

Quoted 12 lines

It'd be useful to me to be cc'd on patches for the autobuilder stuff too if that isn't too much trouble as I sometimes don't get though all the mailing lists as often as I'd like.

Cheers,

Richard