Skip to contentSkip to conversation

regulator: tps65911: fix regulator-compatible documentation

PATCH In review Christoph Fritz 3 participants 7 messages Jun 4, 2018 – Jul 4, 2018

Subsystems (2)
Device tree bindings Multifunction devices (MFD)
lore
Share & tools
lore

Christoph Fritz

author
#0 lore raw

PATCH 1/1 regulator: tps65911: fix regulator-compatible documentation

Signed-off-by Christoph Fritz <[email protected]>
---
 Documentation/devicetree/bindings/mfd/tps65910.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/tps65910.txt +1 -1
index 8af1202..4f62143 100644
@@ -22,7 +22,7 @@ Required properties:
   The valid regulator-compatible values are:
   tps65910: vrtc, vio, vdd1, vdd2, vdd3, vdig1, vdig2, vpll, vdac, vaux1,
             vaux2, vaux33, vmmc, vbb
-  tps65911: vrtc, vio, vdd1, vdd3, vddctrl, ldo1, ldo2, ldo3, ldo4, ldo5,
+  tps65911: vrtc, vio, vdd1, vdd2, vddctrl, ldo1, ldo2, ldo3, ldo4, ldo5,
             ldo6, ldo7, ldo8
 
 - xxx-supply: Input voltage supply regulator.
Signature · 1 line
2.1.4
#1 lore raw
Quoted 11 lines · Christoph Fritz
Signed-off-by Christoph Fritz <[email protected]>
---
 Documentation/devicetree/bindings/mfd/tps65910.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/tps65910.txt +0 -0
index 8af1202..4f62143 100644

Documentation/devicetree/bindings/mfd/tps65910.txt Required properties: · line 28

Quoted 8 lines
Documentation/devicetree/bindings/mfd/tps65910.txt +1 -1
@@ -22,7 +22,7 @@ Required properties:
   The valid regulator-compatible values are:
   tps65910: vrtc, vio, vdd1, vdd2, vdd3, vdig1, vdig2, vpll, vdac, vaux1,
             vaux2, vaux33, vmmc, vbb
-  tps65911: vrtc, vio, vdd1, vdd3, vddctrl, ldo1, ldo2, ldo3, ldo4, ldo5,
+  tps65911: vrtc, vio, vdd1, vdd2, vddctrl, ldo1, ldo2, ldo3, ldo4, ldo5,
             ldo6, ldo7, ldo8
 
 - xxx-supply: Input voltage supply regulator.

<playing_dumb>

I have no idea what I'm meant to be looking for.

Please add a suitable commit log.

</playing_dumb>

Also, this is not a "regulator" patch, as your $SUBJECT suggests. Please change the pre-fix to "dt-bindings: mfd: "

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#2 lore raw

PATCH v2 1/1 dt-bindings: mfd: fix documentation of tps65911

This patch fixes documentation of tps65911 because its list of compatible regulators contains wrongly vdd3 instead of vdd2.

Signed-off-by Christoph Fritz <[email protected]>
---
 Documentation/devicetree/bindings/mfd/tps65910.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/tps65910.txt +1 -1
index 8af1202..4f62143 100644
@@ -22,7 +22,7 @@ Required properties:
   The valid regulator-compatible values are:
   tps65910: vrtc, vio, vdd1, vdd2, vdd3, vdig1, vdig2, vpll, vdac, vaux1,
             vaux2, vaux33, vmmc, vbb
-  tps65911: vrtc, vio, vdd1, vdd3, vddctrl, ldo1, ldo2, ldo3, ldo4, ldo5,
+  tps65911: vrtc, vio, vdd1, vdd2, vddctrl, ldo1, ldo2, ldo3, ldo4, ldo5,
             ldo6, ldo7, ldo8
 
 - xxx-supply: Input voltage supply regulator.
Signature · 1 line
2.1.4
maintainer Acked-by on v2 1/1
#3 lore raw

Re: [PATCH v2] dt-bindings: mfd: fix documentation of tps65911

Quoted 7 lines · Christoph Fritz

This patch fixes documentation of tps65911 because its list of compatible regulators contains wrongly vdd3 instead of vdd2.

Signed-off-by Christoph Fritz <[email protected]>
---
 Documentation/devicetree/bindings/mfd/tps65910.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by Rob Herring <[email protected]>
author
#4 lore raw

Re: [PATCH v2] dt-bindings: mfd: fix documentation of tps65911

Hey Lee

Quoted 10 lines · Rob Herring
Quoted 7 lines · Christoph Fritz

This patch fixes documentation of tps65911 because its list of compatible regulators contains wrongly vdd3 instead of vdd2.

Signed-off-by Christoph Fritz <[email protected]>
---
 Documentation/devicetree/bindings/mfd/tps65910.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by Rob Herring <[email protected]>

any chance to get this patch queued soon?

Thanks
-- Christoph

#5 lore raw

Re: [PATCH v2] dt-bindings: mfd: fix documentation of tps65911

Quoted 5 lines · Christoph Fritz
Quoted 4 lines · Rob Herring
Quoted 3 lines · Christoph Fritz

This patch fixes documentation of tps65911 because its list of compatible regulators contains wrongly vdd3 instead of vdd2.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Signed-off-by Christoph Fritz <[email protected]>
---
 Documentation/devicetree/bindings/mfd/tps65910.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by Rob Herring <[email protected]>

any chance to get this patch queued soon?

It's in the queue to be reviewed. I have just returned from paternity leave and have 290 emails to get through. Please bear with me.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Applied
#6 lore raw

Re: [PATCH v2] dt-bindings: mfd: fix documentation of tps65911

In reply to Christoph Fritz
Quoted 7 lines · Christoph Fritz

This patch fixes documentation of tps65911 because its list of compatible regulators contains wrongly vdd3 instead of vdd2.

Signed-off-by Christoph Fritz <[email protected]>
---
 Documentation/devicetree/bindings/mfd/tps65910.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog