clean up DPU custom properties
Subsystems (5)
v2 cover clean up DPU custom properties
Submitting a series of patches to further clean up DPU driver by stripping down a list of custom properties supporting proprietary features. It removes the property installers/handlers and cleans up relevant files of of some of the advanced features. This series is based on the patch[1] available on the drm-next tip.
[1]https://patchwork.kernel.org/patch/10202847/
Thanks.
changes in v2:
- remove stale code in blend config
- move unrelated code while updating zpos property
- Makefile changes
Jeykumar Sankaran (7):
drm/msm: remove connector custom properties drm/msm/dpu: clean up dpu plane custom properties drm/msm: enable zpos normalization drm/msm/dpu: switch to drm zpos property drm/msm/dpu: clean up dpu crtc custom properties drm/msm: remove msm_prop files
drm/msm: remove dpu specific uapi header
drivers/gpu/drm/msm/Makefile | 10 - drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h | 99 -- .../gpu/drm/msm/disp/dpu1/dpu_color_processing.c | 1521 -------------------- .../gpu/drm/msm/disp/dpu1/dpu_color_processing.h | 120 -- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 30 - drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 1328 +---------------- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 45 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 14 - drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 2 - .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c | 1443 ------------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 72 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 89 -- .../msm/disp/dpu1/dpu_hw_color_proc_common_v4.h | 69 - .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c | 242 ---- .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h | 40 - .../drm/msm/disp/dpu1/dpu_hw_color_processing.h | 20 - .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.c | 565 -------- .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.h | 92 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 44 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 15 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c | 149 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h | 111 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 209 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h | 220 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 67 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 14 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 58 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 68 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 6 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 757 ---------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h | 27 - .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c | 943 ------------ .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h | 75 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 219 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 73 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 156 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 - drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 1404 ++---------------- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 43 - drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c | 139 -- drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h | 310 ---- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 149 +- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 2 - drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c | 2 - drivers/gpu/drm/msm/msm_drv.c | 3 + drivers/gpu/drm/msm/msm_drv.h | 86 +- drivers/gpu/drm/msm/msm_prop.c | 688 --------- drivers/gpu/drm/msm/msm_prop.h | 438 ------ include/uapi/drm/dpu_drm.h | 407 ------ include/uapi/drm/msm_drm.h | 1 - include/uapi/drm/msm_drm_pp.h | 345 ----- 53 files changed, 297 insertions(+), 12737 deletions(-) delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_common_v4.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h delete mode 100644 drivers/gpu/drm/msm/msm_prop.c delete mode 100644 drivers/gpu/drm/msm/msm_prop.h delete mode 100644 include/uapi/drm/dpu_drm.h delete mode 100644 include/uapi/drm/msm_drm_pp.h
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
PATCH v2 1/7 drm/msm: remove connector custom properties
Cleanup residual connector property enumerations.
changs in v2:
- none
--- drivers/gpu/drm/msm/msm_drv.h | 27 --------------------------- 1 file changed, 27 deletions(-)
drivers/gpu/drm/msm/msm_drv.h +0 -27
@@ -140,32 +140,6 @@ enum msm_mdp_crtc_property {CRTC_PROP_COUNT }; -enum msm_mdp_conn_property { -/* blob properties, always put these first */ -CONNECTOR_PROP_DPU_INFO , -CONNECTOR_PROP_HDR_INFO , -CONNECTOR_PROP_PP_DITHER , - -/* # of blob properties */ -CONNECTOR_PROP_BLOBCOUNT , - -/* range properties */ -CONNECTOR_PROP_OUT_FB =CONNECTOR_PROP_BLOBCOUNT , -CONNECTOR_PROP_DST_X , -CONNECTOR_PROP_DST_Y , -CONNECTOR_PROP_DST_W , -CONNECTOR_PROP_DST_H , -CONNECTOR_PROP_BL_SCALE , -CONNECTOR_PROP_AD_BL_SCALE , - -/* enum/bitmask properties */ -CONNECTOR_PROP_AUTOREFRESH , -CONNECTOR_PROP_LP , - -/* total # of properties */ -CONNECTOR_PROP_COUNT -}; -struct msm_vblank_ctrl {struct kthread_work work;struct list_head event_list;
@@ -434,7 +408,6 @@ struct msm_drm_private {/* Properties */ struct drm_property *plane_property[PLANE_PROP_COUNT ];struct drm_property *crtc_property[CRTC_PROP_COUNT ]; -struct drm_property *conn_property[CONNECTOR_PROP_COUNT ];/* Color processing properties for the crtc */ struct drm_property **cp_property;
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
A message that is not in the archive (sent off-list or not yet received): 1528256738-30652-1-git-send-email-jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
PATCH v2 2/7 drm/msm/dpu: clean up dpu plane custom properties
This change removes all the dpu plane custom properties and its handlers.
changs in v2:
- remove stale code in blend config(Sean Paul)
- Makefile changes to remove warning flags(Sean Paul)
--- drivers/gpu/drm/msm/Makefile | 8 - drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h | 99 -- .../gpu/drm/msm/disp/dpu1/dpu_color_processing.c | 1521 -------------------- .../gpu/drm/msm/disp/dpu1/dpu_color_processing.h | 120 -- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 205 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 3 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 - .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c | 1443 ------------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 72 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 89 -- .../msm/disp/dpu1/dpu_hw_color_proc_common_v4.h | 69 - .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c | 242 ---- .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h | 40 - .../drm/msm/disp/dpu1/dpu_hw_color_processing.h | 20 - .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.c | 565 -------- .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.h | 92 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 44 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 15 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 209 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h | 220 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 44 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 68 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 6 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 757 ---------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h | 27 - .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c | 943 ------------ .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h | 75 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 219 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 73 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 156 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 - drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 1269 +--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 31 - drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c | 139 -- drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h | 310 ---- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 102 +- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 2 - drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c | 2 - drivers/gpu/drm/msm/msm_drv.h | 28 - include/uapi/drm/dpu_drm.h | 187 --- include/uapi/drm/msm_drm.h | 1 - 44 files changed, 282 insertions(+), 9241 deletions(-) delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_common_v4.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h
drivers/gpu/drm/msm/Makefile +0 -8
@@ -46,7 +46,6 @@ msm-y := \ disp/mdp5/mdp5_mixer.o \ disp/mdp5/mdp5_plane.o \ disp/mdp5/mdp5_smp.o \ - disp/dpu1/dpu_color_processing.o \ disp/dpu1/dpu_core_irq.o \ disp/dpu1/dpu_core_perf.o \ disp/dpu1/dpu_crtc.o \
@@ -54,21 +53,15 @@ msm-y := \ disp/dpu1/dpu_encoder_phys_cmd.o \ disp/dpu1/dpu_encoder_phys_vid.o \ disp/dpu1/dpu_formats.o \ - disp/dpu1/dpu_hw_ad4.o \ disp/dpu1/dpu_hw_blk.o \ disp/dpu1/dpu_hw_catalog.o \ disp/dpu1/dpu_hw_cdm.o \ - disp/dpu1/dpu_hw_color_proc_v4.o \ - disp/dpu1/dpu_hw_color_processing_v1_7.o \ disp/dpu1/dpu_hw_ctl.o \ disp/dpu1/dpu_hw_ds.o \ - disp/dpu1/dpu_hw_dspp.o \ disp/dpu1/dpu_hw_interrupts.o \ disp/dpu1/dpu_hw_intf.o \ disp/dpu1/dpu_hw_lm.o \ disp/dpu1/dpu_hw_pingpong.o \ - disp/dpu1/dpu_hw_reg_dma_v1.o \ - disp/dpu1/dpu_hw_reg_dma_v1_color_proc.o \ disp/dpu1/dpu_hw_sspp.o \ disp/dpu1/dpu_hw_top.o \ disp/dpu1/dpu_hw_util.o \
@@ -78,7 +71,6 @@ msm-y := \ disp/dpu1/dpu_kms.o \ disp/dpu1/dpu_kms_utils.o \ disp/dpu1/dpu_plane.o \ - disp/dpu1/dpu_reg_dma.o \ disp/dpu1/dpu_rm.o \ disp/dpu1/dpu_vbif.o \ dpu_dbg.o \
drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h deleted +0 -99
99 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.c deleted +0 -1521
1,521 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.h deleted +0 -120
120 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +17 -188
336 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h +1 -2
@@ -20,6 +20,7 @@#define _DPU_CRTC_H_#include <linux/kthread.h> +#include <uapi/drm/dpu_drm.h> #include <drm/drm_crtc.h> #include "msm_prop.h" #include "dpu_kms.h"
@@ -86,7 +87,6 @@ struct dpu_crtc_smmu_state_data {* struct dpu_crtc_mixer: stores the map for each virtual pipeline in the CRTC * @hw_lm: LM HW Driver context * @hw_ctl: CTL Path HW driver context -* @hw_dspp: DSPP HW driver context * @hw_ds: DS HW driver context * @encoder: Encoder attached to this lm & ctl * @mixer_op_mode: mixer blending operation mode
@@ -95,7 +95,6 @@ struct dpu_crtc_smmu_state_data {struct dpu_crtc_mixer {struct dpu_hw_mixer *hw_lm;struct dpu_hw_ctl *hw_ctl; -struct dpu_hw_dspp *hw_dspp;struct dpu_hw_ds *hw_ds;struct drm_encoder *encoder;u32 mixer_op_mode;
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +0 -2
@@ -1748,8 +1748,6 @@ static void _dpu_encoder_kickoff_phys(struct dpu_encoder_virt *dpu_enc)if (phys->split_role !=ENC_ROLE_SLAVE )set_bit (i, dpu_enc->frame_busy_mask); -if (phys->hw_ctl->ops.reg_dma_flush) - phys->hw_ctl->ops.reg_dma_flush (phys->hw_ctl);if (!phys->ops.needs_single_flush || !phys->ops.needs_single_flush (phys))_dpu_encoder_trigger_flush (&dpu_enc->base, phys,0x0 );
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c +0 -1
@@ -13,7 +13,6 @@#define pr_fmt (fmt) "[drm:%s:%d] " fmt, __func__, __LINE__#include <linux/debugfs.h> -#include <uapi/drm/dpu_drm.h> #include "dpu_encoder_phys.h" #include "dpu_formats.h"
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c deleted +0 -1443
853 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +9 -63
72 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h +0 -89
89 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_common_v4.h deleted +0 -69
69 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c deleted +0 -242
242 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h deleted +0 -40
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing.h deleted +0 -20
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.c deleted +0 -565
565 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.h deleted +0 -92
92 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c +0 -44
44 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h +0 -15
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c deleted +0 -209
209 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h deleted +0 -220
220 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c +1 -0
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h +10 -34
44 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c +0 -68
68 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h +0 -6
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c deleted +0 -757
757 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h deleted +0 -27
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c deleted +0 -943
943 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h deleted +0 -75
75 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +0 -219
219 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h +0 -73
73 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c +0 -1
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h +156 -0
156 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +0 -3
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +75 -1194
1,269 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h +0 -31
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c deleted +0 -139
139 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h deleted +0 -310
310 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c +13 -89
102 lines not on this page · raw message
include/uapi/drm/dpu_drm.h +0 -187
187 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
Part of the diff is not shown here. View the raw message.
A message that is not in the archive (sent off-list or not yet received): 1528256738-30652-3-git-send-email-jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Re: [DPU PATCH v2 2/7] drm/msm/dpu: clean up dpu plane custom properties
Quoted 64 lines · Jeykumar Sankaran
This change removes all the dpu plane custom properties and its handlers.
changs in v2:
- remove stale code in blend config(Sean Paul)
-Makefilechanges to remove warning flags(Sean Paul)Signed-off-by Jeykumar Sankaran <[email protected]>--- drivers/gpu/drm/msm/Makefile | 8 - drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h | 99 -- .../gpu/drm/msm/disp/dpu1/dpu_color_processing.c | 1521 -------------------- .../gpu/drm/msm/disp/dpu1/dpu_color_processing.h | 120 -- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 205 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 3 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 - .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c | 1443 ------------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 72 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 89 -- .../msm/disp/dpu1/dpu_hw_color_proc_common_v4.h | 69 - .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c | 242 ---- .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h | 40 - .../drm/msm/disp/dpu1/dpu_hw_color_processing.h | 20 - .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.c | 565 -------- .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.h | 92 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 44 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 15 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 209 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h | 220 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 44 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 68 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 6 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 757 ---------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h | 27 - .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c | 943 ------------ .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h | 75 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 219 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 73 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 156 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 - drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 1269 +--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 31 - drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c | 139 -- drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h | 310 ---- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 102 +- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 2 - drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c | 2 - drivers/gpu/drm/msm/msm_drv.h | 28 - include/uapi/drm/dpu_drm.h | 187 --- include/uapi/drm/msm_drm.h | 1 - 44 files changed, 282 insertions(+), 9241 deletions(-) delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_common_v4.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.h
Quoted 9 lines
delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h
/snip
drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c
Quoted 1 line
drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c +0
-0
/snip
Quoted 25 lines
drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c +0
-25- -int dpu_reg_dma_init (void __iomem *addr,struct dpu_mdss_cfg *m, -struct drm_device *dev) -{ -int rc =0 ; - -if (!addr || !m || !dev) { -DRM_DEBUG ("invalid addr %pK catalog %pK dev %pK\n" , addr, m, - dev); -return 0 ; - } - - reg_dma.drm_dev = dev; - reg_dma.caps = &m->dma_cfg; - reg_dma.addr = addr; - -if (!m->reg_dma_count) -return 0 ; - -switch (reg_dma.caps->version) { -case 1 : - rc =init_v1 (®_dma); -if (rc) -DRM_DEBUG ("init v1 dma ops failed\n" ); -else
drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c line 112
Quoted 10 lines
drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c +0
-10-dpu_dbg_reg_register_base ("reg_dma" , addr, - reg_dma.caps->len); -break ; -default : -break ; - } - -return 0 ; -} -
../scripts/Makefile.build:559: recipe for target 'drivers/gpu/drm' failed
../scripts/Makefile.build:559: recipe for target 'drivers/gpu' failed/usr/local/google/home/seanpaul/s/dpu-staging/Makefile:1060: recipe for target 'drivers' failed
make[1]: Leaving directory '/usr/local/google/home/seanpaul/s/dpu-staging/.build_arm'
Makefile:146: recipe for target 'sub-make' failed../drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c: In function ‘dpu_crtc_atomic_check’:../drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:2097:1: warning: the frame size of 1048 bytes is larger than 1024 bytes [-Wframe-larger-than=]
}
^../drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c: In function ‘dpu_kms_hw_init’:../drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:1512:7: error: implicit declaration of function ‘dpu_reg_dma_init’; did you mean ‘dpu_rm_init’? [-Werror=implicit-function-declaration]
rc = dpu_reg_dma_init(dpu_kms->reg_dma, dpu_kms->catalog,
^~~~~~~~~~~~~~~~
dpu_rm_initcc1: some warnings being treated as errors
/snip
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
PATCH v2 3/7 drm/msm: enable zpos normalization
In reply to a message not in the archiveEnable drm core zpos normalization for planes.
changes in v2:
- none
--- drivers/gpu/drm/msm/msm_drv.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/msm/msm_drv.c +3 -0
@@ -592,6 +592,9 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv) ddev->mode_config.funcs = &mode_config_funcs; ddev->mode_config.helper_private = &mode_config_helper_funcs; +/* Enable normalization of plane zpos */ + ddev->mode_config.normalize_zpos = true; +if (kms) { ret = kms->funcs->hw_init (kms);if (ret) {
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
PATCH v2 4/7 drm/msm/dpu: switch to drm zpos property
In reply to a message not in the archiveReplace custom plane zpos property with drm core zpos property. CRTC relies on the normalized zpos values to configure blend stages of each plane.
changes in v2:
- Move out unrelated changes in plane init (Sean Paul)
--- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 36 +------------------------------ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 16 +++++++++++--- 2 files changed, 14 insertions(+), 38 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +1 -35
@@ -2582,24 +2582,6 @@ struct plane_state {u32 pipe_id; }; -static int pstate_cmp (const void *a,const void *b) -{ -struct plane_state *pa = (struct plane_state *)a; -struct plane_state *pb = (struct plane_state *)b; -int rc =0 ; -int pa_zpos, pb_zpos; - - pa_zpos =dpu_plane_get_property (pa->dpu_pstate,PLANE_PROP_ZPOS ); - pb_zpos =dpu_plane_get_property (pb->dpu_pstate,PLANE_PROP_ZPOS ); - -if (pa_zpos != pb_zpos) - rc = pa_zpos - pb_zpos; -else - rc = pa->drm_pstate->crtc_x - pb->drm_pstate->crtc_x; - -return rc; -} -static int dpu_crtc_atomic_check (struct drm_crtc *crtc,struct drm_crtc_state *state) {
@@ -2665,8 +2647,7 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc, pstates[cnt].dpu_pstate =to_dpu_plane_state (pstate); pstates[cnt].drm_pstate = pstate; - pstates[cnt].stage =dpu_plane_get_property ( - pstates[cnt].dpu_pstate,PLANE_PROP_ZPOS ); + pstates[cnt].stage = pstate->normalized_zpos; pstates[cnt].pipe_id =dpu_plane_pipe (plane);/* check dim layer stage with every plane */
@@ -2722,21 +2703,6 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc, } } -/* assign mixer stages based on sorted zpos property */ -sort (pstates, cnt,sizeof (pstates[0 ]), pstate_cmp,NULL ); - -if (!dpu_is_custom_client ()) { -int stage_old = pstates[0 ].stage; - - z_pos =0 ; -for (i =0 ; i < cnt; i++) { -if (stage_old != pstates[i].stage) - ++z_pos; - stage_old = pstates[i].stage; - pstates[i].stage = z_pos; - } - } - z_pos =-1 ;for (i =0 ; i < cnt; i++) {/* reset counts at every new blend stage */
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +13 -3
@@ -59,6 +59,7 @@#define DPU_NAME_SIZE 12#define DPU_PLANE_COLOR_FILL_FLAG BIT(31) +#define DPU_ZPOS_MAX 255/* multirect rect index */ enum {
@@ -1518,9 +1519,6 @@ static void _dpu_plane_install_properties(struct drm_plane *plane,/* reserve zpos == 0 for primary planes */ zpos_def =drm_plane_index (plane) +1 ; } - -msm_property_install_range (&pdpu->property_info,"zpos" , -0x0 ,0 , zpos_max, zpos_def,PLANE_PROP_ZPOS ); } static int dpu_plane_atomic_set_property(struct drm_plane *plane,
@@ -1958,6 +1956,7 @@ struct drm_plane *dpu_plane_init(struct drm_device *dev,struct msm_drm_private *priv;struct dpu_kms *kms;enum drm_plane_type type; +int zpos_max =DPU_ZPOS_MAX ;int ret = -EINVAL ;if (!dev) {
@@ -2051,6 +2050,17 @@ struct drm_plane *dpu_plane_init(struct drm_device *dev, pdpu->catalog = kms->catalog; +if (kms->catalog->mixer_count && + kms->catalog->mixer[0 ].sblk->maxblendstages) { + zpos_max = kms->catalog->mixer[0 ].sblk->maxblendstages -1 ; +if (zpos_max >DPU_STAGE_MAX -DPU_STAGE_0 -1 ) + zpos_max =DPU_STAGE_MAX -DPU_STAGE_0 -1 ; + } + + ret =drm_plane_create_zpos_property (plane,0 ,0 , zpos_max); +if (ret) +DPU_ERROR ("failed to install zpos property, rc = %d\n" , ret); +/* success! finalize initialization */ drm_plane_helper_add (plane, &dpu_plane_helper_funcs);
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
PATCH v2 5/7 drm/msm/dpu: clean up dpu crtc custom properties
In reply to a message not in the archiveRemove dpu crtc custom properties and its handlers.
changes in v2:
- none
--- drivers/gpu/drm/msm/Makefile | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 28 - drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 856 +------------------------- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 27 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c | 149 ----- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h | 111 ---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 67 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 14 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 16 - drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 71 +-- drivers/gpu/drm/msm/msm_drv.h | 15 - 12 files changed, 11 insertions(+), 1356 deletions(-) delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h
drivers/gpu/drm/msm/Makefile +0 -1
@@ -57,7 +57,6 @@ msm-y := \ disp/dpu1/dpu_hw_catalog.o \ disp/dpu1/dpu_hw_cdm.o \ disp/dpu1/dpu_hw_ctl.o \ - disp/dpu1/dpu_hw_ds.o \ disp/dpu1/dpu_hw_interrupts.o \ disp/dpu1/dpu_hw_intf.o \ disp/dpu1/dpu_hw_lm.o \
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c +0 -28
@@ -102,34 +102,6 @@ static void _dpu_core_perf_calc_crtc(struct dpu_kms *kms, dpu_cstate =to_dpu_crtc_state (state);memset (perf,0 ,sizeof (struct dpu_core_perf_params )); - perf->bw_ctl[DPU_POWER_HANDLE_DBUS_ID_MNOC ] = -dpu_crtc_get_property (dpu_cstate,CRTC_PROP_CORE_AB ); - perf->max_per_pipe_ib[DPU_POWER_HANDLE_DBUS_ID_MNOC ] = -dpu_crtc_get_property (dpu_cstate,CRTC_PROP_CORE_IB ); - -if (dpu_cstate->bw_split_vote) { - perf->bw_ctl[DPU_POWER_HANDLE_DBUS_ID_LLCC ] = -dpu_crtc_get_property (dpu_cstate,CRTC_PROP_LLCC_AB ); - perf->max_per_pipe_ib[DPU_POWER_HANDLE_DBUS_ID_LLCC ] = -dpu_crtc_get_property (dpu_cstate,CRTC_PROP_LLCC_IB ); - perf->bw_ctl[DPU_POWER_HANDLE_DBUS_ID_EBI ] = -dpu_crtc_get_property (dpu_cstate,CRTC_PROP_DRAM_AB ); - perf->max_per_pipe_ib[DPU_POWER_HANDLE_DBUS_ID_EBI ] = -dpu_crtc_get_property (dpu_cstate,CRTC_PROP_DRAM_IB ); - }else { - perf->bw_ctl[DPU_POWER_HANDLE_DBUS_ID_LLCC ] = -dpu_crtc_get_property (dpu_cstate,CRTC_PROP_CORE_AB ); - perf->max_per_pipe_ib[DPU_POWER_HANDLE_DBUS_ID_LLCC ] = -dpu_crtc_get_property (dpu_cstate,CRTC_PROP_CORE_IB ); - perf->bw_ctl[DPU_POWER_HANDLE_DBUS_ID_EBI ] = -dpu_crtc_get_property (dpu_cstate,CRTC_PROP_CORE_AB ); - perf->max_per_pipe_ib[DPU_POWER_HANDLE_DBUS_ID_EBI ] = -dpu_crtc_get_property (dpu_cstate,CRTC_PROP_CORE_IB ); - } - - perf->core_clk_rate = -dpu_crtc_get_property (dpu_cstate,CRTC_PROP_CORE_CLK ); -if (!dpu_cstate->bw_control) {for (i =0 ; i <DPU_POWER_HANDLE_DBUS_ID_MAX ; i++) { perf->bw_ctl[i] = kms->catalog->perf.max_bw_high *
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +3 -853
985 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h +3 -24
@@ -26,7 +26,6 @@#include "dpu_kms.h" #include "dpu_core_perf.h" #include "dpu_hw_blk.h" -#include "dpu_hw_ds.h" #define DPU_CRTC_NAME_SIZE 12
@@ -87,7 +86,6 @@ struct dpu_crtc_smmu_state_data {* struct dpu_crtc_mixer: stores the map for each virtual pipeline in the CRTC * @hw_lm: LM HW Driver context * @hw_ctl: CTL Path HW driver context -* @hw_ds: DS HW driver context * @encoder: Encoder attached to this lm & ctl * @mixer_op_mode: mixer blending operation mode * @flush_mask: mixer flush mask for ctl, mixer and pipe
@@ -95,7 +93,6 @@ struct dpu_crtc_smmu_state_data {struct dpu_crtc_mixer {struct dpu_hw_mixer *hw_lm;struct dpu_hw_ctl *hw_ctl; -struct dpu_hw_ds *hw_ds;struct drm_encoder *encoder;u32 mixer_op_mode;u32 flush_mask;
@@ -314,12 +311,6 @@ struct dpu_crtc_respool {* @property_state: Local storage for msm_prop properties * @property_values: Current crtc property values * @input_fence_timeout_ns : Cached input fence timeout, in ns -* @num_dim_layers: Number of dim layers -* @dim_layer: Dim layer configs -* @num_ds: Number of destination scalers to be configured -* @num_ds_enabled: Number of destination scalers enabled -* @ds_dirty: Boolean to indicate if dirty or not -* @ds_cfg: Destination scaler config * @new_perf: new performance state being requested */ struct dpu_crtc_state {
@@ -336,12 +327,6 @@ struct dpu_crtc_state {struct msm_property_state property_state;struct msm_property_value property_values[CRTC_PROP_COUNT ];uint64_t input_fence_timeout_ns; -uint32_t num_dim_layers; -struct dpu_hw_dim_layer dim_layer[DPU_MAX_DIM_LAYERS ]; -uint32_t num_ds; -uint32_t num_ds_enabled; -bool ds_dirty; -struct dpu_hw_ds_cfg ds_cfg[DPU_MAX_DS_COUNT ];struct dpu_core_perf_params new_perf;struct dpu_crtc_respool rp;
@@ -362,7 +347,6 @@ struct dpu_crtc_state {/** * dpu_crtc_get_mixer_width - get the mixer width * Mixer width will be same as panel width(/2 for split) -* unless destination scaler feature is enabled */ static inline int dpu_crtc_get_mixer_width (struct dpu_crtc *dpu_crtc,struct dpu_crtc_state *cstate,struct drm_display_mode *mode)
@@ -372,10 +356,7 @@ static inline int dpu_crtc_get_mixer_width(struct dpu_crtc *dpu_crtc,if (!dpu_crtc || !cstate || !mode)return 0 ; -if (cstate->num_ds_enabled) - mixer_width = cstate->ds_cfg[0 ].lm_width; -else - mixer_width = (dpu_crtc->num_mixers ==CRTC_DUAL_MIXERS ? + mixer_width = (dpu_crtc->num_mixers ==CRTC_DUAL_MIXERS ? mode->hdisplay /CRTC_DUAL_MIXERS : mode->hdisplay);return mixer_width;
@@ -383,8 +364,7 @@ static inline int dpu_crtc_get_mixer_width(struct dpu_crtc *dpu_crtc,/** * dpu_crtc_get_mixer_height - get the mixer height -* Mixer height will be same as panel height unless -* destination scaler feature is enabled +* Mixer height will be same as panel height */ static inline int dpu_crtc_get_mixer_height (struct dpu_crtc *dpu_crtc,struct dpu_crtc_state *cstate,struct drm_display_mode *mode)
@@ -392,8 +372,7 @@ static inline int dpu_crtc_get_mixer_height(struct dpu_crtc *dpu_crtc,if (!dpu_crtc || !cstate || !mode)return 0 ; -return (cstate->num_ds_enabled ? - cstate->ds_cfg[0 ].lm_height : mode->vdisplay); +return mode->vdisplay; }/**
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +0 -12
@@ -230,18 +230,6 @@ struct dpu_encoder_virt { };#define to_dpu_encoder_virt (x) container_of(x, struct dpu_encoder_virt, base) - -void dpu_encoder_set_idle_timeout (struct drm_encoder *drm_enc,u32 idle_timeout) -{ -struct dpu_encoder_virt *dpu_enc; - -if (!drm_enc) -return ; - - dpu_enc =to_dpu_encoder_virt (drm_enc); - dpu_enc->idle_timeout = idle_timeout; -} -static inline int _dpu_encoder_power_enable (struct dpu_encoder_virt *dpu_enc,bool enable) {
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c deleted +0 -149
149 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h deleted +0 -111
111 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c +0 -67
79 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h +0 -14
@@ -67,20 +67,6 @@ struct dpu_hw_lm_ops {void (*setup_gc)(struct dpu_hw_mixer *mixer,void *cfg); -/** -* setup_dim_layer: configure dim layer settings -* @ctx: Pointer to layer mixer context -* @dim_layer: dim layer configs -*/ -void (*setup_dim_layer)(struct dpu_hw_mixer *ctx, -struct dpu_hw_dim_layer *dim_layer); - -/** -* clear_dim_layer: clear dim layer settings -* @ctx: Pointer to layer mixer context -*/ -void (*clear_dim_layer)(struct dpu_hw_mixer *ctx); -/* setup_misr: enables/disables MISR in HW register */ void (*setup_misr)(struct dpu_hw_mixer *ctx,bool enable,u32 frame_count);
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h +0 -16
@@ -99,7 +99,6 @@ enum dpu_hw_blk_type {DPU_HW_BLK_TOP =0 ,DPU_HW_BLK_SSPP ,DPU_HW_BLK_LM , -DPU_HW_BLK_DS ,DPU_HW_BLK_CTL ,DPU_HW_BLK_CDM , DPU_HW_BLK_PINGPONG,
@@ -469,20 +468,5 @@ struct dpu_mdss_color {#define DPU_DBG_MASK_TOP (1 << 8)#define DPU_DBG_MASK_VBIF (1 << 9)#define DPU_DBG_MASK_ROT (1 << 10) -#define DPU_DBG_MASK_DS (1 << 11) - -/** -* struct dpu_hw_dim_layer: dim layer configs -* @flags: Flag to represent INCLUSIVE/EXCLUSIVE -* @stage: Blending stage of dim layer -* @color_fill: Color fill to be used for the layer -* @rect: Dim layer coordinates -*/ -struct dpu_hw_dim_layer { -uint32_t flags; -uint32_t stage; -struct dpu_mdss_color color_fill; -struct dpu_rect rect; -};#endif /* _DPU_HW_MDSS_H */
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c +5 -66
157 lines not on this page · raw message
drivers/gpu/drm/msm/msm_drv.h +0 -15
@@ -89,25 +89,10 @@ enum msm_mdp_plane_property {enum msm_mdp_crtc_property {CRTC_PROP_INFO , -CRTC_PROP_DEST_SCALER_LUT_ED , -CRTC_PROP_DEST_SCALER_LUT_CIR , -CRTC_PROP_DEST_SCALER_LUT_SEP ,/* # of blob properties */ CRTC_PROP_BLOBCOUNT , -/* range properties */ -CRTC_PROP_DIM_LAYER_V1 =CRTC_PROP_BLOBCOUNT , -CRTC_PROP_CORE_CLK , -CRTC_PROP_CORE_AB , -CRTC_PROP_CORE_IB , -CRTC_PROP_LLCC_AB , -CRTC_PROP_LLCC_IB , -CRTC_PROP_DRAM_AB , -CRTC_PROP_DRAM_IB , -CRTC_PROP_IDLE_TIMEOUT , -CRTC_PROP_DEST_SCALER , -/* total # of properties */ CRTC_PROP_COUNT };
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
PATCH v2 6/7 drm/msm: remove msm_prop files
In reply to a message not in the archiveRemove hand rolled msm property caching to handle DPU custom properties. This change also cleans up all its dependencies to cache and restore respective drm states.
changs in v2:
- none
--- drivers/gpu/drm/msm/Makefile | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 - drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 239 +-------- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 16 - drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 2 - drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 123 +---- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 12 - drivers/gpu/drm/msm/msm_drv.h | 16 +- drivers/gpu/drm/msm/msm_prop.c | 688 -------------------------- drivers/gpu/drm/msm/msm_prop.h | 438 ---------------- 10 files changed, 8 insertions(+), 1529 deletions(-) delete mode 100644 drivers/gpu/drm/msm/msm_prop.c delete mode 100644 drivers/gpu/drm/msm/msm_prop.h
drivers/gpu/drm/msm/Makefile +0 -1
@@ -76,7 +76,6 @@ msm-y := \ dpu_io_util.o \ dpu_dbg_evtlog.o \ dpu_power_handle.o \ - msm_prop.o \ msm_atomic.o \ msm_debugfs.o \ msm_drv.o \
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c +0 -2
@@ -19,8 +19,6 @@#include <linux/clk.h> #include <linux/bitmap.h> -#include "msm_prop.h" -#include "dpu_kms.h" #include "dpu_trace.h" #include "dpu_crtc.h"
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +3 -236
291 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h +0 -16
@@ -22,7 +22,6 @@#include <linux/kthread.h> #include <uapi/drm/dpu_drm.h> #include <drm/drm_crtc.h> -#include "msm_prop.h" #include "dpu_kms.h" #include "dpu_core_perf.h" #include "dpu_hw_blk.h"
@@ -200,10 +199,6 @@ struct dpu_crtc {struct drm_pending_vblank_event *event;u32 vsync_count; -struct msm_property_info property_info; -struct msm_property_data property_data[CRTC_PROP_COUNT ]; -struct drm_property_blob *blob_info; -struct dpu_hw_stage_cfg stage_cfg;struct dentry *debugfs_root;
@@ -324,8 +319,6 @@ struct dpu_crtc_state {bool is_ppsplit;struct dpu_rect lm_bounds[CRTC_DUAL_MIXERS ]; -struct msm_property_state property_state; -struct msm_property_value property_values[CRTC_PROP_COUNT ];uint64_t input_fence_timeout_ns;struct dpu_core_perf_params new_perf;
@@ -336,15 +329,6 @@ struct dpu_crtc_state { container_of(x, struct dpu_crtc_state, base)/** -* dpu_crtc_get_property - query integer value of crtc property -* @S: Pointer to crtc state -* @X: Property index, from enum msm_mdp_crtc_property -* Returns: Integer value of requested property - */ -#define dpu_crtc_get_property (S ,X ) \ - ((S) && ((X) < CRTC_PROP_COUNT) ? ((S)->property_values[(X)].value) : 0) - -/** * dpu_crtc_get_mixer_width - get the mixer width * Mixer width will be same as panel width(/2 for split) */
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h +0 -2
@@ -20,8 +20,6 @@#define __DPU_ENCODER_H__#include <drm/drm_crtc.h> - -#include "msm_prop.h" #include "dpu_hw_mdss.h" #define DPU_ENCODER_FRAME_EVENT_DONE BIT(0)
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +4 -119
207 lines not on this page · raw message
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h +0 -12
@@ -21,7 +21,6 @@#include <drm/drm_crtc.h> -#include "msm_prop.h" #include "dpu_kms.h" #include "dpu_hw_mdss.h" #include "dpu_hw_sspp.h"
@@ -44,8 +43,6 @@*/ struct dpu_plane_state {struct drm_plane_state base; -struct msm_property_state property_state; -struct msm_property_value property_values[PLANE_PROP_COUNT ];struct msm_gem_address_space *aspace;void *input_fence;enum dpu_stage stage;
@@ -74,15 +71,6 @@ struct dpu_multirect_plane_states { container_of(x, struct dpu_plane_state, base)/** -* dpu_plane_get_property - Query integer value of plane property -* @S: Pointer to plane state -* @X: Property index, from enum msm_mdp_plane_property -* Returns: Integer value of requested property - */ -#define dpu_plane_get_property (S ,X ) ((S) && ((X) < PLANE_PROP_COUNT) ? \ - ((S)->property_values[(X)].value) : 0) - -/** * dpu_plane_pipe - return sspp identifier for the given plane * @plane: Pointer to DRM plane object * Returns: sspp identifier of the given plane
drivers/gpu/drm/msm/msm_drv.h +1 -15
@@ -77,26 +77,13 @@ struct msm_file_private { };enum msm_mdp_plane_property { -/* # of blob properties */ -PLANE_PROP_BLOBCOUNT , -/* range properties */ -PLANE_PROP_ZPOS =PLANE_PROP_BLOBCOUNT , +PLANE_PROP_ZPOS ,/* total # of properties */ PLANE_PROP_COUNT }; -enum msm_mdp_crtc_property { -CRTC_PROP_INFO , - -/* # of blob properties */ -CRTC_PROP_BLOBCOUNT , - -/* total # of properties */ -CRTC_PROP_COUNT -}; -struct msm_vblank_ctrl {struct kthread_work work;struct list_head event_list;
@@ -364,7 +351,6 @@ struct msm_drm_private {/* Properties */ struct drm_property *plane_property[PLANE_PROP_COUNT ]; -struct drm_property *crtc_property[CRTC_PROP_COUNT ];/* Color processing properties for the crtc */ struct drm_property **cp_property;
drivers/gpu/drm/msm/msm_prop.c deleted +0 -688
688 lines not on this page · raw message
drivers/gpu/drm/msm/msm_prop.h deleted +0 -438
438 lines not on this page · raw message
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
PATCH v2 7/7 drm/msm: remove dpu specific uapi header
In reply to Jeykumar Sankaranremove unwanted dpu uapi headers exposing custom
payload layouts for custom properties
changs in v2:
- none
--- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 1 - include/uapi/drm/dpu_drm.h | 220 ------------------- include/uapi/drm/msm_drm_pp.h | 345 ------------------------------ 4 files changed, 567 deletions(-) delete mode 100644 include/uapi/drm/dpu_drm.h delete mode 100644 include/uapi/drm/msm_drm_pp.h
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h +0 -1
@@ -20,7 +20,6 @@#define _DPU_CRTC_H_#include <linux/kthread.h> -#include <uapi/drm/dpu_drm.h> #include <drm/drm_crtc.h> #include "dpu_kms.h" #include "dpu_core_perf.h"
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c +0 -1
@@ -10,7 +10,6 @@* GNU General Public License for more details. */ -#include <uapi/drm/dpu_drm.h> #include "dpu_kms.h" #include "dpu_hw_catalog.h" #include "dpu_hwio.h"
include/uapi/drm/dpu_drm.h deleted +0 -220
220 lines not on this page · raw message
include/uapi/drm/msm_drm_pp.h deleted +0 -345
345 lines not on this page · raw message
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 9 lines · Jeykumar Sankaran
Submitting a series of patches to further clean up DPU driver by stripping down a list of custom properties supporting proprietary features. It removes the property installers/handlers and cleans up relevant files of of some of the advanced features. This series is based on the patch[1] available on the drm-next tip.
[1]https://patchwork.kernel.org/patch/10202847/
Thanks.
Lots of conflicts when I applied this set, what branch did you base this on?
Sean
Quoted 102 lines
changes in v2:
- remove stale code in blend config
- move unrelated code while updating zpos property
-MakefilechangesJeykumar Sankaran (7):
drm/msm: remove connector custom properties drm/msm/dpu: clean up dpu plane custom properties drm/msm: enable zpos normalization drm/msm/dpu: switch to drm zpos property drm/msm/dpu: clean up dpu crtc custom properties drm/msm: removemsm_propfiles
drm/msm: remove dpu specific uapi headerdrivers/gpu/drm/msm/Makefile | 10 - drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h | 99 -- .../gpu/drm/msm/disp/dpu1/dpu_color_processing.c | 1521 -------------------- .../gpu/drm/msm/disp/dpu1/dpu_color_processing.h | 120 -- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 30 - drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 1328 +---------------- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 45 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 14 - drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 2 - .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c | 1443 ------------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 72 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 89 -- .../msm/disp/dpu1/dpu_hw_color_proc_common_v4.h | 69 - .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c | 242 ---- .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h | 40 - .../drm/msm/disp/dpu1/dpu_hw_color_processing.h | 20 - .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.c | 565 -------- .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.h | 92 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 44 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 15 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c | 149 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h | 111 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 209 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h | 220 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 67 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 14 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 58 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 68 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 6 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 757 ---------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h | 27 - .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c | 943 ------------ .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h | 75 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 219 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 73 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 156 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 - drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 1404 ++---------------- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 43 - drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c | 139 -- drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h | 310 ---- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 149 +- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 2 - drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c | 2 - drivers/gpu/drm/msm/msm_drv.c | 3 + drivers/gpu/drm/msm/msm_drv.h | 86 +- drivers/gpu/drm/msm/msm_prop.c | 688 --------- drivers/gpu/drm/msm/msm_prop.h | 438 ------ include/uapi/drm/dpu_drm.h | 407 ------ include/uapi/drm/msm_drm.h | 1 - include/uapi/drm/msm_drm_pp.h | 345 ----- 53 files changed, 297 insertions(+), 12737 deletions(-) delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_common_v4.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h delete mode 100644 drivers/gpu/drm/msm/msm_prop.c delete mode 100644 drivers/gpu/drm/msm/msm_prop.h delete mode 100644 include/uapi/drm/dpu_drm.h delete mode 100644 include/uapi/drm/msm_drm_pp.hSignature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel