ndctl: add an api for getting the ars_status overflow flag
Vishal Verma
maintainerPATCH v3 1/1 ndctl: add an api for getting the ars_status overflow flag
The ARS status command defines a 'flags' field that wasn't being exposed via an API yet. Since there is only one flag defined in ACPI 6.2, add a helper for retrieving it (overflow flag).
--- ndctl/lib/ars.c | 11 +++++++++++ ndctl/lib/libndctl.sym | 1 + ndctl/libndctl.h | 4 ++++ 3 files changed, 16 insertions(+)
v3: ensure we can only return 0, 1, or -error from this interface. (Dan)
ndctl/lib/ars.c +11 -0
@@ -269,6 +269,17 @@ NDCTL_EXPORT unsigned long long ndctl_cmd_ars_get_record_len(return ars_stat->ars_status->records[rec_index].length; } +NDCTL_EXPORT int ndctl_cmd_ars_stat_get_flag_overflow( +struct ndctl_cmd *ars_stat) +{ +struct ndctl_ctx *ctx =ndctl_bus_get_ctx (cmd_to_bus (ars_stat)); + +if (!validate_ars_stat (ctx, ars_stat)) +return -EINVAL ; + +return !!(ars_stat->ars_status->flags &ND_ARS_STAT_FLAG_OVERFLOW ); +} + NDCTL_EXPORT struct ndctl_cmd *ndctl_bus_cmd_new_clear_error(unsigned long long address,unsigned long long len,struct ndctl_cmd *ars_cap)
ndctl/lib/libndctl.sym +1 -0
@@ -365,4 +365,5 @@ global: ndctl_cmd_ars_cap_get_clear_unit; ndctl_namespace_inject_error2; ndctl_namespace_uninject_error2; + ndctl_cmd_ars_stat_get_flag_overflow; } LIBNDCTL_15;
ndctl/libndctl.h +4 -0
@@ -187,6 +187,9 @@ int ndctl_dimm_is_enabled(struct ndctl_dimm *dimm);int ndctl_dimm_disable (struct ndctl_dimm *dimm);int ndctl_dimm_enable (struct ndctl_dimm *dimm); +/* ars_status flags */ +#define ND_ARS_STAT_FLAG_OVERFLOW (1 << 0) +struct ndctl_cmd ;struct ndctl_cmd *ndctl_bus_cmd_new_ars_cap (struct ndctl_bus *bus,unsigned long long address,unsigned long long len);
@@ -210,6 +213,7 @@ struct ndctl_cmd *ndctl_bus_cmd_new_clear_error(unsigned long long address,unsigned long long ndctl_cmd_clear_error_get_cleared (struct ndctl_cmd *clear_err);unsigned int ndctl_cmd_ars_cap_get_clear_unit (struct ndctl_cmd *ars_cap); +int ndctl_cmd_ars_stat_get_flag_overflow (struct ndctl_cmd *ars_stat);/* * Note: ndctl_cmd_smart_get_temperature is an alias for
Signature · 6 lines
2.17.0 _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
Quoted 52 lines · Vishal Verma
The ARS status command defines a 'flags' field that wasn't being exposed via an API yet. Since there is only one flag defined in ACPI 6.2, add a helper for retrieving it (overflow flag).
Reported-by Jacek Zloch <[email protected]>Cc Dan Williams <[email protected]>Signed-off-by Vishal Verma <[email protected]>--- ndctl/lib/ars.c | 11 +++++++++++ ndctl/lib/libndctl.sym | 1 + ndctl/libndctl.h | 4 ++++ 3 files changed, 16 insertions(+)v3: ensure we can only return 0, 1, or -error from this interface. (Dan)
ndctl/lib/ars.c +11
-0@@ -269,6 +269,17 @@ NDCTL_EXPORT unsigned long long ndctl_cmd_ars_get_record_len(return ars_stat->ars_status->records[rec_index].length; } +NDCTL_EXPORT int ndctl_cmd_ars_stat_get_flag_overflow( +struct ndctl_cmd *ars_stat) +{ +struct ndctl_ctx *ctx =ndctl_bus_get_ctx (cmd_to_bus (ars_stat)); + +if (!validate_ars_stat (ctx, ars_stat)) +return -EINVAL ; + +return !!(ars_stat->ars_status->flags &ND_ARS_STAT_FLAG_OVERFLOW ); +} + NDCTL_EXPORT struct ndctl_cmd *ndctl_bus_cmd_new_clear_error(unsigned long long address,unsigned long long len,struct ndctl_cmd *ars_cap)ndctl/lib/libndctl.sym +1
-0@@ -365,4 +365,5 @@ global: ndctl_cmd_ars_cap_get_clear_unit; ndctl_namespace_inject_error2; ndctl_namespace_uninject_error2; + ndctl_cmd_ars_stat_get_flag_overflow; } LIBNDCTL_15;ndctl/libndctl.h +0
-0
ndctl/libndctl.h int ndctl_dimm_is_enabled(struct ndctl_dimm *dimm); · line 191
Quoted 5 lines
ndctl/libndctl.h +2
-0@@ -187,6 +187,9 @@ int ndctl_dimm_is_enabled(struct ndctl_dimm *dimm);int ndctl_dimm_disable (struct ndctl_dimm *dimm);int ndctl_dimm_enable (struct ndctl_dimm *dimm); +/* ars_status flags */ +#define ND_ARS_STAT_FLAG_OVERFLOW (1 << 0)
Oh, sorry, one more thing. This should move to ndctl/lib/private.h, right?
With that you can add:
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
Verma, Vishal L
maintainerQuoted 62 lines · Dan Williams
Quoted 60 lines · Vishal Verma
The ARS status command defines a 'flags' field that wasn't being exposed
via an API yet. Since there is only one flag defined in ACPI 6.2, add a helper for retrieving it (overflow flag).Reported-by Jacek Zloch <[email protected]>Cc Dan Williams <[email protected]>Signed-off-by Vishal Verma <[email protected]>--- ndctl/lib/ars.c | 11 +++++++++++ ndctl/lib/libndctl.sym | 1 + ndctl/libndctl.h | 4 ++++ 3 files changed, 16 insertions(+)v3: ensure we can only return 0, 1, or -error from this interface. (Dan)
ndctl/lib/ars.c +0
-0@@ -269,6 +269,17 @@ NDCTL_EXPORT unsigned long longndctl_cmd_ars_get_record_len(
return ars_stat->ars_status->records[rec_index].length;}
ndctl/lib/ars.c +4
-0+NDCTL_EXPORT int ndctl_cmd_ars_stat_get_flag_overflow( +struct ndctl_cmd *ars_stat) +{ + struct ndctl_ctx *ctx =ndctl_bus_get_ctx(cmd_to_bus(ars_stat));
ndctl/lib/ars.c +5
-0+ +if (!validate_ars_stat (ctx, ars_stat)) +return -EINVAL ; + + return !!(ars_stat->ars_status->flags &
ND_ARS_STAT_FLAG_OVERFLOW);ndctl/lib/ars.c +2
-0+} + NDCTL_EXPORT struct ndctl_cmd *ndctl_bus_cmd_new_clear_error(unsigned long long address,unsigned long long len,struct ndctl_cmd *ars_cap)ndctl/lib/libndctl.sym +1
-0@@ -365,4 +365,5 @@ global: ndctl_cmd_ars_cap_get_clear_unit; ndctl_namespace_inject_error2; ndctl_namespace_uninject_error2; + ndctl_cmd_ars_stat_get_flag_overflow; } LIBNDCTL_15;ndctl/libndctl.h +0
-0@@ -187,6 +187,9 @@ int ndctl_dimm_is_enabled(struct ndctl_dimm *dimm);int ndctl_dimm_disable (struct ndctl_dimm *dimm);int ndctl_dimm_enable (struct ndctl_dimm *dimm);
Quoted 5 lines
ndctl/libndctl.h int ndctl_dimm_is_enabled(struct ndctl_dimm *dimm); · line 191
Quoted 2 lines
ndctl/libndctl.h +2
-0+/* ars_status flags */ +#define ND_ARS_STAT_FLAG_OVERFLOW (1 << 0)Oh, sorry, one more thing. This should move to
ndctl/lib/private.h, right?
Yes, good catch, thanks!
Quoted 4 lines
With that you can add:
Reviewed-by Dan Williams <[email protected]>
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm