Staging:rtl8192e Replace function names by using __func__ identifier
PATCH 1/4 Staging:rtl8192e Replace function names by using __func__ identifier
This patch is created to solve the warning shown by checkpatch script Prefer using '"%s...", __func__' to using ', this function's name, in a string
--- drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/rtl8192e/rtl819x_BAProc.c +1 -1
@@ -127,7 +127,7 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst, }#ifdef VERBOSE_DEBUG - print_hex_dump_bytes("rtllib_ADDBA(): ", DUMP_PREFIX_NONE, skb->data, + print_hex_dump_bytes("%s(): ", __func__, DUMP_PREFIX_NONE, skb->data,
skb->len);
#endif
return skb;
@@ -178,7 +178,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device *ieee, u8 *dst,
tag += 2;
#ifdef VERBOSE_DEBUG
- print_hex_dump_bytes("rtllib_DELBA(): ", DUMP_PREFIX_NONE, skb->data,
+ print_hex_dump_bytes("%s(): ", __func__, DUMP_PREFIX_NONE, skb->data,
skb->len);
#endif
return skb;
@@ -243,7 +243,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
}
#ifdef VERBOSE_DEBUG
- print_hex_dump_bytes("rtllib_rx_ADDBAReq(): ", DUMP_PREFIX_NONE,
+ print_hex_dump_bytes("%s(): ", __func__, DUMP_PREFIX_NONE,
skb->data, skb->len);
#endif
@@ -441,7 +441,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
}
#ifdef VERBOSE_DEBUG
- print_hex_dump_bytes("rtllib_rx_DELBA(): ", DUMP_PREFIX_NONE, skb->data,
+ print_hex_dump_bytes("%s():", __func__, DUMP_PREFIX_NONE, skb->data,
skb->len);
#endif
delba = (struct rtllib_hdr_3addr *)skb->data;
--
1.9.1
Andy Shevchenko
NAKQuoted 3 lines · Janani Sankara Babu
This patch is created to solve the warning shown by checkpatch script Prefer using '"%s...",
__func__' to using ', this function's name, in a string
Have you even tried to compile it?
NAK
Quoted 49 lines
Signed-off-by Janani Sankara Babu <[email protected]>--- drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/staging/rtl8192e/rtl819x_BAProc.c +4
-5@@ -127,7 +127,7 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst, }#ifdef VERBOSE_DEBUG -print_hex_dump_bytes ("rtllib_ADDBA(): " ,DUMP_PREFIX_NONE , skb->data, +print_hex_dump_bytes ("%s(): " , __func__,DUMP_PREFIX_NONE , skb->data, skb->len);#endif return skb;@@ -178,7 +178,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device *ieee, u8 *dst, tag +=2 ;#ifdef VERBOSE_DEBUG -print_hex_dump_bytes ("rtllib_DELBA(): " ,DUMP_PREFIX_NONE , skb->data, +print_hex_dump_bytes ("%s(): " , __func__,DUMP_PREFIX_NONE , skb->data, skb->len);#endif return skb;@@ -243,7 +243,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb) }#ifdef VERBOSE_DEBUG -print_hex_dump_bytes ("rtllib_rx_ADDBAReq(): " ,DUMP_PREFIX_NONE , +print_hex_dump_bytes ("%s(): " , __func__,DUMP_PREFIX_NONE , skb->data, skb->len);#endif @@ -441,7 +441,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb) }#ifdef VERBOSE_DEBUG -print_hex_dump_bytes ("rtllib_rx_DELBA(): " ,DUMP_PREFIX_NONE , skb->data, +print_hex_dump_bytes ("%s():" , __func__,DUMP_PREFIX_NONE , skb->data, skb->len);#endif delba = (struct rtllib_hdr_3addr *)skb->data; --1.9.1
Signature · 2 lines
With Best Regards, Andy Shevchenko
A message that is not in the archive (sent off-list or not yet received): CACHTOGocFR_JVOjS-uo1-nehwUJ5vC6cd1+jcWsu2gfdgLFrOA@mail.gmail.com
Greg Kroah-Hartman
maintainerQuoted 1 line · Janani Sankara Babu
Sorry , Kindly ignore this patch.
I'm dropping this whole series as I can not tell what should, and what should not, be applied.
Please fix them all up and resend, as a properly threaded patch series.
thanks,
greg k-h