drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
Subsystems (2)
PATCH 1/1 drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
From: Clint Taylor <[email protected]>
On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal.
When measured on a scope the highspeed lines of the HDMI clock turn off
for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC appears to require at least a full frame of quiet time before a
new faster clock can be correctly sync'd. The worst case scenario appears to be 23.98Hz modes which requires a wait of 41.25ms. Add a quirk to the driver for GLK NUC that waits 42ms.
Cc: Imre Deak <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105887
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 8 ++++++++ drivers/gpu/drm/i915/intel_display.c | 14 ++++++++++++++ 3 files changed, 23 insertions(+)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -645,6 +645,7 @@ enum intel_sbi_destination {#define QUIRK_BACKLIGHT_PRESENT (1<<3)#define QUIRK_PIN_SWIZZLED_PAGES (1<<5)#define QUIRK_INCREASE_T12_DELAY (1<<6) +#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)struct intel_fbdev ;struct intel_fbc_work ;
drivers/gpu/drm/i915/intel_ddi.c +8 -0
@@ -1784,6 +1784,9 @@ void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state)I915_WRITE (TRANS_DDI_FUNC_CTL (cpu_transcoder), temp); } +/* Quirk time computed based on 24fps frame time of 41.25ms */ +#define DDI_DISABLED_QUIRK_TIME 42 +void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv,enum transcoder cpu_transcoder) {
@@ -1793,6 +1796,11 @@ void intel_ddi_disable_transcoder_func(struct drm_i915_private *dev_priv, val &= ~(TRANS_DDI_FUNC_ENABLE |TRANS_DDI_PORT_MASK |TRANS_DDI_DP_VC_PAYLOAD_ALLOC ); val |=TRANS_DDI_PORT_NONE ;I915_WRITE (reg, val); + +if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME ) { +msleep (DDI_DISABLED_QUIRK_TIME ); +DRM_DEBUG_KMS ("Quirk Increase DDI disabled time\n" ); + } } int intel_ddi_toggle_hdcp_signalling(struct intel_encoder *intel_encoder,
drivers/gpu/drm/i915/intel_display.c +14 -0
@@ -14740,6 +14740,17 @@ static void quirk_increase_t12_delay(struct drm_device *dev)DRM_INFO ("Applying T12 delay quirk\n" ); } +/* GeminiLake NUC HDMI outputs require additional off time +* this allows the onboard retimer to correctly sync to signal +*/ +static void quirk_increase_ddi_disabled_time (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); + + dev_priv->quirks |=QUIRK_INCREASE_DDI_DISABLED_TIME ; +DRM_INFO ("Applying Increase DDI Disabled quirk\n" ); +} +struct intel_quirk {int device;int subsystem_vendor;
@@ -14826,6 +14837,9 @@ static int intel_dmi_reverse_brightness(const struct dmi_system_id *id)/* Toshiba Satellite P50-C-18C */ { 0x191B, 0x1179, 0xF840, quirk_increase_t12_delay }, + +/* GeminiLake NUC */ + { 0x3185, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, };static void intel_init_quirks (struct drm_device *dev)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
URL : https://patchwork.freedesktop.org/series/44446/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
60f585b542bc drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
-:28: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#28: FILE: drivers/gpu/drm/i915/i915_drv.h:648:
+#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)
^total: 0 errors, 0 warnings, 1 checks, 53 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.SPARSE: warning for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
URL : https://patchwork.freedesktop.org/series/44446/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Commit: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. -drivers/gpu/drm/i915/selftests/../i915_drv.h:3669:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/selftests/../i915_drv.h:3670:16: warning: expression using sizeof(void)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
URL : https://patchwork.freedesktop.org/series/44446/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4291 -> Patchwork_9237 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9237 need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_9237, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/44446/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9237:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_gttfill@basic:
fi-pnv-d510: SKIP -> PASS== Known issues ==
Here are the changes found in Patchwork_9237 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload-inject:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106248, fdo#106725)
igt@gem_sync@basic-many-each:
fi-cnl-y3: PASS -> INCOMPLETE (fdo#105086)
igt@kms_flip@basic-flip-vs-dpms:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106000)
==== Possible fixes ====
igt@gem_ctx_switch@basic-default-heavy:
fi-glk-j4005: DMESG-WARN (fdo#106000) -> PASS +1
igt@gem_exec_flush@basic-uc-set-default:
fi-glk-j4005: DMESG-WARN (fdo#105719) -> PASS
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: DMESG-WARN (fdo#105128) -> PASS fdo#105086 https://bugs.freedesktop.org/show_bug.cgi?id=105086
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
== Participating hosts (39 -> 36) ==
Missing (3): fi-ilk-m540 fi-byt-squawks fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4291 -> Patchwork_9237
CI_DRM_4291: 1d2b97e15aaf8a354a58904dc6c4ca7366f78ed1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4510: d1a93aa7e1507de76c6c71be15931cc4b90111bb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9237: 60f585b542bcaa77ca0a7356de85a174bad33d6e @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
60f585b542bc drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9237/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
URL : https://patchwork.freedesktop.org/series/44446/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4291_full -> Patchwork_9237_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9237_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_9237_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9237_full:
=== IGT changes ===
==== Warnings ====
igt@gem_mocs_settings@mocs-rc6-dirty-render:
shard-kbl: SKIP -> PASS== Known issues ==
Here are the changes found in Patchwork_9237_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_gtt:
shard-kbl: PASS -> FAIL (fdo#105347)
shard-apl: PASS -> INCOMPLETE (fdo#103927)
igt@gem_exec_big:
shard-hsw: PASS -> INCOMPLETE (fdo#103540)
igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
shard-glk: PASS -> INCOMPLETE (fdo#103359, k.org#198133) +1
igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
shard-glk: PASS -> FAIL (fdo#105454, fdo#106509)
igt@kms_cursor_legacy@cursor-vs-flip-toggle:
shard-hsw: PASS -> FAIL (fdo#103355)
igt@kms_flip@plain-flip-fb-recreate:
shard-hsw: PASS -> FAIL (fdo#103928)
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@gem_eio@hibernate:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
shard-glk: FAIL (fdo#105703) -> PASS
igt@kms_flip@flip-vs-expired-vblank:
shard-glk: FAIL (fdo#105363) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-apl: FAIL (fdo#102887, fdo#105363) -> PASS
igt@kms_flip@modeset-vs-vblank-race-interruptible:
shard-hsw: FAIL (fdo#103060) -> PASS
igt@kms_flip@plain-flip-ts-check-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS
igt@kms_flip_tiling@flip-to-x-tiled:
shard-glk: FAIL (fdo#103822, fdo#104724) -> PASS
igt@kms_setmode@basic:
shard-hsw: FAIL (fdo#99912) -> PASS
igt@kms_vblank@pipe-c-ts-continuation-modeset:
shard-glk: DMESG-WARN (fdo#106247) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
fdo#106247 https://bugs.freedesktop.org/show_bug.cgi?id=106247
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4291 -> Patchwork_9237
CI_DRM_4291: 1d2b97e15aaf8a354a58904dc6c4ca7366f78ed1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4510: d1a93aa7e1507de76c6c71be15931cc4b90111bb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9237: 60f585b542bcaa77ca0a7356de85a174bad33d6e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9237/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi Clint,
nice debugging!
Quoted 11 lines · On Thu, Jun 07, 2018 at 04:12:39PM -0700, [email protected] wrote:
From: Clint Taylor <[email protected]>
On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal.
When measured on a scope the highspeed lines of the HDMI clock turn off for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC appears to require at least a full frame of quiet time before a new faster clock can be correctly sync'd.
The worst case scenario appears to be 23.98Hz modes which requires a wait of 41.25ms. Add a quirk to the driver for GLK NUC that waits 42ms.
Just to understand better the failure mode: IIUC without the WA the HDMI clock line is inactive for ~400us when switching modes (which would depend on kernel timing) and the retimer chip needs at least 42ms idle time at least when switching to certain modes.
Is there a way to recover the chip from the bad state? By doing a new off/on modeset with enough idle time, or resetting the chip?
--Imre
Quoted 83 lines
Cc: Imre Deak <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105887Signed-off-by Clint Taylor <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 8 ++++++++ drivers/gpu/drm/i915/intel_display.c | 14 ++++++++++++++ 3 files changed, 23 insertions(+)drivers/gpu/drm/i915/i915_drv.h +1
-0@@ -645,6 +645,7 @@ enum intel_sbi_destination {#define QUIRK_BACKLIGHT_PRESENT (1<<3)#define QUIRK_PIN_SWIZZLED_PAGES (1<<5)#define QUIRK_INCREASE_T12_DELAY (1<<6) +#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)struct intel_fbdev ;struct intel_fbc_work ;drivers/gpu/drm/i915/intel_ddi.c +8
-0@@ -1784,6 +1784,9 @@ void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state)I915_WRITE (TRANS_DDI_FUNC_CTL (cpu_transcoder), temp); } +/* Quirk time computed based on 24fps frame time of 41.25ms */ +#define DDI_DISABLED_QUIRK_TIME 42 +void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv,enum transcoder cpu_transcoder) {@@ -1793,6 +1796,11 @@ void intel_ddi_disable_transcoder_func(struct drm_i915_private *dev_priv, val &= ~(TRANS_DDI_FUNC_ENABLE |TRANS_DDI_PORT_MASK |TRANS_DDI_DP_VC_PAYLOAD_ALLOC ); val |=TRANS_DDI_PORT_NONE ;I915_WRITE (reg, val); + +if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME ) { +msleep (DDI_DISABLED_QUIRK_TIME ); +DRM_DEBUG_KMS ("Quirk Increase DDI disabled time\n" ); + } } int intel_ddi_toggle_hdcp_signalling(struct intel_encoder *intel_encoder,drivers/gpu/drm/i915/intel_display.c +14
-0@@ -14740,6 +14740,17 @@ static void quirk_increase_t12_delay(struct drm_device *dev)DRM_INFO ("Applying T12 delay quirk\n" ); } +/* GeminiLake NUC HDMI outputs require additional off time +* this allows the onboard retimer to correctly sync to signal +*/ +static void quirk_increase_ddi_disabled_time (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); + + dev_priv->quirks |=QUIRK_INCREASE_DDI_DISABLED_TIME ; +DRM_INFO ("Applying Increase DDI Disabled quirk\n" ); +} +struct intel_quirk {int device;int subsystem_vendor;@@ -14826,6 +14837,9 @@ static int intel_dmi_reverse_brightness(const struct dmi_system_id *id)/* Toshiba Satellite P50-C-18C */ { 0x191B, 0x1179, 0xF840, quirk_increase_t12_delay }, + +/* GeminiLake NUC */ + { 0x3185, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, };static void intel_init_quirks (struct drm_device *dev)Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 16 lines · Imre Deak
Hi Clint,
nice debugging!
Quoted 11 lines · On Thu, Jun 07, 2018 at 04:12:39PM -0700, [email protected] wrote:
From: Clint Taylor <[email protected]>
On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal.
When measured on a scope the highspeed lines of the HDMI clock turn off for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC appears to require at least a full frame of quiet time before a new faster clock can be correctly sync'd.
The worst case scenario appears to be 23.98Hz modes which requires a wait of 41.25ms. Add a quirk to the driver for GLK NUC that waits 42ms.
Quoted 4 lines
Just to understand better the failure mode: IIUC without the WA the HDMI clock line is inactive for ~400us when switching modes (which would depend on kernel timing) and the retimer chip needs at least 42ms idle time at least when switching to certain modes.
If switching from 30Hz to 50/60Hz you would only need a delay of 34ms, but I chose to keep the quirk simple and use the worst case (23.98Hz) delay of 42ms.
Quoted 3 lines
Is there a way to recover the chip from the bad state? By doing a new off/on modeset with enough idle time, or resetting the chip?
Just an off/on mode set with enough delay will bring the chip out of the bad state.
-Clint
Quoted 81 lines
--Imre
Quoted 78 lines
Cc: Imre Deak <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105887Signed-off-by Clint Taylor <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 8 ++++++++ drivers/gpu/drm/i915/intel_display.c | 14 ++++++++++++++ 3 files changed, 23 insertions(+)drivers/gpu/drm/i915/i915_drv.h +1
-0@@ -645,6 +645,7 @@ enum intel_sbi_destination {#define QUIRK_BACKLIGHT_PRESENT (1<<3)#define QUIRK_PIN_SWIZZLED_PAGES (1<<5)#define QUIRK_INCREASE_T12_DELAY (1<<6) +#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)struct intel_fbdev ;struct intel_fbc_work ;drivers/gpu/drm/i915/intel_ddi.c +8
-0@@ -1784,6 +1784,9 @@ void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state)I915_WRITE (TRANS_DDI_FUNC_CTL (cpu_transcoder), temp); } +/* Quirk time computed based on 24fps frame time of 41.25ms */ +#define DDI_DISABLED_QUIRK_TIME 42 +void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv,enum transcoder cpu_transcoder) {@@ -1793,6 +1796,11 @@ void intel_ddi_disable_transcoder_func(struct drm_i915_private *dev_priv, val &= ~(TRANS_DDI_FUNC_ENABLE |TRANS_DDI_PORT_MASK |TRANS_DDI_DP_VC_PAYLOAD_ALLOC ); val |=TRANS_DDI_PORT_NONE ;I915_WRITE (reg, val); + +if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME ) { +msleep (DDI_DISABLED_QUIRK_TIME ); +DRM_DEBUG_KMS ("Quirk Increase DDI disabled time\n" ); + } } int intel_ddi_toggle_hdcp_signalling(struct intel_encoder *intel_encoder,drivers/gpu/drm/i915/intel_display.c +14
-0@@ -14740,6 +14740,17 @@ static void quirk_increase_t12_delay(struct drm_device *dev)DRM_INFO ("Applying T12 delay quirk\n" ); } +/* GeminiLake NUC HDMI outputs require additional off time +* this allows the onboard retimer to correctly sync to signal +*/ +static void quirk_increase_ddi_disabled_time (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); + + dev_priv->quirks |=QUIRK_INCREASE_DDI_DISABLED_TIME ; +DRM_INFO ("Applying Increase DDI Disabled quirk\n" ); +} +struct intel_quirk {int device;int subsystem_vendor;@@ -14826,6 +14837,9 @@ static int intel_dmi_reverse_brightness(const struct dmi_system_id *id)/* Toshiba Satellite P50-C-18C */ { 0x191B, 0x1179, 0xF840, quirk_increase_t12_delay }, + +/* GeminiLake NUC */ + { 0x3185, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, };
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/i915/intel_display.c +0
-0static void intel_init_quirks (struct drm_device *dev)Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 1/1 drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
In reply to [email protected]From: Clint Taylor <[email protected]>
On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal.
When measured on a scope the highspeed lines of the HDMI clock turn off
for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC appears to require at least a full frame of quiet time before a
new faster clock can be correctly sync'd. The worst case scenario appears to be 23.98Hz modes which requires a wait of 41.25ms. Add a quirk to the driver for GLK NUC that waits 42ms.
V2: Add more devices to the quirk list
Cc: Imre Deak <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105887
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 8 ++++++++ drivers/gpu/drm/i915/intel_display.c | 19 +++++++++++++++++++ 3 files changed, 28 insertions(+)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -656,6 +656,7 @@ enum intel_sbi_destination {#define QUIRK_BACKLIGHT_PRESENT (1<<3)#define QUIRK_PIN_SWIZZLED_PAGES (1<<5)#define QUIRK_INCREASE_T12_DELAY (1<<6) +#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)struct intel_fbdev ;struct intel_fbc_work ;
drivers/gpu/drm/i915/intel_ddi.c +8 -0
@@ -1791,6 +1791,9 @@ void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state)I915_WRITE (TRANS_DDI_FUNC_CTL (cpu_transcoder), temp); } +/* Quirk time computed based on 24fps frame time of 41.25ms */ +#define DDI_DISABLED_QUIRK_TIME 42 +void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv,enum transcoder cpu_transcoder) {
@@ -1800,6 +1803,11 @@ void intel_ddi_disable_transcoder_func(struct drm_i915_private *dev_priv, val &= ~(TRANS_DDI_FUNC_ENABLE |TRANS_DDI_PORT_MASK |TRANS_DDI_DP_VC_PAYLOAD_ALLOC ); val |=TRANS_DDI_PORT_NONE ;I915_WRITE (reg, val); + +if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME ) { +msleep (DDI_DISABLED_QUIRK_TIME ); +DRM_DEBUG_KMS ("Quirk Increase DDI disabled time\n" ); + } } int intel_ddi_toggle_hdcp_signalling(struct intel_encoder *intel_encoder,
drivers/gpu/drm/i915/intel_display.c +19 -0
@@ -14749,6 +14749,17 @@ static void quirk_increase_t12_delay(struct drm_device *dev)DRM_INFO ("Applying T12 delay quirk\n" ); } +/* GeminiLake NUC HDMI outputs require additional off time +* this allows the onboard retimer to correctly sync to signal +*/ +static void quirk_increase_ddi_disabled_time (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); + + dev_priv->quirks |=QUIRK_INCREASE_DDI_DISABLED_TIME ; +DRM_INFO ("Applying Increase DDI Disabled quirk\n" ); +} +struct intel_quirk {int device;int subsystem_vendor;
@@ -14835,6 +14846,14 @@ static int intel_dmi_reverse_brightness(const struct dmi_system_id *id)/* Toshiba Satellite P50-C-18C */ { 0x191B, 0x1179, 0xF840, quirk_increase_t12_delay }, + +/* GeminiLake NUC */ + { 0x3185, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, +/* ASRock ITX*/ + { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, + };static void intel_init_quirks (struct drm_device *dev)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Am Wed, 13 Jun 2018 14:48:49 -0700
schrieb [email protected]:
Quoted 12 lines
From: Clint Taylor <[email protected]>
On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal.
When measured on a scope the highspeed lines of the HDMI clock turn off
for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC appears to require at least a full frame of quiet time before a
new faster clock can be correctly sync'd. The worst case scenario appears to be 23.98Hz modes which requires a wait of 41.25ms. Add a quirk to the driver for GLK NUC that waits 42ms.
Quoted 5 lines
V2: Add more devices to the quirk list
Cc: Imre Deak <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105887Signed-off-by Clint Taylor <[email protected]>
on an ASRock J5005-ITX with a 0x3184 GLK GPU for the last five days, HDMI signal issues when the pixel clock goes up are gone.
Quoted 71 lines
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 8 ++++++++ drivers/gpu/drm/i915/intel_display.c | 19 +++++++++++++++++++ 3 files changed, 28 insertions(+)drivers/gpu/drm/i915/i915_drv.h +1
-0@@ -656,6 +656,7 @@ enum intel_sbi_destination {#define QUIRK_BACKLIGHT_PRESENT (1<<3)#define QUIRK_PIN_SWIZZLED_PAGES (1<<5)#define QUIRK_INCREASE_T12_DELAY (1<<6) +#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)struct intel_fbdev ;struct intel_fbc_work ;drivers/gpu/drm/i915/intel_ddi.c +8
-0@@ -1791,6 +1791,9 @@ void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state)I915_WRITE (TRANS_DDI_FUNC_CTL (cpu_transcoder), temp); } +/* Quirk time computed based on 24fps frame time of 41.25ms */ +#define DDI_DISABLED_QUIRK_TIME 42 +void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv,enum transcoder cpu_transcoder) {@@ -1800,6 +1803,11 @@ void intel_ddi_disable_transcoder_func(struct drm_i915_private *dev_priv, val &= ~(TRANS_DDI_FUNC_ENABLE |TRANS_DDI_PORT_MASK |TRANS_DDI_DP_VC_PAYLOAD_ALLOC ); val |=TRANS_DDI_PORT_NONE ;I915_WRITE (reg, val); + +if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME ) { +msleep (DDI_DISABLED_QUIRK_TIME ); +DRM_DEBUG_KMS ("Quirk Increase DDI disabled time\n" ); + } } int intel_ddi_toggle_hdcp_signalling(struct intel_encoder *intel_encoder,drivers/gpu/drm/i915/intel_display.c +12
-0@@ -14749,6 +14749,17 @@ static void quirk_increase_t12_delay(struct drm_device *dev)DRM_INFO ("Applying T12 delay quirk\n" ); } +/* GeminiLake NUC HDMI outputs require additional off time +* this allows the onboard retimer to correctly sync to signal +*/ +static void quirk_increase_ddi_disabled_time (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); + + dev_priv->quirks |=QUIRK_INCREASE_DDI_DISABLED_TIME ; +DRM_INFO ("Applying Increase DDI Disabled quirk\n" ); +} +struct intel_quirk {int device;int subsystem_vendor;@@ -14835,6 +14846,14 @@ static int intel_dmi_reverse_brightness(const struct dmi_system_id *id)/* Toshiba Satellite P50-C-18C */ { 0x191B, 0x1179, 0xF840, quirk_increase_t12_delay }, +
drivers/gpu/drm/i915/intel_display.c static int intel_dmi_reverse_brightness(const struct dmi_system_id *id) · line 14859
Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +7
-0+/* GeminiLake NUC */ + { 0x3185, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, +/* ASRock ITX*/ + { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, + };static void intel_init_quirks (struct drm_device *dev)
Best regards,
Daniel Scheller
Signature · 5 lines
https://github.com/herrnst _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 50 lines · On Wed, Jun 13, 2018 at 02:48:49PM -0700, [email protected] wrote:
From: Clint Taylor <[email protected]>
On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal.
When measured on a scope the highspeed lines of the HDMI clock turn off
for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC appears to require at least a full frame of quiet time before a
new faster clock can be correctly sync'd. The worst case scenario appears to be 23.98Hz modes which requires a wait of 41.25ms. Add a quirk to the driver for GLK NUC that waits 42ms.V2: Add more devices to the quirk list
Cc: Imre Deak <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105887Signed-off-by Clint Taylor <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 8 ++++++++ drivers/gpu/drm/i915/intel_display.c | 19 +++++++++++++++++++ 3 files changed, 28 insertions(+)drivers/gpu/drm/i915/i915_drv.h +1
-0@@ -656,6 +656,7 @@ enum intel_sbi_destination {#define QUIRK_BACKLIGHT_PRESENT (1<<3)#define QUIRK_PIN_SWIZZLED_PAGES (1<<5)#define QUIRK_INCREASE_T12_DELAY (1<<6) +#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)struct intel_fbdev ;struct intel_fbc_work ;drivers/gpu/drm/i915/intel_ddi.c +3
-0@@ -1791,6 +1791,9 @@ void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state)I915_WRITE (TRANS_DDI_FUNC_CTL (cpu_transcoder), temp); } +/* Quirk time computed based on 24fps frame time of 41.25ms */ +#define DDI_DISABLED_QUIRK_TIME 42 +void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv,enum transcoder cpu_transcoder) {
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_disable_transcoder_func(struct drm_i915_private *dev_priv, · line 1809
Quoted 7 lines
drivers/gpu/drm/i915/intel_ddi.c +4
-0@@ -1800,6 +1803,11 @@ void intel_ddi_disable_transcoder_func(struct drm_i915_private *dev_priv, val &= ~(TRANS_DDI_FUNC_ENABLE |TRANS_DDI_PORT_MASK |TRANS_DDI_DP_VC_PAYLOAD_ALLOC ); val |=TRANS_DDI_PORT_NONE ;I915_WRITE (reg, val); + +if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME ) { +msleep (DDI_DISABLED_QUIRK_TIME ); +DRM_DEBUG_KMS ("Quirk Increase DDI disabled time\n" );
No need for the define or the debug message here imo. msleep() can be inaccurate (even sleeping less than expected), so I'd use a bigger margin, sleeping say 100ms.
If the problem is with the HDMI retimer chip, we should limit the quirk to HDMI outputs.
Quoted 28 lines
drivers/gpu/drm/i915/intel_ddi.c +1
-0+ } } int intel_ddi_toggle_hdcp_signalling(struct intel_encoder *intel_encoder,drivers/gpu/drm/i915/intel_display.c +11
-0@@ -14749,6 +14749,17 @@ static void quirk_increase_t12_delay(struct drm_device *dev)DRM_INFO ("Applying T12 delay quirk\n" ); } +/* GeminiLake NUC HDMI outputs require additional off time +* this allows the onboard retimer to correctly sync to signal +*/ +static void quirk_increase_ddi_disabled_time (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); + + dev_priv->quirks |=QUIRK_INCREASE_DDI_DISABLED_TIME ; +DRM_INFO ("Applying Increase DDI Disabled quirk\n" ); +} +struct intel_quirk {int device;int subsystem_vendor;@@ -14835,6 +14846,14 @@ static int intel_dmi_reverse_brightness(const struct dmi_system_id *id)
drivers/gpu/drm/i915/intel_display.c static int intel_dmi_reverse_brightness(const struct dmi_system_id *id) · line 14856
Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +8
-0/* Toshiba Satellite P50-C-18C */ { 0x191B, 0x1179, 0xF840, quirk_increase_t12_delay }, + +/* GeminiLake NUC */ + { 0x3185, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, +/* ASRock ITX*/ + { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, +
Extra w/s. A quirk list looks ok for now since we can't identify the retimer chip in any other way.
Quoted 6 lines
drivers/gpu/drm/i915/intel_display.c +0
-0};static void intel_init_quirks (struct drm_device *dev)Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 53 lines · Imre Deak
Quoted 52 lines · On Wed, Jun 13, 2018 at 02:48:49PM -0700, [email protected] wrote:
From: Clint Taylor <[email protected]>
On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal.
When measured on a scope the highspeed lines of the HDMI clock turn off
for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC appears to require at least a full frame of quiet time before a
new faster clock can be correctly sync'd. The worst case scenario appears to be 23.98Hz modes which requires a wait of 41.25ms. Add a quirk to the driver for GLK NUC that waits 42ms.V2: Add more devices to the quirk list
Cc: Imre Deak <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105887Signed-off-by Clint Taylor <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 8 ++++++++ drivers/gpu/drm/i915/intel_display.c | 19 +++++++++++++++++++ 3 files changed, 28 insertions(+)drivers/gpu/drm/i915/i915_drv.h +1
-0@@ -656,6 +656,7 @@ enum intel_sbi_destination {#define QUIRK_BACKLIGHT_PRESENT (1<<3)#define QUIRK_PIN_SWIZZLED_PAGES (1<<5)#define QUIRK_INCREASE_T12_DELAY (1<<6) +#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)struct intel_fbdev ;struct intel_fbc_work ;drivers/gpu/drm/i915/intel_ddi.c +3
-0@@ -1791,6 +1791,9 @@ void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state)I915_WRITE (TRANS_DDI_FUNC_CTL (cpu_transcoder), temp); } +/* Quirk time computed based on 24fps frame time of 41.25ms */ +#define DDI_DISABLED_QUIRK_TIME 42 +void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv,enum transcoder cpu_transcoder) {@@ -1800,6 +1803,11 @@ void intel_ddi_disable_transcoder_func(struct drm_i915_private *dev_priv, val &= ~(TRANS_DDI_FUNC_ENABLE |TRANS_DDI_PORT_MASK |TRANS_DDI_DP_VC_PAYLOAD_ALLOC ); val |=TRANS_DDI_PORT_NONE ;
Quoted 8 lines
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_disable_transcoder_func(struct drm_i915_private *dev_priv, · line 1809
Quoted 5 lines
drivers/gpu/drm/i915/intel_ddi.c +4
-0I915_WRITE (reg, val); + +if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME ) { +msleep (DDI_DISABLED_QUIRK_TIME ); +DRM_DEBUG_KMS ("Quirk Increase DDI disabled time\n" );No need for the define or the debug message here imo.
msleep()can be inaccurate (even sleeping less than expected), so I'd use a bigger margin, sleeping say 100ms.
Easy to do and I can submit v3.
Quoted 3 lines
If the problem is with the HDMI retimer chip, we should limit the quirk to HDMI outputs.
Output type is not available in intel_disable_ddi() and I would prefer not to change the interface only for the quirk. I could move the quirk execution up a level to haswell_crtc_disable() and detect the old_crtc_state->type before executing the quirk. However, the quirk is only being detected for certain boards that only have HDMI outputs. Unless more boards are added to the quirk_list[] we really don't need logic to detect HDMI outputs.
-Clint
Quoted 28 lines
Quoted 28 lines
drivers/gpu/drm/i915/intel_ddi.c +1
-0+ } } int intel_ddi_toggle_hdcp_signalling(struct intel_encoder *intel_encoder,drivers/gpu/drm/i915/intel_display.c +11
-0@@ -14749,6 +14749,17 @@ static void quirk_increase_t12_delay(struct drm_device *dev)DRM_INFO ("Applying T12 delay quirk\n" ); } +/* GeminiLake NUC HDMI outputs require additional off time +* this allows the onboard retimer to correctly sync to signal +*/ +static void quirk_increase_ddi_disabled_time (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); + + dev_priv->quirks |=QUIRK_INCREASE_DDI_DISABLED_TIME ; +DRM_INFO ("Applying Increase DDI Disabled quirk\n" ); +} +struct intel_quirk {int device;int subsystem_vendor;@@ -14835,6 +14846,14 @@ static int intel_dmi_reverse_brightness(const struct dmi_system_id *id)
Quoted 19 lines
drivers/gpu/drm/i915/intel_display.c static int intel_dmi_reverse_brightness(const struct dmi_system_id *id) · line 14856
Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +8
-0/* Toshiba Satellite P50-C-18C */ { 0x191B, 0x1179, 0xF840, quirk_increase_t12_delay }, + +/* GeminiLake NUC */ + { 0x3185, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, +/* ASRock ITX*/ + { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, +Extra w/s. A quirk list looks ok for now since we can't identify the retimer chip in any other way.
Quoted 6 lines
drivers/gpu/drm/i915/intel_display.c +0
-0};static void intel_init_quirks (struct drm_device *dev)Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 66 lines · Clint Taylor
Quoted 51 lines · Imre Deak
Quoted 50 lines · On Wed, Jun 13, 2018 at 02:48:49PM -0700, [email protected] wrote:
From: Clint Taylor <[email protected]>
On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal.
When measured on a scope the highspeed lines of the HDMI clock turn off
for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC appears to require at least a full frame of quiet time before a
new faster clock can be correctly sync'd. The worst case scenario appears to be 23.98Hz modes which requires a wait of 41.25ms. Add a quirk to the driver for GLK NUC that waits 42ms.V2: Add more devices to the quirk list
Cc: Imre Deak <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105887Signed-off-by Clint Taylor <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 8 ++++++++ drivers/gpu/drm/i915/intel_display.c | 19 +++++++++++++++++++ 3 files changed, 28 insertions(+)drivers/gpu/drm/i915/i915_drv.h +1
-0@@ -656,6 +656,7 @@ enum intel_sbi_destination {#define QUIRK_BACKLIGHT_PRESENT (1<<3)#define QUIRK_PIN_SWIZZLED_PAGES (1<<5)#define QUIRK_INCREASE_T12_DELAY (1<<6) +#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)struct intel_fbdev ;struct intel_fbc_work ;drivers/gpu/drm/i915/intel_ddi.c +3
-0@@ -1791,6 +1791,9 @@ void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state)I915_WRITE (TRANS_DDI_FUNC_CTL (cpu_transcoder), temp); } +/* Quirk time computed based on 24fps frame time of 41.25ms */ +#define DDI_DISABLED_QUIRK_TIME 42 +void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv,enum transcoder cpu_transcoder) {@@ -1800,6 +1803,11 @@ void intel_ddi_disable_transcoder_func(struct drm_i915_private *dev_priv, val &= ~(TRANS_DDI_FUNC_ENABLE |TRANS_DDI_PORT_MASK |TRANS_DDI_DP_VC_PAYLOAD_ALLOC ); val |=TRANS_DDI_PORT_NONE ;Quoted 8 lines
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_disable_transcoder_func(struct drm_i915_private *dev_priv, · line 1809
Quoted 5 lines
drivers/gpu/drm/i915/intel_ddi.c +4
-0I915_WRITE (reg, val); + +if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME ) { +msleep (DDI_DISABLED_QUIRK_TIME ); +DRM_DEBUG_KMS ("Quirk Increase DDI disabled time\n" );No need for the define or the debug message here imo.
msleep()can be inaccurate (even sleeping less than expected), so I'd use a bigger margin, sleeping say 100ms.Easy to do and I can submit v3.
Quoted 1 line
Quoted 8 lines
Quoted 2 lines
If the problem is with the HDMI retimer chip, we should limit the quirk to HDMI outputs.
Output type is not available in
intel_disable_ddi()and I would prefer not to change the interface only for the quirk. I could move the quirk execution up a level tohaswell_crtc_disable()and detect theold_crtc_state->typebefore executing the quirk. However, the quirk is only being detected for certain boards that only have HDMI outputs. Unless more boards are added to the quirk_list[] we really don't need logic to detect HDMI outputs.
Ok, but I'm sure we'll forget about this detail once we have to update the list with a GLK having a DP output too. OTOH, changing intel_ddi_disable_transcoder_func() to accept
struct intel_crtc_state *crtc_state would make it symmetric with intel_ddi_enable_transcoder_func(), so imo a good change on its own.
--Imre
Quoted 47 lines
-Clint
Quoted 43 lines
Quoted 25 lines
drivers/gpu/drm/i915/intel_ddi.c +1
-0+ } } int intel_ddi_toggle_hdcp_signalling(struct intel_encoder *intel_encoder,drivers/gpu/drm/i915/intel_display.c +11
-0@@ -14749,6 +14749,17 @@ static void quirk_increase_t12_delay(struct drm_device *dev)DRM_INFO ("Applying T12 delay quirk\n" ); } +/* GeminiLake NUC HDMI outputs require additional off time +* this allows the onboard retimer to correctly sync to signal +*/ +static void quirk_increase_ddi_disabled_time (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); + + dev_priv->quirks |=QUIRK_INCREASE_DDI_DISABLED_TIME ; +DRM_INFO ("Applying Increase DDI Disabled quirk\n" ); +} +struct intel_quirk {int device;int subsystem_vendor;drivers/gpu/drm/i915/intel_display.c static int intel_dmi_reverse_brightness(const struct dmi_system_id *id) · line 14855
Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +8
-0@@ -14835,6 +14846,14 @@ static int intel_dmi_reverse_brightness(const struct dmi_system_id *id)/* Toshiba Satellite P50-C-18C */ { 0x191B, 0x1179, 0xF840, quirk_increase_t12_delay }, + +/* GeminiLake NUC */ + { 0x3185, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, +/* ASRock ITX*/ + { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, +Extra w/s. A quirk list looks ok for now since we can't identify the retimer chip in any other way.
Quoted 5 lines
drivers/gpu/drm/i915/intel_display.c +0
-0};static void intel_init_quirks (struct drm_device *dev)Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v3 1/1 drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
From: Clint Taylor <[email protected]>
On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal.
When measured on a scope the highspeed lines of the HDMI clock turn off
for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC appears to require at least a full frame of quiet time before a
new faster clock can be correctly sync'd. Wait 100ms due to msleep inaccuracies while waiting for a completed frame. Add a quirk to the driver for GLK boards that use ITE66317 HDMI retimers.
V2: Add more devices to the quirk list
V3: Delay increased to 100ms, check to confirm crtc type is HDMI.
Cc: Imre Deak <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105887
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 16 ++++++++++++++-- drivers/gpu/drm/i915/intel_display.c | 21 ++++++++++++++++++++- drivers/gpu/drm/i915/intel_drv.h | 3 +-- 4 files changed, 36 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -655,6 +655,7 @@ enum intel_sbi_destination {#define QUIRK_BACKLIGHT_PRESENT (1<<3)#define QUIRK_PIN_SWIZZLED_PAGES (1<<5)#define QUIRK_INCREASE_T12_DELAY (1<<6) +#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)struct intel_fbdev ;struct intel_fbc_work ;
drivers/gpu/drm/i915/intel_ddi.c +14 -2
@@ -1807,15 +1807,27 @@ void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state)I915_WRITE (TRANS_DDI_FUNC_CTL (cpu_transcoder), temp); } -void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv, -enum transcoder cpu_transcoder) +/* Quirk time at 100ms for reliable operation */ +#define DDI_DISABLED_QUIRK_TIME 100 + +void intel_ddi_disable_transcoder_func (const struct intel_crtc_state *crtc_state) { +struct intel_crtc *crtc =to_intel_crtc (crtc_state->base.crtc); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; +i915_reg_t reg =TRANS_DDI_FUNC_CTL (cpu_transcoder);uint32_t val =I915_READ (reg); val &= ~(TRANS_DDI_FUNC_ENABLE |TRANS_DDI_PORT_MASK |TRANS_DDI_DP_VC_PAYLOAD_ALLOC ); val |=TRANS_DDI_PORT_NONE ;I915_WRITE (reg, val); + +if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME && +intel_crtc_has_type (crtc_state,INTEL_OUTPUT_HDMI )) { +msleep (DDI_DISABLED_QUIRK_TIME ); +DRM_DEBUG_KMS ("Quirk Increase DDI disabled time\n" ); + } } int intel_ddi_toggle_hdcp_signalling(struct intel_encoder *intel_encoder,
drivers/gpu/drm/i915/intel_display.c +20 -1
@@ -5837,7 +5837,7 @@ static void haswell_crtc_disable(struct intel_crtc_state *old_crtc_state,intel_ddi_set_vc_payload_alloc (old_crtc_state, false);if (!transcoder_is_dsi (cpu_transcoder)) -intel_ddi_disable_transcoder_func (dev_priv, cpu_transcoder); +intel_ddi_disable_transcoder_func (old_crtc_state);if (INTEL_GEN (dev_priv) >=9 )skylake_scaler_disable (intel_crtc);
@@ -14852,6 +14852,17 @@ static void quirk_increase_t12_delay(struct drm_device *dev)DRM_INFO ("Applying T12 delay quirk\n" ); } +/* GeminiLake NUC HDMI outputs require additional off time +* this allows the onboard retimer to correctly sync to signal +*/ +static void quirk_increase_ddi_disabled_time (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); + + dev_priv->quirks |=QUIRK_INCREASE_DDI_DISABLED_TIME ; +DRM_INFO ("Applying Increase DDI Disabled quirk\n" ); +} +struct intel_quirk {int device;int subsystem_vendor;
@@ -14938,6 +14949,14 @@ static int intel_dmi_reverse_brightness(const struct dmi_system_id *id)/* Toshiba Satellite P50-C-18C */ { 0x191B, 0x1179, 0xF840, quirk_increase_t12_delay }, + +/* GeminiLake NUC */ + { 0x3185, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, +/* ASRock ITX*/ + { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, + };static void intel_init_quirks (struct drm_device *dev)
drivers/gpu/drm/i915/intel_drv.h +1 -2
@@ -1384,8 +1384,7 @@ void hsw_fdi_link_train(struct intel_crtc *crtc,void intel_ddi_init (struct drm_i915_private *dev_priv,enum port port);bool intel_ddi_get_hw_state (struct intel_encoder *encoder,enum pipe *pipe);void intel_ddi_enable_transcoder_func (const struct intel_crtc_state *crtc_state); -void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv, -enum transcoder cpu_transcoder); +void intel_ddi_disable_transcoder_func (const struct intel_crtc_state *crtc_state);void intel_ddi_enable_pipe_clock (const struct intel_crtc_state *crtc_state);void intel_ddi_disable_pipe_clock (const struct intel_crtc_state *crtc_state);void intel_ddi_set_pipe_settings (const struct intel_crtc_state *crtc_state);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 46 lines · On Thu, Jun 28, 2018 at 11:14:30AM -0700, [email protected] wrote:
From: Clint Taylor <[email protected]>
On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal.
When measured on a scope the highspeed lines of the HDMI clock turn off
for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC appears to require at least a full frame of quiet time before a
new faster clock can be correctly sync'd. Wait 100ms due to msleep inaccuracies while waiting for a completed frame. Add a quirk to the driver for GLK boards that use ITE66317 HDMI retimers.V2: Add more devices to the quirk list
V3: Delay increased to 100ms, check to confirm crtc type is HDMI.Cc: Imre Deak <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105887Signed-off-by Clint Taylor <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 16 ++++++++++++++-- drivers/gpu/drm/i915/intel_display.c | 21 ++++++++++++++++++++- drivers/gpu/drm/i915/intel_drv.h | 3 +-- 4 files changed, 36 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/i915_drv.h +1
-0@@ -655,6 +655,7 @@ enum intel_sbi_destination {#define QUIRK_BACKLIGHT_PRESENT (1<<3)#define QUIRK_PIN_SWIZZLED_PAGES (1<<5)#define QUIRK_INCREASE_T12_DELAY (1<<6) +#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)struct intel_fbdev ;struct intel_fbc_work ;drivers/gpu/drm/i915/intel_ddi.c +0
-1@@ -1807,15 +1807,27 @@ void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state)I915_WRITE (TRANS_DDI_FUNC_CTL (cpu_transcoder), temp); } -void intel_ddi_disable_transcoder_func(struct drm_i915_private *dev_priv,
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state) · line 1818
Quoted 10 lines
drivers/gpu/drm/i915/intel_ddi.c +8
-1- enum transcoder cpu_transcoder) +/* Quirk time at 100ms for reliable operation */ +#define DDI_DISABLED_QUIRK_TIME 100 + +void intel_ddi_disable_transcoder_func (const struct intel_crtc_state *crtc_state) { +struct intel_crtc *crtc =to_intel_crtc (crtc_state->base.crtc); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; +
Extra w/s.
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state) · line 1830
Quoted 12 lines
drivers/gpu/drm/i915/intel_ddi.c +6
-0i915_reg_t reg =TRANS_DDI_FUNC_CTL (cpu_transcoder);uint32_t val =I915_READ (reg); val &= ~(TRANS_DDI_FUNC_ENABLE |TRANS_DDI_PORT_MASK |TRANS_DDI_DP_VC_PAYLOAD_ALLOC ); val |=TRANS_DDI_PORT_NONE ;I915_WRITE (reg, val); + +if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME && +intel_crtc_has_type (crtc_state,INTEL_OUTPUT_HDMI )) { +msleep (DDI_DISABLED_QUIRK_TIME ); +DRM_DEBUG_KMS ("Quirk Increase DDI disabled time\n" ); + }
I still think the macro is redundant, but I'd put here your comment about the worst case mode and delay. The debug print should come before the wait.
Quoted 36 lines
drivers/gpu/drm/i915/intel_ddi.c +0
-0} int intel_ddi_toggle_hdcp_signalling(struct intel_encoder *intel_encoder,drivers/gpu/drm/i915/intel_display.c +12
-1@@ -5837,7 +5837,7 @@ static void haswell_crtc_disable(struct intel_crtc_state *old_crtc_state,intel_ddi_set_vc_payload_alloc (old_crtc_state, false);if (!transcoder_is_dsi (cpu_transcoder)) -intel_ddi_disable_transcoder_func (dev_priv, cpu_transcoder); +intel_ddi_disable_transcoder_func (old_crtc_state);if (INTEL_GEN (dev_priv) >=9 )skylake_scaler_disable (intel_crtc);@@ -14852,6 +14852,17 @@ static void quirk_increase_t12_delay(struct drm_device *dev)DRM_INFO ("Applying T12 delay quirk\n" ); } +/* GeminiLake NUC HDMI outputs require additional off time +* this allows the onboard retimer to correctly sync to signal +*/ +static void quirk_increase_ddi_disabled_time (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); + + dev_priv->quirks |=QUIRK_INCREASE_DDI_DISABLED_TIME ; +DRM_INFO ("Applying Increase DDI Disabled quirk\n" ); +} +struct intel_quirk {int device;int subsystem_vendor;@@ -14938,6 +14949,14 @@ static int intel_dmi_reverse_brightness(const struct dmi_system_id *id)
drivers/gpu/drm/i915/intel_display.c static int intel_dmi_reverse_brightness(const struct dmi_system_id *id) · line 14959
Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +8
-0/* Toshiba Satellite P50-C-18C */ { 0x191B, 0x1179, 0xF840, quirk_increase_t12_delay }, + +/* GeminiLake NUC */ + { 0x3185, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, +/* ASRock ITX*/ + { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, +
Extra w/s.
With the above fixed:
Quoted 20 lines
drivers/gpu/drm/i915/intel_display.c +0
-0};static void intel_init_quirks (struct drm_device *dev)drivers/gpu/drm/i915/intel_drv.h +1
-2@@ -1384,8 +1384,7 @@ void hsw_fdi_link_train(struct intel_crtc *crtc,void intel_ddi_init (struct drm_i915_private *dev_priv,enum port port);bool intel_ddi_get_hw_state (struct intel_encoder *encoder,enum pipe *pipe);void intel_ddi_enable_transcoder_func (const struct intel_crtc_state *crtc_state); -void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv, -enum transcoder cpu_transcoder); +void intel_ddi_disable_transcoder_func (const struct intel_crtc_state *crtc_state);void intel_ddi_enable_pipe_clock (const struct intel_crtc_state *crtc_state);void intel_ddi_disable_pipe_clock (const struct intel_crtc_state *crtc_state);void intel_ddi_set_pipe_settings (const struct intel_crtc_state *crtc_state);Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 123 lines · Imre Deak
Quoted 46 lines · On Thu, Jun 28, 2018 at 11:14:30AM -0700, [email protected] wrote:
From: Clint Taylor <[email protected]>
On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal.
When measured on a scope the highspeed lines of the HDMI clock turn off
for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC appears to require at least a full frame of quiet time before a
new faster clock can be correctly sync'd. Wait 100ms due to msleep inaccuracies while waiting for a completed frame. Add a quirk to the driver for GLK boards that use ITE66317 HDMI retimers.V2: Add more devices to the quirk list
V3: Delay increased to 100ms, check to confirm crtc type is HDMI.Cc: Imre Deak <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105887Signed-off-by Clint Taylor <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 16 ++++++++++++++-- drivers/gpu/drm/i915/intel_display.c | 21 ++++++++++++++++++++- drivers/gpu/drm/i915/intel_drv.h | 3 +-- 4 files changed, 36 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/i915_drv.h +1
-0@@ -655,6 +655,7 @@ enum intel_sbi_destination {#define QUIRK_BACKLIGHT_PRESENT (1<<3)#define QUIRK_PIN_SWIZZLED_PAGES (1<<5)#define QUIRK_INCREASE_T12_DELAY (1<<6) +#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)struct intel_fbdev ;struct intel_fbc_work ;drivers/gpu/drm/i915/intel_ddi.c +0
-1@@ -1807,15 +1807,27 @@ void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state)I915_WRITE (TRANS_DDI_FUNC_CTL (cpu_transcoder), temp); } -void intel_ddi_disable_transcoder_func(struct drm_i915_private *dev_priv,drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state) · line 1818
Quoted 10 lines
drivers/gpu/drm/i915/intel_ddi.c +8
-1- enum transcoder cpu_transcoder) +/* Quirk time at 100ms for reliable operation */ +#define DDI_DISABLED_QUIRK_TIME 100 + +void intel_ddi_disable_transcoder_func (const struct intel_crtc_state *crtc_state) { +struct intel_crtc *crtc =to_intel_crtc (crtc_state->base.crtc); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; +Extra w/s.
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state) · line 1830
Quoted 12 lines
drivers/gpu/drm/i915/intel_ddi.c +6
-0i915_reg_t reg =TRANS_DDI_FUNC_CTL (cpu_transcoder);uint32_t val =I915_READ (reg); val &= ~(TRANS_DDI_FUNC_ENABLE |TRANS_DDI_PORT_MASK |TRANS_DDI_DP_VC_PAYLOAD_ALLOC ); val |=TRANS_DDI_PORT_NONE ;I915_WRITE (reg, val); + +if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME && +intel_crtc_has_type (crtc_state,INTEL_OUTPUT_HDMI )) { +msleep (DDI_DISABLED_QUIRK_TIME ); +DRM_DEBUG_KMS ("Quirk Increase DDI disabled time\n" ); + }I still think the macro is redundant, but I'd put here your comment about the worst case mode and delay. The debug print should come before the wait.
Quoted 36 lines
drivers/gpu/drm/i915/intel_ddi.c +0
-0} int intel_ddi_toggle_hdcp_signalling(struct intel_encoder *intel_encoder,drivers/gpu/drm/i915/intel_display.c +12
-1@@ -5837,7 +5837,7 @@ static void haswell_crtc_disable(struct intel_crtc_state *old_crtc_state,intel_ddi_set_vc_payload_alloc (old_crtc_state, false);if (!transcoder_is_dsi (cpu_transcoder)) -intel_ddi_disable_transcoder_func (dev_priv, cpu_transcoder); +intel_ddi_disable_transcoder_func (old_crtc_state);if (INTEL_GEN (dev_priv) >=9 )skylake_scaler_disable (intel_crtc);@@ -14852,6 +14852,17 @@ static void quirk_increase_t12_delay(struct drm_device *dev)DRM_INFO ("Applying T12 delay quirk\n" ); } +/* GeminiLake NUC HDMI outputs require additional off time +* this allows the onboard retimer to correctly sync to signal +*/ +static void quirk_increase_ddi_disabled_time (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); + + dev_priv->quirks |=QUIRK_INCREASE_DDI_DISABLED_TIME ; +DRM_INFO ("Applying Increase DDI Disabled quirk\n" ); +} +struct intel_quirk {int device;int subsystem_vendor;@@ -14938,6 +14949,14 @@ static int intel_dmi_reverse_brightness(const struct dmi_system_id *id)drivers/gpu/drm/i915/intel_display.c static int intel_dmi_reverse_brightness(const struct dmi_system_id *id) · line 14959
Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +8
-0/* Toshiba Satellite P50-C-18C */ { 0x191B, 0x1179, 0xF840, quirk_increase_t12_delay }, + +/* GeminiLake NUC */ + { 0x3185, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, +/* ASRock ITX*/ + { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, +Extra w/s.
Quoted 2 lines
With the above fixed:
Reviewed-by Imre Deak <[email protected]>
Can't accept the R-B yet as the patch failed testing. Added another conditional check for INTEL_OUTPUT_DDI as some devices return this output type during a cold boot.
Submitted v4 with the changes.
-Clint
Quoted 13 lines
Quoted 13 lines
drivers/gpu/drm/i915/intel_display.c +0
-0};static void intel_init_quirks (struct drm_device *dev)drivers/gpu/drm/i915/intel_drv.h +0
-1@@ -1384,8 +1384,7 @@ void hsw_fdi_link_train(struct intel_crtc *crtc,void intel_ddi_init (struct drm_i915_private *dev_priv,enum port port);bool intel_ddi_get_hw_state (struct intel_encoder *encoder,enum pipe *pipe);void intel_ddi_enable_transcoder_func (const struct intel_crtc_state *crtc_state); -void intel_ddi_disable_transcoder_func(struct drm_i915_private *dev_priv,
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/intel_drv.h +1
-1- enum transcoder cpu_transcoder); +void intel_ddi_disable_transcoder_func (const struct intel_crtc_state *crtc_state);void intel_ddi_enable_pipe_clock (const struct intel_crtc_state *crtc_state);void intel_ddi_disable_pipe_clock (const struct intel_crtc_state *crtc_state);void intel_ddi_set_pipe_settings (const struct intel_crtc_state *crtc_state);Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 1/1 drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
In reply to Imre DeakFrom: Clint Taylor <[email protected]>
On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal.
When measured on a scope the highspeed lines of the HDMI clock turn off
for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC appears to require at least a full frame of quiet time before a
new faster clock can be correctly sync'd. Wait 100ms due to msleep inaccuracies while waiting for a completed frame. Add a quirk to the driver for GLK boards that use ITE66317 HDMI retimers.
V2: Add more devices to the quirk list
V3: Delay increased to 100ms, check to confirm crtc type is HDMI.
V4: crtc type check extended to include _DDI and whitespace fixes
Cc: Imre Deak <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105887
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 18 +++++++++++++++--- drivers/gpu/drm/i915/intel_display.c | 20 +++++++++++++++++++- drivers/gpu/drm/i915/intel_drv.h | 3 +-- 4 files changed, 36 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -650,6 +650,7 @@ enum intel_sbi_destination {#define QUIRK_BACKLIGHT_PRESENT (1<<3)#define QUIRK_PIN_SWIZZLED_PAGES (1<<5)#define QUIRK_INCREASE_T12_DELAY (1<<6) +#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)struct intel_fbdev ;struct intel_fbc_work ;
drivers/gpu/drm/i915/intel_ddi.c +15 -3
@@ -1807,15 +1807,27 @@ void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state)I915_WRITE (TRANS_DDI_FUNC_CTL (cpu_transcoder), temp); } -void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv, -enum transcoder cpu_transcoder) +/* Quirk time at 100ms for reliable operation */ +#define DDI_DISABLED_QUIRK_TIME 100 + +void intel_ddi_disable_transcoder_func (const struct intel_crtc_state *crtc_state) { +struct intel_crtc *crtc =to_intel_crtc (crtc_state->base.crtc); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; +i915_reg_t reg =TRANS_DDI_FUNC_CTL (cpu_transcoder);uint32_t val =I915_READ (reg); - val &= ~(TRANS_DDI_FUNC_ENABLE |TRANS_DDI_PORT_MASK |TRANS_DDI_DP_VC_PAYLOAD_ALLOC ); val |=TRANS_DDI_PORT_NONE ;I915_WRITE (reg, val); + +if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME && + (intel_crtc_has_type (crtc_state,INTEL_OUTPUT_HDMI ) || +intel_crtc_has_type (crtc_state,INTEL_OUTPUT_DDI ))) { +DRM_DEBUG_KMS ("Quirk Increase DDI disabled time\n" ); +msleep (DDI_DISABLED_QUIRK_TIME ); + } } int intel_ddi_toggle_hdcp_signalling(struct intel_encoder *intel_encoder,
drivers/gpu/drm/i915/intel_display.c +19 -1
@@ -5837,7 +5837,7 @@ static void haswell_crtc_disable(struct intel_crtc_state *old_crtc_state,intel_ddi_set_vc_payload_alloc (old_crtc_state, false);if (!transcoder_is_dsi (cpu_transcoder)) -intel_ddi_disable_transcoder_func (dev_priv, cpu_transcoder); +intel_ddi_disable_transcoder_func (old_crtc_state);if (INTEL_GEN (dev_priv) >=9 )skylake_scaler_disable (intel_crtc);
@@ -14847,6 +14847,17 @@ static void quirk_increase_t12_delay(struct drm_device *dev)DRM_INFO ("Applying T12 delay quirk\n" ); } +/* GeminiLake NUC HDMI outputs require additional off time +* this allows the onboard retimer to correctly sync to signal +*/ +static void quirk_increase_ddi_disabled_time (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); + + dev_priv->quirks |=QUIRK_INCREASE_DDI_DISABLED_TIME ; +DRM_INFO ("Applying Increase DDI Disabled quirk\n" ); +} +struct intel_quirk {int device;int subsystem_vendor;
@@ -14933,6 +14944,13 @@ static int intel_dmi_reverse_brightness(const struct dmi_system_id *id)/* Toshiba Satellite P50-C-18C */ { 0x191B, 0x1179, 0xF840, quirk_increase_t12_delay }, + +/* GeminiLake NUC */ + { 0x3185, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, +/* ASRock ITX*/ + { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, };static void intel_init_quirks (struct drm_device *dev)
drivers/gpu/drm/i915/intel_drv.h +1 -2
@@ -1384,8 +1384,7 @@ void hsw_fdi_link_train(struct intel_crtc *crtc,void intel_ddi_init (struct drm_i915_private *dev_priv,enum port port);bool intel_ddi_get_hw_state (struct intel_encoder *encoder,enum pipe *pipe);void intel_ddi_enable_transcoder_func (const struct intel_crtc_state *crtc_state); -void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv, -enum transcoder cpu_transcoder); +void intel_ddi_disable_transcoder_func (const struct intel_crtc_state *crtc_state);void intel_ddi_enable_pipe_clock (const struct intel_crtc_state *crtc_state);void intel_ddi_disable_pipe_clock (const struct intel_crtc_state *crtc_state);void intel_ddi_set_pipe_settings (const struct intel_crtc_state *crtc_state);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 43 lines · On Tue, Jul 03, 2018 at 01:16:40PM -0700, [email protected] wrote:
From: Clint Taylor <[email protected]>
On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal.
When measured on a scope the highspeed lines of the HDMI clock turn off
for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC appears to require at least a full frame of quiet time before a
new faster clock can be correctly sync'd. Wait 100ms due to msleep inaccuracies while waiting for a completed frame. Add a quirk to the driver for GLK boards that use ITE66317 HDMI retimers.V2: Add more devices to the quirk list
V3: Delay increased to 100ms, check to confirm crtc type is HDMI.
V4: crtc type check extended to include_DDIand whitespace fixesCc: Imre Deak <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105887Signed-off-by Clint Taylor <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 18 +++++++++++++++--- drivers/gpu/drm/i915/intel_display.c | 20 +++++++++++++++++++- drivers/gpu/drm/i915/intel_drv.h | 3 +-- 4 files changed, 36 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/i915_drv.h +1
-0@@ -650,6 +650,7 @@ enum intel_sbi_destination {#define QUIRK_BACKLIGHT_PRESENT (1<<3)#define QUIRK_PIN_SWIZZLED_PAGES (1<<5)#define QUIRK_INCREASE_T12_DELAY (1<<6) +#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)struct intel_fbdev ;struct intel_fbc_work ;drivers/gpu/drm/i915/intel_ddi.c +0
-0
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state) · line 1811
Quoted 7 lines
drivers/gpu/drm/i915/intel_ddi.c +2
-2@@ -1807,15 +1807,27 @@ void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state)I915_WRITE (TRANS_DDI_FUNC_CTL (cpu_transcoder), temp); } -void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv, -enum transcoder cpu_transcoder) +/* Quirk time at 100ms for reliable operation */ +#define DDI_DISABLED_QUIRK_TIME 100
No need for this define as I commented earlier.
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state) · line 1815
Quoted 10 lines
drivers/gpu/drm/i915/intel_ddi.c +6
-1+ +void intel_ddi_disable_transcoder_func (const struct intel_crtc_state *crtc_state) { +struct intel_crtc *crtc =to_intel_crtc (crtc_state->base.crtc); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; +i915_reg_t reg =TRANS_DDI_FUNC_CTL (cpu_transcoder);uint32_t val =I915_READ (reg); -
Removed w/s from the wrong spot.
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state) · line 1827
Quoted 7 lines
drivers/gpu/drm/i915/intel_ddi.c +4
-0val &= ~(TRANS_DDI_FUNC_ENABLE |TRANS_DDI_PORT_MASK |TRANS_DDI_DP_VC_PAYLOAD_ALLOC ); val |=TRANS_DDI_PORT_NONE ;I915_WRITE (reg, val); + +if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME && + (intel_crtc_has_type (crtc_state,INTEL_OUTPUT_HDMI ) || +intel_crtc_has_type (crtc_state,INTEL_OUTPUT_DDI ))) {
Hm, INTEL_OUTPUT_DDI is not a possible output type, the whole encoder enable/disable sequence would be broken with that. Even during module loading/HW readout we should already set the proper HDMI/DP type in intel_modeset_pipe_config().
Looking now at the bug report [1], the reporter is using an old kernel, where we left encoder->type at INTEL_OUTPUT_UNKNOWN during HW readout and set it correctly only after the first modeset. That could be addressed by adding INTEL_OUTPUT_UNKNOWN when backporting the workaround, but in this patch we should only check for INTEL_OUTPUT_HDMI.
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state) · line 1829
Quoted 2 lines
drivers/gpu/drm/i915/intel_ddi.c +2
-0+DRM_DEBUG_KMS ("Quirk Increase DDI disabled time\n" ); +msleep (DDI_DISABLED_QUIRK_TIME );
Just msleep(100); as I commented earlier.
[1] https://bugs.freedesktop.org/show_bug.cgi?id=105887#c110
Quoted 66 lines
drivers/gpu/drm/i915/intel_ddi.c +1
-0+ } } int intel_ddi_toggle_hdcp_signalling(struct intel_encoder *intel_encoder,drivers/gpu/drm/i915/intel_display.c +19
-1@@ -5837,7 +5837,7 @@ static void haswell_crtc_disable(struct intel_crtc_state *old_crtc_state,intel_ddi_set_vc_payload_alloc (old_crtc_state, false);if (!transcoder_is_dsi (cpu_transcoder)) -intel_ddi_disable_transcoder_func (dev_priv, cpu_transcoder); +intel_ddi_disable_transcoder_func (old_crtc_state);if (INTEL_GEN (dev_priv) >=9 )skylake_scaler_disable (intel_crtc);@@ -14847,6 +14847,17 @@ static void quirk_increase_t12_delay(struct drm_device *dev)DRM_INFO ("Applying T12 delay quirk\n" ); } +/* GeminiLake NUC HDMI outputs require additional off time +* this allows the onboard retimer to correctly sync to signal +*/ +static void quirk_increase_ddi_disabled_time (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); + + dev_priv->quirks |=QUIRK_INCREASE_DDI_DISABLED_TIME ; +DRM_INFO ("Applying Increase DDI Disabled quirk\n" ); +} +struct intel_quirk {int device;int subsystem_vendor;@@ -14933,6 +14944,13 @@ static int intel_dmi_reverse_brightness(const struct dmi_system_id *id)/* Toshiba Satellite P50-C-18C */ { 0x191B, 0x1179, 0xF840, quirk_increase_t12_delay }, + +/* GeminiLake NUC */ + { 0x3185, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x8086, 0x2072, quirk_increase_ddi_disabled_time }, +/* ASRock ITX*/ + { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, };static void intel_init_quirks (struct drm_device *dev)drivers/gpu/drm/i915/intel_drv.h +1
-2@@ -1384,8 +1384,7 @@ void hsw_fdi_link_train(struct intel_crtc *crtc,void intel_ddi_init (struct drm_i915_private *dev_priv,enum port port);bool intel_ddi_get_hw_state (struct intel_encoder *encoder,enum pipe *pipe);void intel_ddi_enable_transcoder_func (const struct intel_crtc_state *crtc_state); -void intel_ddi_disable_transcoder_func (struct drm_i915_private *dev_priv, -enum transcoder cpu_transcoder); +void intel_ddi_disable_transcoder_func (const struct intel_crtc_state *crtc_state);void intel_ddi_enable_pipe_clock (const struct intel_crtc_state *crtc_state);void intel_ddi_disable_pipe_clock (const struct intel_crtc_state *crtc_state);void intel_ddi_set_pipe_settings (const struct intel_crtc_state *crtc_state);Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Scheller
Tested-byHi Imre, Clinton,
Am Wed, 4 Jul 2018 13:05:59 +0300
schrieb Imre Deak <[email protected]>:
Quoted 41 lines · On Tue, Jul 03, 2018 at 01:16:40PM -0700, [email protected] wrote:
Quoted 27 lines
From: Clint Taylor <[email protected]>
On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal.
When measured on a scope the highspeed lines of the HDMI clock turn off
for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC appears to require at least a full frame of quiet time before a
new faster clock can be correctly sync'd. Wait 100ms due to msleep inaccuracies while waiting for a completed frame. Add a quirk to the driver for GLK boards that use ITE66317 HDMI retimers.V2: Add more devices to the quirk list
V3: Delay increased to 100ms, check to confirm crtc type is HDMI.
V4: crtc type check extended to include_DDIand whitespace fixesCc: Imre Deak <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105887Signed-off-by Clint Taylor <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 18 +++++++++++++++--- drivers/gpu/drm/i915/intel_display.c | 20 +++++++++++++++++++- drivers/gpu/drm/i915/intel_drv.h | 3 +-- 4 files changed, 36 insertions(+), 6 deletions(-)[...]
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_enable_transcoder_func(const struct intel_crtc_state *crtc_state) · line 1827
Quoted 7 lines
drivers/gpu/drm/i915/intel_ddi.c +4
-0val &= ~(TRANS_DDI_FUNC_ENABLE |TRANS_DDI_PORT_MASK |TRANS_DDI_DP_VC_PAYLOAD_ALLOC ); val |=TRANS_DDI_PORT_NONE ;I915_WRITE (reg, val); + +if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME && + (intel_crtc_has_type (crtc_state,INTEL_OUTPUT_HDMI ) || +intel_crtc_has_type (crtc_state,INTEL_OUTPUT_DDI ))) {Hm,
INTEL_OUTPUT_DDIis not a possible output type, the whole encoder enable/disable sequence would be broken with that. Even during module loading/HW readout we should already set the proper HDMI/DP type inintel_modeset_pipe_config().
Quoted 7 lines
Looking now at the bug report [1], the reporter is using an old kernel, where we left
encoder->typeatINTEL_OUTPUT_UNKNOWNduring HW readout and set it correctly only after the first modeset. That could be addressed by addingINTEL_OUTPUT_UNKNOWNwhen backporting the workaround, but in this patch we should only check forINTEL_OUTPUT_HDMI.[1] https://bugs.freedesktop.org/show_bug.cgi?id=105887#c110
You're correct, this (INTEL_OUTPUT_UNKNOWN being set) indeed seems to be something with the i915 driver in kernel 4.15. I've just built a Kernel image/package from 4.17.4 with this patch applied, plus the DRM_ERROR print that logs the connector to the kernel log, and in fact on 4.17.x it's already on INTEL_OUTPUT_HDMI right after boot/driver load/hwinit (always 64), so for upstream the _UNKNOWN or _DDI check probably really isn't necessary. Posting links to the bug report in a second.
Sorry for any troubles or additional work the _UNKNOWN report/suggestion might have caused.
For v5, given that the logic won't change, feel free to add my
Best regards,
Daniel Scheller
Signature · 5 lines
https://github.com/herrnst _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev2)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev2)
URL : https://patchwork.freedesktop.org/series/44446/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
40e1ef81c43c drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
-:30: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#30: FILE: drivers/gpu/drm/i915/i915_drv.h:659:
+#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)
^total: 0 errors, 0 warnings, 1 checks, 58 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.SPARSE: warning for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev2)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev2)
URL : https://patchwork.freedesktop.org/series/44446/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Commit: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. -drivers/gpu/drm/i915/selftests/../i915_drv.h:3681:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/selftests/../i915_drv.h:3682:16: warning: expression using sizeof(void)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev2)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev2)
URL : https://patchwork.freedesktop.org/series/44446/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4311 -> Patchwork_9296 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/44446/revisions/2/mbox/
== Known issues ==
Here are the changes found in Patchwork_9296 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: PASS -> DMESG-WARN (fdo#105128)
igt@kms_flip@basic-flip-vs-dpms:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106000)
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: PASS -> DMESG-FAIL (fdo#106103, fdo#102614)
igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence:
fi-glk-j4005: PASS -> FAIL (fdo#103481)
==== Possible fixes ====
igt@gem_ctx_create@basic-files:
fi-glk-j4005: DMESG-WARN (fdo#105719) -> PASS
igt@gem_exec_gttfill@basic:
fi-byt-n2820: FAIL (fdo#106744) -> PASS
igt@gem_exec_suspend@basic-s4-devices:
fi-glk-j4005: DMESG-WARN (fdo#106097) -> PASS
igt@kms_flip@basic-flip-vs-modeset:
fi-skl-6700hq: DMESG-WARN (fdo#105998) -> PASS +1
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-cnl-psr: FAIL (fdo#100368) -> PASS
fi-glk-j4005: FAIL (fdo#100368) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: INCOMPLETE (fdo#103927) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
fdo#106744 https://bugs.freedesktop.org/show_bug.cgi?id=106744
== Participating hosts (43 -> 39) ==
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan
== Build changes ==
* Linux: CI_DRM_4311 -> Patchwork_9296
CI_DRM_4311: 875eebee4a444f5b7ba146754e91118ff3c11ad5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4518: e4908004547b63131352fbc0ddcdb1d3d55480e0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9296: 40e1ef81c43c81cb2c4b0306dbf1b4705e5f4e76 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
40e1ef81c43c drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9296/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev2)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev2)
URL : https://patchwork.freedesktop.org/series/44446/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4311_full -> Patchwork_9296_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9296_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_9296_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9296_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-vebox:
shard-kbl: PASS -> SKIP +2
igt@gem_mocs_settings@mocs-rc6-ctx-dirty-render:
shard-kbl: SKIP -> PASS== Known issues ==
Here are the changes found in Patchwork_9296_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
shard-kbl: PASS -> DMESG-FAIL (fdo#106560)
igt@gem_exec_big:
shard-hsw: PASS -> INCOMPLETE (fdo#103540)
igt@gem_wait@await-bsd2:
shard-snb: SKIP -> INCOMPLETE (fdo#105411)
igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
shard-glk: PASS -> INCOMPLETE (k.org#198133, fdo#103359) +1
igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
shard-glk: PASS -> FAIL (fdo#105454, fdo#106509)
igt@kms_cursor_legacy@flip-vs-cursor-atomic:
shard-hsw: PASS -> FAIL (fdo#102670)
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-hsw: PASS -> FAIL (fdo#102887)
igt@kms_flip@2x-flip-vs-wf_vblank-interruptible:
shard-hsw: PASS -> FAIL (fdo#103928)
igt@kms_flip@2x-plain-flip-ts-check:
shard-glk: PASS -> FAIL (fdo#100368)
==== Possible fixes ====
igt@drv_selftest@live_gtt:
shard-kbl: FAIL (fdo#105347) -> PASS
igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS +1
igt@kms_flip@2x-plain-flip-ts-check:
shard-hsw: FAIL (fdo#100368) -> PASS
igt@kms_flip_tiling@flip-x-tiled:
shard-glk: FAIL (fdo#103822, fdo#104724) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4311 -> Patchwork_9296
CI_DRM_4311: 875eebee4a444f5b7ba146754e91118ff3c11ad5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4518: e4908004547b63131352fbc0ddcdb1d3d55480e0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9296: 40e1ef81c43c81cb2c4b0306dbf1b4705e5f4e76 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9296/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev3)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev3)
URL : https://patchwork.freedesktop.org/series/44446/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
d4f58a865a45 drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
-:31: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#31: FILE: drivers/gpu/drm/i915/i915_drv.h:658:
+#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)
^total: 0 errors, 0 warnings, 1 checks, 84 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.SPARSE: warning for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev3)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev3)
URL : https://patchwork.freedesktop.org/series/44446/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Commit: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. -drivers/gpu/drm/i915/selftests/../i915_drv.h:3672:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/selftests/../i915_drv.h:3673:16: warning: expression using sizeof(void)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev3)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev3)
URL : https://patchwork.freedesktop.org/series/44446/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4398 -> Patchwork_9475 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/44446/revisions/3/mbox/
== Known issues ==
Here are the changes found in Patchwork_9475 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
== Participating hosts (44 -> 38) ==
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-glk-j4005
== Build changes ==
* Linux: CI_DRM_4398 -> Patchwork_9475
CI_DRM_4398: 66df3b4e8f63d2918d202cd0802ce389cfe36b0e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4530: 0e98bf69f146eb72fe3a7c3b19a049b5786f0ca3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9475: d4f58a865a45654bdb0c6b2742430bb06328e521 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d4f58a865a45 drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9475/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev3)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev3)
URL : https://patchwork.freedesktop.org/series/44446/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4398_full -> Patchwork_9475_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9475_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_9475_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9475_full:
=== IGT changes ===
==== Warnings ====
igt@perf_pmu@rc6:
shard-kbl: SKIP -> PASS== Known issues ==
Here are the changes found in Patchwork_9475_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
shard-glk: NOTRUN -> DMESG-FAIL (fdo#106947, fdo#106560)
igt@gem_softpin@noreloc-s3:
shard-kbl: NOTRUN -> INCOMPLETE (fdo#103665)
igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
shard-glk: PASS -> INCOMPLETE (fdo#103359, k.org#198133) +1
igt@kms_flip@flip-vs-expired-vblank:
shard-glk: PASS -> FAIL (fdo#105189)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
shard-kbl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@drv_selftest@live_gtt:
shard-glk: INCOMPLETE (fdo#103359, k.org#198133) -> PASS
igt@drv_selftest@live_hangcheck:
shard-apl: DMESG-FAIL (fdo#106947, fdo#106560) -> PASS
igt@gem_ctx_isolation@rcs0-s3:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_flip@plain-flip-ts-check-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS
igt@kms_flip_tiling@flip-x-tiled:
shard-glk: FAIL (fdo#104724, fdo#103822) -> PASS +1
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt:
shard-glk: FAIL (fdo#103167, fdo#104724) -> PASS
igt@kms_rotation_crc@primary-rotation-90:
shard-kbl: FAIL (fdo#104724, fdo#103925) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105189 https://bugs.freedesktop.org/show_bug.cgi?id=105189
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4398 -> Patchwork_9475
CI_DRM_4398: 66df3b4e8f63d2918d202cd0802ce389cfe36b0e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4530: 0e98bf69f146eb72fe3a7c3b19a049b5786f0ca3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9475: d4f58a865a45654bdb0c6b2742430bb06328e521 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9475/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev4)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev4)
URL : https://patchwork.freedesktop.org/series/44446/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
5f7ac64538c1 drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
-:32: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#32: FILE: drivers/gpu/drm/i915/i915_drv.h:653:
+#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)
^total: 0 errors, 0 warnings, 1 checks, 84 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.SPARSE: warning for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev4)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev4)
URL : https://patchwork.freedesktop.org/series/44446/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Commit: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. -drivers/gpu/drm/i915/selftests/../i915_drv.h:3664:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/selftests/../i915_drv.h:3665:16: warning: expression using sizeof(void)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev4)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev4)
URL : https://patchwork.freedesktop.org/series/44446/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4423 -> Patchwork_9514 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/44446/revisions/4/mbox/
== Known issues ==
Here are the changes found in Patchwork_9514 that come from known issues:
=== IGT changes ===
==== Possible fixes ====
igt@gem_exec_suspend@basic-s3:
{fi-cfl-8109u}: INCOMPLETE -> PASS
igt@kms_chamelium@dp-edid-read:
fi-kbl-7500u: FAIL (fdo#103841) -> PASS {name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
== Participating hosts (45 -> 41) ==
Additional (1): fi-bxt-dsi
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4423 -> Patchwork_9514
CI_DRM_4423: 9b9b45349fe3a36d41586992426d03a238396531 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4533: 199220052af977598033d3810ffb4cc32d377522 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9514: 5f7ac64538c16db5cfd2371bfdad1b9d7e1564f8 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
5f7ac64538c1 drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9514/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev4)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev4)
URL : https://patchwork.freedesktop.org/series/44446/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4423_full -> Patchwork_9514_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9514_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_9514_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9514_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-blt:
shard-kbl: SKIP -> PASS +1
igt@perf_pmu@rc6:
shard-kbl: PASS -> SKIP== Known issues ==
Here are the changes found in Patchwork_9514_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_gtt:
shard-kbl: PASS -> FAIL (fdo#105347)
igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
shard-glk: PASS -> INCOMPLETE (k.org#198133, fdo#103359)
igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
shard-glk: PASS -> FAIL (fdo#106509, fdo#105454)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
shard-kbl: PASS -> FAIL (fdo#99912)
igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
shard-kbl: PASS -> INCOMPLETE (fdo#103665) +1
==== Possible fixes ====
igt@kms_vblank@pipe-a-ts-continuation-suspend:
shard-hsw: FAIL (fdo#104894) -> PASS
igt@perf@polling:
shard-hsw: FAIL (fdo#102252) -> PASS
==== Warnings ====
igt@drv_selftest@live_gtt:
shard-glk: INCOMPLETE (k.org#198133, fdo#103359) -> FAIL (fdo#105347) fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#104894 https://bugs.freedesktop.org/show_bug.cgi?id=104894
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4423 -> Patchwork_9514
CI_DRM_4423: 9b9b45349fe3a36d41586992426d03a238396531 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4533: 199220052af977598033d3810ffb4cc32d377522 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9514: 5f7ac64538c16db5cfd2371bfdad1b9d7e1564f8 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9514/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx