Skip to contentSkip to conversation

drm/arm/malidp:- Rectify the width and height passed to rotmem_required()

PATCH In review Ayan Kumar Halder 2 participants 2 messages Jun 15, 2018 – Jun 18, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/arm/malidp:- Rectify the width and height passed to rotmem_required()

The width and height needs to be swapped

---
 drivers/gpu/drm/arm/malidp_planes.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/arm/malidp_planes.c +2 -2
index 377382e..533cdde 100644
@@ -244,8 +244,8 @@ static int malidp_de_plane_check(struct drm_plane *plane,
 	if (state->rotation != DRM_MODE_ROTATE_0 || fb->modifier) {
 		int val;
 
-		val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_h,
-						     state->crtc_w,
+		val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_w,
+						     state->crtc_h,
 						     fb->format->format,
 						     !!(fb->modifier));
 		if (val < 0)
Signature · 1 line
2.7.4
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Ayan Kumar Halder

The width and height needs to be swapped

---
 drivers/gpu/drm/arm/malidp_planes.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/arm/malidp_planes.c +0 -0
index 377382e..533cdde 100644

drivers/gpu/drm/arm/malidp_planes.c static int malidp_de_plane_check(struct drm_plane *plane, · line 250

Quoted 9 lines
drivers/gpu/drm/arm/malidp_planes.c +2 -2
@@ -244,8 +244,8 @@ static int malidp_de_plane_check(struct drm_plane *plane,
 	if (state->rotation != DRM_MODE_ROTATE_0 || fb->modifier) {
 		int val;
 
-		val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_h,
-						     state->crtc_w,
+		val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_w,
+						     state->crtc_h,
 						     fb->format->format,
 						     !!(fb->modifier));

Ooops, thanks for catching this!

Quoted 4 lines
drivers/gpu/drm/arm/malidp_planes.c +0 -0
 		if (val < 0)
Signature · 1 line
2.7.4
Signature · 12 lines
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel