vhost: fix dequeue_zero_zopy cannot be enabled
PATCH 1/1 vhost: fix dequeue_zero_zopy cannot be enabled
Use flag instead of vsocket->is_server to determine whether vhost is in client mode. Because vsocket->is_server is not ready yet.
--- lib/librte_vhost/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_vhost/socket.c +1 -1
@@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags) ret =-1 ; goto out_mutex; } -if (!vsocket->is_server) { +if ((flags &RTE_VHOST_USER_CLIENT ) !=0 ) {VHOST_LOG_CONFIG (ERR ,"error: zero copy is incompatible with vhost client mode\n" ); ret =-1 ;
Signature · 1 line
2.17.1
PATCH v2 1/1 vhost: fix zero-copy cannot be enabled
This patch fixes the situation where vhost-user cannot start as server with dequeue_zero_copy enabled.
Using flag instead of vsocket->is_server to determine whether vhost-user is in client mode. Because vsocket->is_server is not ready at this time.
---
v2:
* Added the description of problem solved in commit log.
--- lib/librte_vhost/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_vhost/socket.c +1 -1
@@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags) ret =-1 ; goto out_mutex; } -if (!vsocket->is_server) { +if ((flags &RTE_VHOST_USER_CLIENT ) !=0 ) {VHOST_LOG_CONFIG (ERR ,"error: zero copy is incompatible with vhost client mode\n" ); ret =-1 ;
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled
Quoted 7 lines · Xuan Ding
This patch fixes the situation where vhost-user cannot start as server with
dequeue_zero_copyenabled.Using flag instead of
vsocket->is_serverto determine whether vhost-user is in client mode. Becausevsocket->is_serveris not ready at this time.
And no need to cc stable since above commit is introduced in this release.
Quoted 26 lines
Signed-off-by Xuan Ding <[email protected]>---
v2:
* Added the description of problem solved in commit log.
---lib/librte_vhost/socket.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)lib/librte_vhost/socket.c +1
-1@@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags) ret =-1 ; goto out_mutex; } -if (!vsocket->is_server) { +if ((flags &RTE_VHOST_USER_CLIENT ) !=0 ) {VHOST_LOG_CONFIG (ERR ,"error: zero copy is incompatible with vhost client mode\n" ); ret =-1 ;Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled
Hi, Maxime & Ferruh
This patch is used to fix the regression caused by commit 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode") which was introduced in RC2, I think we should get it in this release.
Thanks,
Xiaolong
Quoted 41 lines · Ye Xiaolong
Quoted 7 lines · Xuan Ding
This patch fixes the situation where vhost-user cannot start as server with
dequeue_zero_copyenabled.Using flag instead of
vsocket->is_serverto determine whether vhost-user is in client mode. Becausevsocket->is_serveris not ready at this time.Fixes 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode")And no need to cc stable since above commit is introduced in this release.
Quoted 26 lines
Signed-off-by Xuan Ding <[email protected]>---
v2:
* Added the description of problem solved in commit log.
---lib/librte_vhost/socket.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)lib/librte_vhost/socket.c +1
-1@@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags) ret =-1 ; goto out_mutex; } -if (!vsocket->is_server) { +if ((flags &RTE_VHOST_USER_CLIENT ) !=0 ) {VHOST_LOG_CONFIG (ERR ,"error: zero copy is incompatible with vhost client mode\n" ); ret =-1 ;Signature · 1 line
2.17.1Reviewed-by Xiaolong Ye <[email protected]>
Re: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled
Quoted 5 lines · Ye Xiaolong
Hi, Maxime & Ferruh
This patch is used to fix the regression caused by commit
715070ea10e6("vhost: prevent zero-copy with incompatible client mode") which was introduced in RC2, I think we should get it in this release.
+1, v4 of the patch applied to next-net for -rc3
Quoted 46 lines
Thanks,
XiaolongQuoted 41 lines · Ye Xiaolong
Quoted 7 lines · Xuan Ding
This patch fixes the situation where vhost-user cannot start as server with
dequeue_zero_copyenabled.Using flag instead of
vsocket->is_serverto determine whether vhost-user is in client mode. Becausevsocket->is_serveris not ready at this time.Fixes 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode")And no need to cc stable since above commit is introduced in this release.
Quoted 26 lines
Signed-off-by Xuan Ding <[email protected]>---
v2:
* Added the description of problem solved in commit log.
---lib/librte_vhost/socket.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)lib/librte_vhost/socket.c +1
-1@@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags) ret =-1 ; goto out_mutex; } -if (!vsocket->is_server) { +if ((flags &RTE_VHOST_USER_CLIENT ) !=0 ) {VHOST_LOG_CONFIG (ERR ,"error: zero copy is incompatible with vhost client mode\n" ); ret =-1 ;Signature · 1 line
2.17.1Reviewed-by Xiaolong Ye <[email protected]>
Re: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled
In reply to Xuan DingQuoted 42 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Xuan Ding
Sent: 2020年5月13日 10:14
To: [email protected]; Wang, Zhihong <[email protected]>; Ye, Xiaolong <[email protected]>
Cc: [email protected]; Ding, Xuan <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabledThis patch fixes the situation where vhost-user cannot start as server with
dequeue_zero_copyenabled.Using flag instead of
vsocket->is_serverto determine whether vhost-user is in client mode. Becausevsocket->is_serveris not ready at this time.Signed-off-by Xuan Ding <[email protected]>---
v2:
* Added the description of problem solved in commit log.--- lib/librte_vhost/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/librte_vhost/socket.c index renamed from lib/librte_vhost/socket.c +0
-0
bb8d0d780..0a66ef976100644lib/librte_vhost/socket.c +1
-1@@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags) ret =-1 ; goto out_mutex; } -if (!vsocket->is_server) { +if ((flags &RTE_VHOST_USER_CLIENT ) !=0 ) { VHOST_LOG_CONFIG(ERR, "error: zero copy is incompatible with vhost clientmode\n");
ret = -1;
--
2.17.1
PATCH v4 1/1 vhost: fix zero-copy cannot be enabled
In reply to Xuan DingThis patch fixes the situation where vhost-user cannot start as server with dequeue_zero_copy enabled.
Using flag instead of vsocket->is_server to determine whether vhost-user is in client mode. Because vsocket->is_server is not ready at this time.
---
v4:
* Added in reply to the first Message Id.
v3:
* Removed Cc to stable and added fixes label.
v2:
* Added the description of problem solved in commit log.
--- lib/librte_vhost/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_vhost/socket.c +1 -1
@@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags) ret =-1 ; goto out_mutex; } -if (!vsocket->is_server) { +if ((flags &RTE_VHOST_USER_CLIENT ) !=0 ) {VHOST_LOG_CONFIG (ERR ,"error: zero copy is incompatible with vhost client mode\n" ); ret =-1 ;
Signature · 1 line
2.17.1
Ferruh Yigit
AppliedRe: [dpdk-dev] [PATCH v4] vhost: fix zero-copy cannot be enabled
Quoted 11 lines · Xuan Ding
This patch fixes the situation where vhost-user cannot start as server with
dequeue_zero_copyenabled.Using flag instead of
vsocket->is_serverto determine whether vhost-user is in client mode. Becausevsocket->is_serveris not ready at this time.Fixes 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode")Signed-off-by Xuan Ding <[email protected]>Acked-by Xiaolong Ye <[email protected]>Tested-by Yinan Wang <[email protected]>
Applied to dpdk-next-net/master, thanks.