Skip to contentSkip to conversation

Fixed dosctrings (typos) and preferably load cl before vc

PATCH In review Xavier Maillard 2 participants 2 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 4/7 Fixed dosctrings (typos) and preferably load cl before vc

---
 contrib/emacs/vc-git.el |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
contrib/emacs/vc-git.el +6 -6
index 4cab845..748cb60 100644
@@ -32,8 +32,8 @@
 ;;  - more customisable variables
 
 (eval-when-compile 
-  (require 'cl)
-  (require 'vc))
+  (require 'vc)
+  (require 'cl))
 
 ;; Add it automatically
 (add-to-list 'vc-handled-backends 'GIT)
@@ -49,14 +49,14 @@
   :group 'vc-git)
 
 (defcustom vc-git-author-name nil
-"*Author name to use in git. If nil, we check for environment variables
-GIT_AUTHOR_NAME or `user_full_name'."
+"*Author name to use in git. If nil, we check for environment variable
+GIT_AUTHOR_NAME or `user-full-name'."
   :type '(choice string (const nil))
   :group 'vc-git)
 
 (defcustom vc-git-author-email nil
-"*Author email to use in git. If nil, we check for environment variables
-GIT_AUTHOR_ADDRESS and if still nil, `user_mail_address'."
+"*Author email to use in git. If nil, we check for environment variable
+GIT_AUTHOR_ADDRESS and if still nil, `user-mail-address'."
   :type '(choice string (const nil))
   :group 'vc-git)
 
Signature · 1 line
1.5.0
#1 lore raw
Quoted 10 lines · Xavier Maillard
---
 contrib/emacs/vc-git.el |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
contrib/emacs/vc-git.el +0 -0
index 4cab845..748cb60 100644

contrib/emacs/vc-git.el line 36

Quoted 7 lines
contrib/emacs/vc-git.el +2 -2
@@ -32,8 +32,8 @@
 ;;  - more customisable variables
 
 (eval-when-compile 
-  (require 'cl)
-  (require 'vc))
+  (require 'vc)
+  (require 'cl))

Could we have a brief description why vc should be required before cl? Or is it so common that does not need explanation for Emacs gurus?