Skip to contentSkip to conversation

drm: kirin: Remove useless "Scale not support" error message

RFC PATCH In review John Stultz 2 participants 2 messages Jun 21, 2018 – Jun 22, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 drm: kirin: Remove useless "Scale not support" error message

The driver doesn't support scaling, but when an atomic test is done it repeatedly spits out this warning which isn't particularly useful.

So just remove the error message.

Cc Xinliang Liu <[email protected]>
Cc Rongrong Zou <[email protected]>
Cc Xinwei Kong <[email protected]>
Cc Chen Feng <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Peter Griffin <[email protected]>
---
 drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c +0 -1
index 2269be9..bb77420 100644
@@ -859,7 +859,6 @@ static int ade_plane_atomic_check(struct drm_plane *plane,
 		return PTR_ERR(crtc_state);
 
 	if (src_w != crtc_w || src_h != crtc_h) {
-		DRM_ERROR("Scale not support!!!\n");
 		return -EINVAL;
 	}
 
Signature · 6 lines
2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw
Quoted 5 lines · John Stultz

The driver doesn't support scaling, but when an atomic test is done it repeatedly spits out this warning which isn't particularly useful.

So just remove the error message.

Quoted 9 lines
Cc Xinliang Liu <[email protected]>
Cc Rongrong Zou <[email protected]>
Cc Xinwei Kong <[email protected]>
Cc Chen Feng <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Peter Griffin <[email protected]>

Makes sense, applied to drm-misc-next. This code should probably use drm_atomic_helper_check_plane_state() anyway, which also comes with a useful set of opt-in debug output to replace this.
-Daniel

Quoted 19 lines
---
 drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c +0 -1
index 2269be9..bb77420 100644
@@ -859,7 +859,6 @@ static int ade_plane_atomic_check(struct drm_plane *plane,
 		return PTR_ERR(crtc_state);
 
 	if (src_w != crtc_w || src_h != crtc_h) {
-		DRM_ERROR("Scale not support!!!\n");
 		return -EINVAL;
 	}
 
Signature · 1 line
2.7.4
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel