Skip to contentSkip to conversation

protobuf: misc recipe cleanup

PATCH New Andre McCurdy 1 participant 2 messages Jun 28, 2018

lore
Share & tools
lore

Andre McCurdy

author
#0 lore raw

PATCH 1/2 protobuf: misc recipe cleanup

Re-order variables to align more closely with the OE style-guide.

Remove spurious ${bindir} from the protobuf-lite packaging rules.

Signed-off-by Andre McCurdy <[email protected]>
---
 .../recipes-devtools/protobuf/protobuf_3.5.1.bb    | 34 +++++++++++-----------
 1 file changed, 17 insertions(+), 17 deletions(-)
meta-oe/recipes-devtools/protobuf/protobuf_3.5.1.bb +17 -17
index 1ffb79d..8cef391 100644
@@ -5,32 +5,26 @@ all of its internal RPC protocols and file formats."
 HOMEPAGE = "https://github.com/google/protobuf"
 SECTION = "console/tools"
 LICENSE = "BSD-3-Clause"
-
-PACKAGE_BEFORE_PN = "${PN}-compiler ${PN}-lite"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=35953c752efc9299b184f91bef540095"
 
 DEPENDS = "zlib"
-DEPENDS_append_class-target  = " protobuf-native"
-RDEPENDS_${PN}-compiler = "${PN}"
-RDEPENDS_${PN}-dev += "${PN}-compiler"
-RDEPENDS_${PN}-ptest = "bash python-protobuf"
-
-LIC_FILES_CHKSUM = "file://LICENSE;md5=35953c752efc9299b184f91bef540095"
+DEPENDS_append_class-target = " protobuf-native"
 
+PV .= "+git${SRCPV}"
 SRCREV = "106ffc04be1abf3ff3399f54ccf149815b287dd9"
 
-PV = "3.5.1+git${SRCPV}"
-
 SRC_URI = "git://github.com/google/protobuf.git;branch=3.5.x \
-	   file://run-ptest \
-          "
+           file://run-ptest \
+"
 
-EXTRA_OECONF += " --with-protoc=echo"
+S = "${WORKDIR}/git"
 
 inherit autotools-brokensep pkgconfig ptest
 
-S = "${WORKDIR}/git"
-TEST_SRC_DIR="examples"
-LANG_SUPPORT="cpp python"
+EXTRA_OECONF += "--with-protoc=echo"
+
+TEST_SRC_DIR = "examples"
+LANG_SUPPORT = "cpp python"
 
 do_compile_ptest() {
 	# Modify makefile to use the cross-compiler

@@ -76,8 +70,14 @@ do_install_ptest() {
 	cd "$olddir"
 }
 
+PACKAGE_BEFORE_PN = "${PN}-compiler ${PN}-lite"
+
 FILES_${PN}-compiler = "${bindir} ${libdir}/libprotoc${SOLIBS}"
-FILES_${PN}-lite = "${bindir} ${libdir}/libprotobuf-lite${SOLIBS}"
+FILES_${PN}-lite = "${libdir}/libprotobuf-lite${SOLIBS}"
+
+RDEPENDS_${PN}-compiler = "${PN}"
+RDEPENDS_${PN}-dev += "${PN}-compiler"
+RDEPENDS_${PN}-ptest = "bash python-protobuf"
 
 MIPS_INSTRUCTION_SET = "mips"
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 protobuf-c: misc recipe cleanup

Re-order variables to align more closely with the OE style-guide.

Signed-off-by Andre McCurdy <[email protected]>
---
 meta-oe/recipes-devtools/protobuf/protobuf-c_1.3.0.bb | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
meta-oe/recipes-devtools/protobuf/protobuf-c_1.3.0.bb +6 -6
index fe1e6e5..9b69690 100644
@@ -8,15 +8,10 @@ has been split out into the protobuf-c-rpc project."
 HOMEPAGE = "https://github.com/protobuf-c/protobuf-c"
 SECTION = "console/tools"
 LICENSE = "BSD-2-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=cb901168715f4782a2b06c3ddaefa558"
 
 DEPENDS = "protobuf-native protobuf"
 
-PACKAGE_BEFORE_PN = "${PN}-compiler"
-RDEPENDS_${PN}-compiler = "protobuf-compiler"
-RDEPENDS_${PN}-dev += "${PN}-compiler"
-
-LIC_FILES_CHKSUM = "file://LICENSE;md5=cb901168715f4782a2b06c3ddaefa558"
-
 PV .= "+git${SRCPV}"
 SRCREV = "dac1a65feac4ad72f612aab99f487056fbcf5c1a"
 

@@ -26,6 +21,11 @@ S = "${WORKDIR}/git"
 
 inherit autotools pkgconfig
 
+PACKAGE_BEFORE_PN = "${PN}-compiler"
+
 FILES_${PN}-compiler = "${bindir}"
 
+RDEPENDS_${PN}-compiler = "protobuf-compiler"
+RDEPENDS_${PN}-dev += "${PN}-compiler"
+
 BBCLASSEXTEND = "native nativesdk"
Signature · 1 line
1.9.1