Skip to contentSkip to conversation

sparc32: cacheflush_32: Declare struct page

PATCH New Guenter Roeck 1 participant 1 message Jun 30, 2018 SPARC + UltraSPARC (sparc/sparc64)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sparc32: cacheflush_32: Declare struct page

Building allmodconfig images for sparc32 generates warnings such as

arch/sparc/include/asm/cacheflush_32.h:40:37: warning:
'struct page' declared inside parameter list

This results in odd warnings such as

arch/sparc/include/asm/cacheflush_32.h:40:6: note:
expected 'struct page *' but argument is of type 'struct page *'

With recent compilers (gcc 5.5.0 and later), this warning turns into a build error when compiling drivers/staging/media/omap4iss/iss_video.c.

./include/linux/highmem.h: In function 'copy_user_highpage':
./include/linux/highmem.h:233:36: error:
passing argument 1 of 'sparc_flush_page_to_ram'
from incompatible pointer type

Declare struct page to fix the problem.

Fixes 84fc727ed49c ("media: omap4iss: make it build with COMPILE_TEST")
Cc Mauro Carvalho Chehab <[email protected]>
---
 arch/sparc/include/asm/cacheflush_32.h | 2 ++
 1 file changed, 2 insertions(+)
arch/sparc/include/asm/cacheflush_32.h +2 -0
index fb66094a2c30..acb072c71e42 100644
@@ -4,6 +4,8 @@
 
 #include <asm/cachetlb_32.h>
 
+struct page;
+
 #define flush_cache_all() \
 	sparc32_cachetlb_ops->cache_all()
 #define flush_cache_mm(mm) \
Signature · 1 line
2.7.4