FAILED: patch "[PATCH] spi: spi-s3c64xx: Fix system resume support" failed to apply to 4.17-stable tree
Subsystems (4)
[email protected]
maintainerThe patch below does not apply to the 4.17-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
e935dba111621bd6a0c5d48e6511a4d9885103b4Mon Sep 17 00:00:00 2001
From: Marek Szyprowski <[email protected]>
Date: Wed, 16 May 2018 10:42:39 +0200
Subject: [PATCH] spi: spi-s3c64xx: Fix system resume support
Since Linux v4.10 release (commit 1d9174fbc55e "PM / Runtime: Defer resuming of the device in pm_runtime_force_resume()"), pm_runtime_force_resume() function doesn't runtime resume device if it was not runtime active before system suspend. Thus, driver should not do any register access after pm_runtime_force_resume() without checking the runtime status of the device. To fix this issue, simply move s3c64xx_spi_hwinit() call to s3c64xx_spi_runtime_resume() to ensure that hardware is always properly initialized. This fixes Synchronous external abort issue on system suspend/resume cycle on newer Exynos SoCs.
drivers/spi/spi-s3c64xx.c +2 -2
@@ -1292,8 +1292,6 @@ static int s3c64xx_spi_resume(struct device *dev)if (ret <0 )return ret; -s3c64xx_spi_hwinit (sdd); - return spi_master_resume(master); }#endif /* CONFIG_PM_SLEEP */
@@ -1331,6 +1329,8 @@ static int s3c64xx_spi_runtime_resume(struct device *dev)if (ret !=0 ) goto err_disable_src_clk; +s3c64xx_spi_hwinit (sdd); +return 0 ; err_disable_src_clk: