Skip to contentSkip to conversation

FAILED: patch "[PATCH] mtd: rawnand: denali_dt: set clk_x_rate to 200 MHz" failed to apply to 4.14-stable tree

PATCH [email protected] 2 participants 3 messages Jul 1, 2018 – Jul 20, 2018

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 3f6e6986045d47f87bd982910821b7ab9758487e Mon Sep 17 00:00:00 2001

From: Masahiro Yamada <[email protected]>
Date: Sat, 23 Jun 2018 01:06:34 +0900
Subject: [PATCH] mtd: rawnand: denali_dt: set clk_x_rate to 200 MHz
unconditionally

Since commit 1bb88666775e ("mtd: nand: denali: handle timing parameters by setup_data_interface()"), denali_dt.c gets the clock rate from the clock driver. The driver expects the frequency of the bus interface clock, whereas the clock driver of SOCFPGA provides the core clock. Thus, the setup_data_interface() hook calculates timing parameters based on a wrong frequency.

To make it work without relying on the clock driver, hard-code the clock frequency, 200MHz. This is fine for existing DT of UniPhier, and also fixes the issue of SOCFPGA because both platforms use 200 MHz for the bus interface clock.

Fixes 1bb88666775e ("mtd: nand: denali: handle timing parameters by setup_data_interface()")
Cc linux-stable <[email protected]> #4.14+
drivers/mtd/nand/raw/denali_dt.c +5 -1
index cfd33e6ca77f..5869e90cc14b 100644
@@ -123,7 +123,11 @@ static int denali_dt_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	denali->clk_x_rate = clk_get_rate(dt->clk);
+	/*
+	 * Hardcode the clock rate for the backward compatibility.
+	 * This works for both SOCFPGA and UniPhier.
+	 */
+	denali->clk_x_rate = 200000000;
 
 	ret = denali_init(denali);
 	if (ret)
Tested-by Richard Weinberger
#1 lore raw

Hi Greg,

Quoted 5 lines · On Sun, Jul 01, 2018 at 11:55:24AM +0200, [email protected] wrote:

The patch below does not apply to the 4.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

The attached backported patch should now apply to 4.14-stable. v4.14 had a different file location. The location was changed by 93db446a424c ("mtd: nand: move raw NAND related code to the raw/ subdir")

--
Regards
Sudip

Quoted 1 line

From c9be0b65d7b3a9c4a5d147af3e558e35061f93b8 Mon Sep 17 00:00:00 2001

From: Masahiro Yamada <[email protected]>
Date: Sat, 23 Jun 2018 01:06:34 +0900
Subject: [PATCH] mtd: rawnand: denali_dt: set clk_x_rate to 200 MHz
unconditionally

commit 3f6e6986045d47f87bd982910821b7ab9758487e upstream

Since commit 1bb88666775e ("mtd: nand: denali: handle timing parameters by setup_data_interface()"), denali_dt.c gets the clock rate from the clock driver. The driver expects the frequency of the bus interface clock, whereas the clock driver of SOCFPGA provides the core clock. Thus, the setup_data_interface() hook calculates timing parameters based on a wrong frequency.

To make it work without relying on the clock driver, hard-code the clock frequency, 200MHz. This is fine for existing DT of UniPhier, and also fixes the issue of SOCFPGA because both platforms use 200 MHz for the bus interface clock.

Fixes 1bb88666775e ("mtd: nand: denali: handle timing parameters by setup_data_interface()")
Cc linux-stable <[email protected]> #4.14+
---
 drivers/mtd/nand/denali_dt.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/mtd/nand/denali_dt.c +5 -1
index 56e2e177644d..3f4f4aea0e8b 100644
@@ -122,7 +122,11 @@ static int denali_dt_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	denali->clk_x_rate = clk_get_rate(dt->clk);
+	/*
+	 * Hardcode the clock rate for the backward compatibility.
+	 * This works for both SOCFPGA and UniPhier.
+	 */
+	denali->clk_x_rate = 200000000;
 
 	ret = denali_init(denali);
 	if (ret)
Signature · 1 line
2.11.0
author maintainer
#2 lore raw
Quoted 4 lines · Sudip Mukherjee

Hi Greg,

Quoted 1 line · On Sun, Jul 01, 2018 at 11:55:24AM +0200, [email protected] wrote:
Quoted 8 lines
Quoted 4 lines

The patch below does not apply to the 4.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

The attached backported patch should now apply to 4.14-stable. v4.14 had a different file location. The location was changed by 93db446a424c ("mtd: nand: move raw NAND related code to the raw/ subdir")

Thanks, now applied.

greg k-h