Skip to contentSkip to conversation

Patch "mtd: cfi_cmdset_0002: Change write buffer to check correct value" has been added to the 3.18-stable tree

PATCH [email protected] 1 participant 1 message Jul 1, 2018 Memory technology devices (MTD)

lore
Share & tools
lore

[email protected]

author Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mtd: cfi_cmdset_0002: Change write buffer to check correct value

to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mtd-cfi_cmdset_0002-change-write-buffer-to-check-correct-value.patch
and it can be found in the queue-3.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From dfeae1073583dc35c33b32150e18b7048bbb37e6 Mon Sep 17 00:00:00 2001

From: Tokunori Ikegami <[email protected]>
Date: Wed, 30 May 2018 18:32:26 +0900
Subject: mtd: cfi_cmdset_0002: Change write buffer to check correct value

From: Tokunori Ikegami <[email protected]>

commit dfeae1073583dc35c33b32150e18b7048bbb37e6 upstream.

For the word write it is checked if the chip has the correct value. But it is not checked for the write buffer as only checked if ready. To make sure for the write buffer change to check the value.

It is enough as this patch is only checking the last written word. Since it is described by data sheets to check the operation status.

---
 drivers/mtd/chips/cfi_cmdset_0002.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/chips/cfi_cmdset_0002.c +1 -1
@@ -1878,7 +1878,7 @@ static int __xipram do_write_buffer(stru
 		if (time_after(jiffies, timeo) && !chip_ready(map, adr))
 			break;
 
-		if (chip_ready(map, adr)) {
+		if (chip_good(map, adr, datum)) {
 			xip_enable(map, chip, adr);
 			goto op_done;
 		}

Patches currently in stable-queue which might be from [email protected] are

queue-3.18/mtd-cfi_cmdset_0002-change-erase-functions-to-retry-for-error.patch queue-3.18/mtd-cfi_cmdset_0002-change-write-buffer-to-check-correct-value.patch queue-3.18/mips-bcm47xx-enable-74k-core-externalsync-for-pcie-erratum.patch