kernfs: Replace strncpy with memcpy
PATCH 1/1 kernfs: Replace strncpy with memcpy
gcc 8.1.0 complains:
fs/kernfs/symlink.c:91:3: warning:
'strncpy' output truncated before terminating nul copying as many bytes from a string as its lengthfs/kernfs/symlink.c: In function 'kernfs_iop_get_link':fs/kernfs/symlink.c:88:14: note: length computed here
Using strncpy() is indeed less than perfect since the length of data to be copied has already been determined with strlen(). Replace strncpy() with memcpy() to address the warning and optimize the code a little.
--- fs/kernfs/symlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/kernfs/symlink.c +1 -1
@@ -88,7 +88,7 @@ static int kernfs_get_target_path(struct kernfs_node *parent,int slen =strlen (kn->name); len -= slen; -strncpy (s + len, kn->name, slen); +memcpy (s + len, kn->name, slen);if (len) s[--len] ='/' ;
Signature · 1 line
2.7.4
Quoted 8 lines · Guenter Roeck
gcc 8.1.0 complains:
fs/kernfs/symlink.c:91:3: warning:
'strncpy' output truncated before terminating nul copying as many bytes from a string as its lengthfs/kernfs/symlink.c: In function 'kernfs_iop_get_link':fs/kernfs/symlink.c:88:14: note: length computed here
Quoted 5 lines
Using
strncpy()is indeed less than perfect since the length of data to be copied has already been determined withstrlen(). Replacestrncpy()withmemcpy()to address the warning and optimize the code a little.Signed-off-by Guenter Roeck <[email protected]>
Thanks.
Signature · 1 line
tejun