Skip to contentSkip to conversation

fsi: sbefifo: Add missing mutex_unlock

PATCH In review Eddie James 2 participants 2 messages Jul 3, 2018 – Jul 4, 2018 FSI

lore
Share & tools
lore

Eddie James

author
#0 lore raw

PATCH 1/1 fsi: sbefifo: Add missing mutex_unlock

There was no unlock of the FFDC mutex.

Fixes 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
Signed-off-by Eddie James <[email protected]>
---
 drivers/fsi/fsi-sbefifo.c | 1 +
 1 file changed, 1 insertion(+)
drivers/fsi/fsi-sbefifo.c +1 -0
index 4f076fd..a34ff99 100644
@@ -194,6 +194,7 @@ static void sbefifo_dump_ffdc(struct device *dev, const __be32 *ffdc,
 		}
 		dev_warn(dev, "+-------------------------------------------+\n");
 	}
+	mutex_unlock(&sbefifo_ffdc_mutex);
 }
 
 int sbefifo_parse_status(struct device *dev, u16 cmd, __be32 *response,
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 4 lines · Eddie James

There was no unlock of the FFDC mutex.

Fixes 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
Signed-off-by Eddie James <[email protected]>

Thanks.

Cheers,
Ben.

Quoted 16 lines
---
 drivers/fsi/fsi-sbefifo.c | 1 +
 1 file changed, 1 insertion(+)
drivers/fsi/fsi-sbefifo.c +1 -0
index 4f076fd..a34ff99 100644
@@ -194,6 +194,7 @@ static void sbefifo_dump_ffdc(struct device *dev, const __be32 *ffdc,
 		}
 		dev_warn(dev, "+-------------------------------------------+\n");
 	}
+	mutex_unlock(&sbefifo_ffdc_mutex);
 }
 
 int sbefifo_parse_status(struct device *dev, u16 cmd, __be32 *response,