Skip to contentSkip to conversation

drm/i915/gvt: declare gvt as i915's soft dependency

PATCH Superseded [email protected] 5 participants 8 messages Jul 4, 2018 – Jul 5, 2018

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 drm/i915/gvt: declare gvt as i915's soft dependency

From: Hang Yuan <[email protected]>

This helps initramfs builder and other tools to know the full dependencies of i915 and have gvt module loaded with i915.

v2: add condition and change to pre-dependency (Chris)
v3: move declaration to gvt.c. (Chris)

---
 drivers/gpu/drm/i915/gvt/gvt.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/gvt/gvt.c +7 -0
index 4e65266..00f487e9 100644
@@ -468,3 +468,10 @@ int intel_gvt_init_device(struct drm_i915_private *dev_priv)
 	kfree(gvt);
 	return ret;
 }
+
+#if IS_ENABLED(CONFIG_DRM_I915_GVT_KVMGT)
+MODULE_SOFTDEP("pre: kvmgt");
+#elif IS_ENABLED(CONFIG_DRM_I915_GVT_XENGT)
+MODULE_SOFTDEP("pre: xengt");
+#endif
+
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for drm/i915/gvt: declare gvt as i915's soft dependency

== Series Details ==

== Series Details ==

Series: drm/i915/gvt: declare gvt as i915's soft dependency
URL : https://patchwork.freedesktop.org/series/45875/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4424 -> Patchwork_9517 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/45875/revisions/1/mbox/

== Known issues ==

Here are the changes found in Patchwork_9517 that come from known issues:

=== IGT changes ===

    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

== Participating hosts (45 -> 41) ==

Additional (1): fi-byt-j1900
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4424 -> Patchwork_9517

CI_DRM_4424: 657e14c8ced17f6c7de56bf25506e64562bddd25 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4534: aeb3f4143572b81a907921ad9442858aafe1931e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9517: a60d9909939e10da3cc5bb0c75a771b8bc63f9d5 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

a60d9909939e drm/i915/gvt: declare gvt as i915's soft dependency

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9517/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.IGT: success for drm/i915/gvt: declare gvt as i915's soft dependency

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: drm/i915/gvt: declare gvt as i915's soft dependency
URL : https://patchwork.freedesktop.org/series/45875/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4424_full -> Patchwork_9517_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9517_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9517_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9517_full:

=== IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-bsd2:
      shard-kbl:          PASS -> SKIP

    igt@gem_exec_schedule@deep-vebox:
      shard-kbl:          SKIP -> PASS +2

== Known issues ==

Here are the changes found in Patchwork_9517_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-snb:          PASS -> FAIL (fdo#106886)

    igt@gem_mmap_gtt@coherency:
      shard-glk:          NOTRUN -> FAIL (fdo#100587)

    igt@gem_ppgtt@blt-vs-render-ctx0:
      shard-kbl:          PASS -> INCOMPLETE (fdo#106023, fdo#103665)

    igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          NOTRUN -> FAIL (fdo#105454, fdo#106509)

    igt@kms_flip@2x-plain-flip-fb-recreate:
      shard-glk:          PASS -> FAIL (fdo#100368)

    igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc:
      shard-kbl:          PASS -> DMESG-WARN (fdo#106247) +1

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_evict:
      shard-apl:          INCOMPLETE (fdo#103927) -> PASS

    igt@drv_selftest@live_gtt:
      shard-apl:          FAIL (fdo#105347) -> PASS

    igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
      shard-hsw:          FAIL (fdo#100368) -> PASS

    
    ==== Warnings ====

    igt@drv_selftest@live_gtt:
      shard-glk:          FAIL (fdo#105347) -> INCOMPLETE (fdo#103359, k.org#198133)

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#100587 https://bugs.freedesktop.org/show_bug.cgi?id=100587
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106247 https://bugs.freedesktop.org/show_bug.cgi?id=106247
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4424 -> Patchwork_9517

CI_DRM_4424: 657e14c8ced17f6c7de56bf25506e64562bddd25 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4534: aeb3f4143572b81a907921ad9442858aafe1931e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9517: a60d9909939e10da3cc5bb0c75a771b8bc63f9d5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9517/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v3 1/1
#3 lore raw
In reply to [email protected]

Quoting [email protected] (2018-07-04 04:07:45)

Quoted 18 lines

From: Hang Yuan <[email protected]>

This helps initramfs builder and other tools to know the full dependencies of i915 and have gvt module loaded with i915.

v2: add condition and change to pre-dependency (Chris)
v3: move declaration to gvt.c. (Chris)

---
 drivers/gpu/drm/i915/gvt/gvt.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/gvt/gvt.c +0 -0
index 4e65266..00f487e9 100644

drivers/gpu/drm/i915/gvt/gvt.c int intel_gvt_init_device(struct drm_i915_private *dev_priv) · line 476

Quoted 9 lines
drivers/gpu/drm/i915/gvt/gvt.c +6 -0
@@ -468,3 +468,10 @@ int intel_gvt_init_device(struct drm_i915_private *dev_priv)
        kfree(gvt);
        return ret;
 }
+
+#if IS_ENABLED(CONFIG_DRM_I915_GVT_KVMGT)
+MODULE_SOFTDEP("pre: kvmgt");
+#elif IS_ENABLED(CONFIG_DRM_I915_GVT_XENGT)
+MODULE_SOFTDEP("pre: xengt");
+#endif

This looks like the best one can do under the constraints of the macro. It matches my limited knowledge of how this works, so

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#4 lore raw

Thank you for the help to improve the patch! - Henry

Quoted 31 lines · Chris Wilson

Quoting [email protected] (2018-07-04 04:07:45)

Quoted 18 lines

From: Hang Yuan <[email protected]>

This helps initramfs builder and other tools to know the full dependencies of i915 and have gvt module loaded with i915.

v2: add condition and change to pre-dependency (Chris)
v3: move declaration to gvt.c. (Chris)

---
  drivers/gpu/drm/i915/gvt/gvt.c | 7 +++++++
  1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/gvt/gvt.c +0 -0
index 4e65266..00f487e9 100644

drivers/gpu/drm/i915/gvt/gvt.c int intel_gvt_init_device(struct drm_i915_private *dev_priv) · line 476

Quoted 9 lines
drivers/gpu/drm/i915/gvt/gvt.c +6 -0
@@ -468,3 +468,10 @@ int intel_gvt_init_device(struct drm_i915_private *dev_priv)
         kfree(gvt);
         return ret;
  }
+
+#if IS_ENABLED(CONFIG_DRM_I915_GVT_KVMGT)
+MODULE_SOFTDEP("pre: kvmgt");
+#elif IS_ENABLED(CONFIG_DRM_I915_GVT_XENGT)
+MODULE_SOFTDEP("pre: xengt");
+#endif

This looks like the best one can do under the constraints of the macro. It matches my limited knowledge of how this works, so

Quoted 3 lines

-Chris

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
In reply to [email protected]
Quoted 18 lines · On 2018.07.04 11:07:45 +0800, [email protected] wrote:

From: Hang Yuan <[email protected]>

This helps initramfs builder and other tools to know the full dependencies of i915 and have gvt module loaded with i915.

v2: add condition and change to pre-dependency (Chris)
v3: move declaration to gvt.c. (Chris)

---
 drivers/gpu/drm/i915/gvt/gvt.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/gvt/gvt.c +0 -0
index 4e65266..00f487e9 100644

drivers/gpu/drm/i915/gvt/gvt.c int intel_gvt_init_device(struct drm_i915_private *dev_priv) · line 477

Quoted 10 lines
drivers/gpu/drm/i915/gvt/gvt.c +7 -0
@@ -468,3 +468,10 @@ int intel_gvt_init_device(struct drm_i915_private *dev_priv)
 	kfree(gvt);
 	return ret;
 }
+
+#if IS_ENABLED(CONFIG_DRM_I915_GVT_KVMGT)
+MODULE_SOFTDEP("pre: kvmgt");
+#elif IS_ENABLED(CONFIG_DRM_I915_GVT_XENGT)
+MODULE_SOFTDEP("pre: xengt");
+#endif
+

Why xengt? it's not in upstream at all, so should be splitted and apply to its topic branch only.

Signature · 3 lines
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#6 lore raw
Quoted 24 lines · Zhenyu Wang
Quoted 23 lines · On 2018.07.04 11:07:45 +0800, [email protected] wrote:

From: Hang Yuan <[email protected]>

This helps initramfs builder and other tools to know the full dependencies of i915 and have gvt module loaded with i915.

v2: add condition and change to pre-dependency (Chris)
v3: move declaration to gvt.c. (Chris)

---
  drivers/gpu/drm/i915/gvt/gvt.c | 7 +++++++
  1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/gvt/gvt.c +2 -0
index 4e65266..00f487e9 100644
@@ -468,3 +468,10 @@ int intel_gvt_init_device(struct drm_i915_private *dev_priv)
  	kfree(gvt);
  	return ret;
  }
+
+#if IS_ENABLED(CONFIG_DRM_I915_GVT_KVMGT)
Quoted 8 lines

drivers/gpu/drm/i915/gvt/gvt.c int intel_gvt_init_device(struct drm_i915_private *dev_priv) · line 477

Quoted 5 lines
drivers/gpu/drm/i915/gvt/gvt.c +5 -0
+MODULE_SOFTDEP("pre: kvmgt");
+#elif IS_ENABLED(CONFIG_DRM_I915_GVT_XENGT)
+MODULE_SOFTDEP("pre: xengt");
+#endif
+

Why xengt? it's not in upstream at all, so should be splitted and apply to its topic branch only.

Henry: I understand xengt_mpt is not in upstream but general part of gvt like gvt.c is in upstream. The change of the patch is in the general part. Do you think so?

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#7 lore raw
Quoted 33 lines · On Thu, 05 Jul 2018, [email protected] wrote:
Quoted 24 lines · Zhenyu Wang
Quoted 23 lines · On 2018.07.04 11:07:45 +0800, [email protected] wrote:

From: Hang Yuan <[email protected]>

This helps initramfs builder and other tools to know the full dependencies of i915 and have gvt module loaded with i915.

v2: add condition and change to pre-dependency (Chris)
v3: move declaration to gvt.c. (Chris)

---
  drivers/gpu/drm/i915/gvt/gvt.c | 7 +++++++
  1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/gvt/gvt.c +2 -0
index 4e65266..00f487e9 100644
@@ -468,3 +468,10 @@ int intel_gvt_init_device(struct drm_i915_private *dev_priv)
  	kfree(gvt);
  	return ret;
  }
+
+#if IS_ENABLED(CONFIG_DRM_I915_GVT_KVMGT)
Quoted 8 lines

drivers/gpu/drm/i915/gvt/gvt.c int intel_gvt_init_device(struct drm_i915_private *dev_priv) · line 477

Quoted 5 lines
drivers/gpu/drm/i915/gvt/gvt.c +5 -0
+MODULE_SOFTDEP("pre: kvmgt");
+#elif IS_ENABLED(CONFIG_DRM_I915_GVT_XENGT)
+MODULE_SOFTDEP("pre: xengt");
+#endif
+

Why xengt? it's not in upstream at all, so should be splitted and apply to its topic branch only.

Quoted 3 lines

Henry: I understand xengt_mpt is not in upstream but general part of gvt like gvt.c is in upstream.
The change of the patch is in the general part. Do you think so?

AFAICT upstream IS_ENABLED(CONFIG_DRM_I915_GVT_XENGT) is always false; there's no such config.

BR,
Jani.

Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx