Skip to contentSkip to conversation

drivers/speakup: kobjects : Fixed Coding issues -Debugging

PATCH In review Tamir Suliman 2 participants 2 messages Jul 5, 2018 – Jul 7, 2018 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 drivers/speakup: kobjects : Fixed Coding issues -Debugging

Updated printk() of i18n messages to include KERN_INFO facility level to improve debuggin. then later noticed that I forgot to add a space on printk.

---
 drivers/staging/speakup/kobjects.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/kobjects.c +1 -1
index 7e79f99..af664f0 100644
@@ -740,7 +740,7 @@ static void report_msg_status(int reset, int received, int used,
 			snprintf(buf + (len - 1), sizeof(buf) - (len - 1),
 				 " with %d reject%s\n",
 				 rejected, rejected > 1 ? "s" : "");
-		printk(KERN_INFO "i18n messages rejected\n",buf);
+		printk(KERN_INFO "i18n messages rejected\n", buf);
 	}
 }
 
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw
Quoted 23 lines · Tamir Suliman

Updated printk() of i18n messages to include KERN_INFO facility level to improve debuggin. then later noticed that I forgot to add a space on printk.

---
 drivers/staging/speakup/kobjects.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/kobjects.c +1 -1
index 7e79f99..af664f0 100644
@@ -740,7 +740,7 @@ static void report_msg_status(int reset, int received, int used,
 			snprintf(buf + (len - 1), sizeof(buf) - (len - 1),
 				 " with %d reject%s\n",
 				 rejected, rejected > 1 ? "s" : "");
-		printk(KERN_INFO "i18n messages rejected\n",buf);
+		printk(KERN_INFO "i18n messages rejected\n", buf);
 	}
 }
 
Signature · 1 line
1.8.3.1

Where are patches 1 and 2 of this series?

And the changelog text does not match what the text itself does, so I can't take this as-is :(

greg k-h