Skip to contentSkip to conversation

checkpatch: check for #if 0/#if 1

PATCH New Prakruthi Deepak Heragu 1 participant 1 message Jul 5, 2018 Checkpatch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 checkpatch: check for #if 0/#if 1

The #if 0 and #if 1 are used to toggle features. Wharn if #if 1 or #if 0 is present. If #if 0 is present, warn about that part of code being redundant and that it could be removed. Also, if #if 1 is present, suggest that if the code is required then the #if 1 can be removed. In either case, these preprocessor directives can be removed.

---
 scripts/checkpatch.pl | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +11 -3
index 978c752..fa3e695 100755
@@ -5378,11 +5378,19 @@ sub process {
                  "Use of dsb is discouranged: prefer mb.\n" .
                  $herecurr);
 		}
+
 # warn about #if 0
 		if ($line =~ /^.\s*\#\s*if\s+0\b/) {
-			CHK("REDUNDANT_CODE",
-			    "if this code is redundant consider removing it\n" .
-				$herecurr);
+			WARN("IF_0",
+			     "if this code is redundant consider removing it\n"
+				.  $herecurr);
+		}
+
+# warn about #if 1
+		if ($line =~ /^.\s*\#\s*if\s+1\b/) {
+			WARN("IF_1",
+			     "if this code is required consider removing"
+				. " #if 1\n" .  $herecurr);
 		}
 
 # check for needless "if (<foo>) fn(<foo>)" uses
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project