Skip to contentSkip to conversation

Add Broadcom Stingray PCIe PHY support

PATCH New Ray Jui 1 participant 3 messages Jul 7, 2018

Subsystems (2)
lore
Share & tools
lore

Ray Jui

author
#0 lore raw

v4 cover Add Broadcom Stingray PCIe PHY support

This patch series adds PCIe PHY support for both PAXB and PAXC root complex in Broadcom Stingray SOC

This patch series is based off v4.18-rc3 and is available on GIHUB:
repo: https://github.com/Broadcom/arm64-linux.git
branch: sr-pcie-phy-v4

Changes since v3:
- Add missing node unit address in binding document
- Remove redundant dummy PHY callbacks in the driver
- Other miscellaneous minor fixes based on feedback from Kishon

Changes since v2:
- Add 'reg' property to the driver so it can access the PCIe SS PHY block
- Rebase to v4.18-rc3

Changes since v1:
- Rebase from v4.17-rc5 to v4.18-rc1

Ray Jui (2):
dt-bindings: phy: Add binding doc for Stingray PCIe PHY
phy: bcm-sr-pcie: Add Stingray PCIe PHY driver

 .../devicetree/bindings/phy/brcm,sr-pcie-phy.txt   |  41 +++
 drivers/phy/broadcom/Kconfig                       |  10 +
 drivers/phy/broadcom/Makefile                      |   2 +
 drivers/phy/broadcom/phy-bcm-sr-pcie.c             | 305 +++++++++++++++++++++
 4 files changed, 358 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/brcm,sr-pcie-phy.txt
 create mode 100644 drivers/phy/broadcom/phy-bcm-sr-pcie.c
Signature · 1 line
2.1.4
author
#1 lore raw

PATCH v4 1/2 dt-bindings: phy: Add binding doc for Stingray PCIe PHY

Add binding document for Stingray PCIe PHYs for both PAXB and PAXC based root complex

---
 .../devicetree/bindings/phy/brcm,sr-pcie-phy.txt   | 41 ++++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/brcm,sr-pcie-phy.txt
Documentation/devicetree/bindings/phy/brcm,sr-pcie-phy.txt new file +41 -0
new file mode 100644
index 0000000..e8d8228
@@ -0,0 +1,41 @@
+Broadcom Stingray PCIe PHY
+
+Required properties:
+- compatible: must be "brcm,sr-pcie-phy"
+- reg: base address and length of the PCIe SS register space
+- brcm,sr-cdru: phandle to the CDRU syscon node
+- brcm,sr-mhb: phandle to the MHB syscon node
+- #phy-cells: Must be 1, denotes the PHY index
+
+For PAXB based root complex, one can have a configuration of up to 8 PHYs
+PHY index goes from 0 to 7
+
+For the internal PAXC based root complex, PHY index is always 8
+
+Example:
+	mhb: syscon@60401000 {
+		compatible = "brcm,sr-mhb", "syscon";
+		reg = <0 0x60401000 0 0x38c>;
+	};
+
+	cdru: syscon@6641d000 {
+		compatible = "brcm,sr-cdru", "syscon";
+		reg = <0 0x6641d000 0 0x400>;
+	};
+
+	pcie_phy: phy@40000000 {
+		compatible = "brcm,sr-pcie-phy";
+		reg = <0 0x40000000 0 0x800>;
+		brcm,sr-cdru = <&cdru>;
+		brcm,sr-mhb = <&mhb>;
+		#phy-cells = <1>;
+	};
+
+	/* users of the PCIe PHY */
+
+	pcie0: pcie@48000000 {
+		...
+		...
+		phys = <&pcie_phy 0>;
+		phy-names = "pcie-phy";
+	};
Signature · 1 line
2.1.4
author
#2 lore raw

PATCH v4 2/2 phy: bcm-sr-pcie: Add Stingray PCIe PHY driver

In reply to Ray Jui

Add Stingray PCIe PHY driver for both PAXB and PAXC root complex

---
 drivers/phy/broadcom/Kconfig           |  10 ++
 drivers/phy/broadcom/Makefile          |   2 +
 drivers/phy/broadcom/phy-bcm-sr-pcie.c | 305 +++++++++++++++++++++++++++++++++
 3 files changed, 317 insertions(+)
 create mode 100644 drivers/phy/broadcom/phy-bcm-sr-pcie.c
drivers/phy/broadcom/Kconfig +10 -0
index 97d27b0d5..8786a96 100644
@@ -80,3 +80,13 @@ config PHY_BRCM_USB
 	  This driver is required by the USB XHCI, EHCI and OHCI
 	  drivers.
 	  If unsure, say N.
+
+config PHY_BCM_SR_PCIE
+	tristate "Broadcom Stingray PCIe PHY driver"
+	depends on OF && (ARCH_BCM_IPROC || COMPILE_TEST)
+	select GENERIC_PHY
+	select MFD_SYSCON
+	default ARCH_BCM_IPROC
+	help
+	  Enable this to support the Broadcom Stingray PCIe PHY
+	  If unsure, say N.
drivers/phy/broadcom/Makefile +2 -0
index 13e000c..0f60184 100644
@@ -9,3 +9,5 @@ obj-$(CONFIG_PHY_BRCM_SATA)		+= phy-brcm-sata.o
 obj-$(CONFIG_PHY_BRCM_USB)		+= phy-brcm-usb-dvr.o
 
 phy-brcm-usb-dvr-objs := phy-brcm-usb.o phy-brcm-usb-init.o
+
+obj-$(CONFIG_PHY_BCM_SR_PCIE)		+= phy-bcm-sr-pcie.o
drivers/phy/broadcom/phy-bcm-sr-pcie.c new file +305 -0

305 lines not on this page · raw message

Signature · 1 line
2.1.4