Skip to contentSkip to conversation

Staging:fwserial Move LINUX_VENDOR_ID to firewire.h

PATCH In review Janani Sankara Babu 2 participants 2 messages Jul 9, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging:fwserial Move LINUX_VENDOR_ID to firewire.h

This driver uses the same unregistered vendor id that the firewire core does (0xd00d1e). Hence it is exposed as a define in firewire.h.

---
 drivers/staging/fwserial/fwserial.c | 1 -
 include/linux/firewire.h            | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/staging/fwserial/fwserial.c +0 -0
index e8bfe55..f2966f2 100644
@@ -21,0 +21,0 @@

#define be32_to_u64(hi, lo) ((u64)be32_to_cpu(hi) << 32 | be32_to_cpu(lo))

-#define LINUX_VENDOR_ID   0xd00d1eU  /* same id used in card root directory   */
 #define FWSERIAL_VERSION  0x00e81cU  /* must be unique within LINUX_VENDOR_ID */

/* configurable options */

include/linux/firewire.h +0 -0
index aec8f30..62cdff1 100644
@@ -66,2 +66,2 @@
 #define CSR_MODEL		0x17
 #define CSR_DIRECTORY_ID	0x20

+#define LINUX_VENDOR_ID 0xd00d1eU /* same id used in card root directory */
+
struct fw_csr_iterator {
const u32 *p;
const u32 *end;
--
1.9.1

maintainer
#1 lore raw
Quoted 9 lines · Janani Sankara Babu

This driver uses the same unregistered vendor id that the firewire core does (0xd00d1e). Hence it is exposed as a define in firewire.h.

---
 drivers/staging/fwserial/fwserial.c | 1 -
 include/linux/firewire.h            | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

staging drivers are supposed to be self-contained. Please work to get the fwserial driver out of the staging directory before adding stuff like this to a .h file that everyone includes.

thanks,

greg k-h