FAILED: patch "[PATCH] RDMA/uverbs: Protect from attempts to create flows on" failed to apply to 4.17-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 4.17-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
940efcc8889f0d15567eb07fc9fd69b06e366aa5Mon Sep 17 00:00:00 2001
From: Leon Romanovsky <[email protected]>
Date: Sun, 24 Jun 2018 11:23:42 +0300
Subject: [PATCH] RDMA/uverbs: Protect from attempts to create flows on
unsupported QP
Flows can be created on UD and RAW_PACKET QP types. Attempts to provide other QP types as an input causes to various unpredictable failures.
The reason is that in order to support all various types (e.g. XRC), we are supposed to use real_qp handle and not qp handle and expect to driver/FW to fail such (XRC) flows. The simpler and safer variant is to ban all QP types except UD and RAW_PACKET, instead of relying on driver/FW.
drivers/infiniband/core/uverbs_cmd.c +5 -0
@@ -3559,6 +3559,11 @@ int ib_uverbs_ex_create_flow(struct ib_uverbs_file *file, goto err_uobj; } +if (qp->qp_type !=IB_QPT_UD && qp->qp_type !=IB_QPT_RAW_PACKET ) { + err = -EINVAL ; + goto err_put; + } + flow_attr =kzalloc (struct_size (flow_attr, flows, cmd.flow_attr.num_of_specs),GFP_KERNEL );if (!flow_attr) {