Skip to contentSkip to conversation

ARM: dts: exynos5: add missing interrupts for pwm node

PATCH Applied Anand Moon 2 participants 4 messages Jul 18, 2018 – Jul 22, 2018

Subsystems (2)
lore
Share & tools
lore

Anand Moon

author
#0 lore raw

PATCH v2 1/1 ARM: dts: exynos5: add missing interrupts for pwm node

Add missing GIC interrupts property for pwm nodes.

---
Fixed the patch indentation issue with all tabs.
sorry checkpatch could not figure out the error.

---
 arch/arm/boot/dts/exynos5.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/exynos5.dtsi +5 -0
index 5d2f0a0..f48fb9b 100644
@@ -169,6 +169,11 @@
 		pwm: pwm at 12dd0000 {
 			compatible = "samsung,exynos4210-pwm";
 			reg = <0x12DD0000 0x100>;
+			interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
 			samsung,pwm-outputs = <0>, <1>, <2>, <3>;
 			#pwm-cells = <3>;
 		};
Signature · 1 line
2.7.4
#1 lore raw
Quoted 15 lines · Anand Moon

Add missing GIC interrupts property for pwm nodes.

---
Fixed the patch indentation issue with all tabs.
sorry checkpatch could not figure out the error.

---
 arch/arm/boot/dts/exynos5.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/exynos5.dtsi +0 -0
index 5d2f0a0..f48fb9b 100644

arch/arm/boot/dts/exynos5.dtsi line 176

Quoted 8 lines
arch/arm/boot/dts/exynos5.dtsi +5 -0
@@ -169,6 +169,11 @@
                pwm: pwm at 12dd0000 {
                        compatible = "samsung,exynos4210-pwm";
                        reg = <0x12DD0000 0x100>;
+                       interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
+                                       <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,
+                                       <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>,
+                                       <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
+                                       <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;

OK, thanks for v2. Now only tabs are used but in previous mail I mentioned which example to use - the rtc node which nicely aligns continued lines. Why you did not follow this alignment?

I'll fix it when applying, no need to resend.

Best regards,
Krzysztof

author
#2 lore raw

Hi Krzysztof,

Quoted 29 lines · Krzysztof Kozlowski
Quoted 15 lines · Anand Moon

Add missing GIC interrupts property for pwm nodes.

---
Fixed the patch indentation issue with all tabs.
sorry checkpatch could not figure out the error.

---
 arch/arm/boot/dts/exynos5.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/exynos5.dtsi +0 -0
index 5d2f0a0..f48fb9b 100644

arch/arm/boot/dts/exynos5.dtsi line 176

Quoted 8 lines
arch/arm/boot/dts/exynos5.dtsi +5 -0
@@ -169,6 +169,11 @@
                pwm: pwm at 12dd0000 {
                        compatible = "samsung,exynos4210-pwm";
                        reg = <0x12DD0000 0x100>;
+                       interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
+                                       <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,
+                                       <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>,
+                                       <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
+                                       <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;

OK, thanks for v2. Now only tabs are used but in previous mail I mentioned which example to use - the rtc node which nicely aligns continued lines. Why you did not follow this alignment?

Quoted 4 lines

I'll fix it when applying, no need to resend.

Best regards,
Krzysztof

Thanks, I follow the tab protocol otherwise checkpatch would have complained of tab/space issue.

Best Regards
-Anand

maintainer Applied
#3 lore raw
In reply to Anand Moon
Quoted 9 lines · Anand Moon

Add missing GIC interrupts property for pwm nodes.

---
Fixed the patch indentation issue with all tabs.
sorry checkpatch could not figure out the error.

---
 arch/arm/boot/dts/exynos5.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

Thanks, applied with fixed subsystem prefix in subject and indentation.

Best regards,
Krzysztof