ARM: tegra: apalis-tk1: Fix SPDX license identifier format

PATCH In review Krzysztof Kozlowski 3 participants 10 messages Jul 18, 2018 – Jul 19, 2018

Subsystems (2)

Device tree bindings Tegra architecture support

lore

Share & tools

lore

Krzysztof Kozlowski

author

2018-07-18 19:48 UTC #0 lore raw

PATCH 1/3 ARM: tegra: apalis-tk1: Fix SPDX license identifier format

Fix incorrect format used for OR clause in SPDX license identifier.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts | 2 +-
 arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts +1 -1

index 8a8d5fa0ecd1..e2c0d8efb358 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+// SPDX-License-Identifier: GPL-2.0 OR MIT
 /*
  * Copyright 2016-2018 Toradex AG
  */

arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi +1 -1

index 573aaa50fff1..5ef84b6b3356 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+// SPDX-License-Identifier: GPL-2.0 OR MIT
 /*
  * Copyright 2016-2018 Toradex AG
  */

Signature · 1 line

2.14.1

Krzysztof Kozlowski

author

2018-07-18 19:48 UTC #1 lore raw

PATCH 2/3 ARM: tegra: apalis-tk1: Add SPDX license (GPL-2.0 OR X11) identifiers

Three files dual-licensed were missing the SPDX license identifiers.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 arch/arm/boot/dts/tegra124-apalis-emc.dtsi | 38 +-----------------------------
 arch/arm/boot/dts/tegra124-apalis-eval.dts | 38 +-----------------------------
 arch/arm/boot/dts/tegra124-apalis.dtsi     | 38 +-----------------------------
 3 files changed, 3 insertions(+), 111 deletions(-)

arch/arm/boot/dts/tegra124-apalis-emc.dtsi +1 ~~-37~~

index ca2c3a557895..cdbbb3562fb9 100644
@@ -1,42 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0 OR X11
 /*
  * Copyright 2016 Toradex AG
- *
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this dual
- * licensing only applies to this file, and not this project as a
- * whole.
- *
- *  a) This file is free software; you can redistribute it and/or
- *     modify it under the terms of the GNU General Public License
- *     version 2 as published by the Free Software Foundation.
- *
- *     This file is distributed in the hope that it will be useful
- *     but WITHOUT ANY WARRANTY; without even the implied warranty of
- *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *     GNU General Public License for more details.
- *
- * Or, alternatively
- *
- *  b) Permission is hereby granted, free of charge, to any person
- *     obtaining a copy of this software and associated documentation
- *     files (the "Software"), to deal in the Software without
- *     restriction, including without limitation the rights to use
- *     copy, modify, merge, publish, distribute, sublicense, and/or
- *     sell copies of the Software, and to permit persons to whom the
- *     Software is furnished to do so, subject to the following
- *     conditions:
- *
- *     The above copyright notice and this permission notice shall be
- *     included in all copies or substantial portions of the Software.
- *
- *     THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND
- *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
- *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
- *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- *     OTHER DEALINGS IN THE SOFTWARE.
  */
 
 / {

arch/arm/boot/dts/tegra124-apalis-eval.dts +1 ~~-37~~

index a6ad759dddb4..1c70c0078d75 100644
@@ -1,42 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0 OR X11
 /*
  * Copyright 2016-2018 Toradex AG
- *
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this dual
- * licensing only applies to this file, and not this project as a
- * whole.
- *
- *  a) This file is free software; you can redistribute it and/or
- *     modify it under the terms of the GNU General Public License
- *     version 2 as published by the Free Software Foundation.
- *
- *     This file is distributed in the hope that it will be useful
- *     but WITHOUT ANY WARRANTY; without even the implied warranty of
- *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *     GNU General Public License for more details.
- *
- * Or, alternatively
- *
- *  b) Permission is hereby granted, free of charge, to any person
- *     obtaining a copy of this software and associated documentation
- *     files (the "Software"), to deal in the Software without
- *     restriction, including without limitation the rights to use
- *     copy, modify, merge, publish, distribute, sublicense, and/or
- *     sell copies of the Software, and to permit persons to whom the
- *     Software is furnished to do so, subject to the following
- *     conditions:
- *
- *     The above copyright notice and this permission notice shall be
- *     included in all copies or substantial portions of the Software.
- *
- *     THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND
- *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
- *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
- *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- *     OTHER DEALINGS IN THE SOFTWARE.
  */
 
 /dts-v1/;

arch/arm/boot/dts/tegra124-apalis.dtsi +1 ~~-37~~

index 0f0d4a4988b9..14e9a204b84a 100644
@@ -1,42 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0 OR X11
 /*
  * Copyright 2016-2018 Toradex AG
- *
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this dual
- * licensing only applies to this file, and not this project as a
- * whole.
- *
- *  a) This file is free software; you can redistribute it and/or
- *     modify it under the terms of the GNU General Public License
- *     version 2 as published by the Free Software Foundation.
- *
- *     This file is distributed in the hope that it will be useful
- *     but WITHOUT ANY WARRANTY; without even the implied warranty of
- *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *     GNU General Public License for more details.
- *
- * Or, alternatively
- *
- *  b) Permission is hereby granted, free of charge, to any person
- *     obtaining a copy of this software and associated documentation
- *     files (the "Software"), to deal in the Software without
- *     restriction, including without limitation the rights to use
- *     copy, modify, merge, publish, distribute, sublicense, and/or
- *     sell copies of the Software, and to permit persons to whom the
- *     Software is furnished to do so, subject to the following
- *     conditions:
- *
- *     The above copyright notice and this permission notice shall be
- *     included in all copies or substantial portions of the Software.
- *
- *     THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND
- *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
- *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
- *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- *     OTHER DEALINGS IN THE SOFTWARE.
  */
 
 #include "tegra124.dtsi"

Signature · 1 line

2.14.1

Marcel Ziswiler

2018-07-18 20:41 UTC #2 lore raw

Re: [PATCH 2/3] ARM: tegra: apalis-tk1: Add SPDX license (GPL-2.0 OR X11) identifiers

Quoted 1 line · Krzysztof Kozlowski

Three files dual-licensed were missing the SPDX license identifiers.

As mentioned before [1] I am in the process of preparing a patch set which cleans that up across all Toradex device trees. Our plan is to actually move them all to dual GPL-2.0/MIT.

Quoted 175 lines

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 arch/arm/boot/dts/tegra124-apalis-emc.dtsi | 38 +-------------------
----------
 arch/arm/boot/dts/tegra124-apalis-eval.dts | 38 +-------------------
----------
 arch/arm/boot/dts/tegra124-apalis.dtsi     | 38 +-------------------
----------
 3 files changed, 3 insertions(+), 111 deletions(-)
arch/arm/boot/dts/tegra124-apalis-emc.dtsi +1 -3
index ca2c3a557895..cdbbb3562fb9 100644
@@ -1,42 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0 OR X11
 /*
  * Copyright 2016 Toradex AG
- *
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this
dual
- * licensing only applies to this file, and not this project as a
- * whole.
- *
- * a) This file is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * version 2 as published by the Free Software Foundation.
- *
- * This file is distributed in the hope that it will be useful
- * but WITHOUT ANY WARRANTY; without even the implied warranty
of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * Or, alternatively
- *
- * b) Permission is hereby granted, free of charge, to any person
- * obtaining a copy of this software and associated
documentation
- *     files (the "Software"), to deal in the Software without
- *     restriction, including without limitation the rights to use
- *     copy, modify, merge, publish, distribute, sublicense, and/or
- *     sell copies of the Software, and to permit persons to whom
the
- * Software is furnished to do so, subject to the following
- * conditions:
- *
- * The above copyright notice and this permission notice shall
be
- * included in all copies or substantial portions of the
Software.
- *
- * THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
WARRANTIES
- *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
- *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- *     OTHER DEALINGS IN THE SOFTWARE.
*/
/ {
arch/arm/boot/dts/tegra124-apalis-eval.dts +1 -3
index a6ad759dddb4..1c70c0078d75 100644
@@ -1,42 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0 OR X11
 /*
  * Copyright 2016-2018 Toradex AG
- *
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this
dual
- * licensing only applies to this file, and not this project as a
- * whole.
- *
- * a) This file is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * version 2 as published by the Free Software Foundation.
- *
- * This file is distributed in the hope that it will be useful
- * but WITHOUT ANY WARRANTY; without even the implied warranty
of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * Or, alternatively
- *
- * b) Permission is hereby granted, free of charge, to any person
- * obtaining a copy of this software and associated
documentation
- *     files (the "Software"), to deal in the Software without
- *     restriction, including without limitation the rights to use
- *     copy, modify, merge, publish, distribute, sublicense, and/or
- *     sell copies of the Software, and to permit persons to whom
the
- * Software is furnished to do so, subject to the following
- * conditions:
- *
- * The above copyright notice and this permission notice shall
be
- * included in all copies or substantial portions of the
Software.
- *
- * THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
WARRANTIES
- *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
- *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- *     OTHER DEALINGS IN THE SOFTWARE.
*/
/dts-v1/;
arch/arm/boot/dts/tegra124-apalis.dtsi +1 -3
index 0f0d4a4988b9..14e9a204b84a 100644
@@ -1,42 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0 OR X11
 /*
  * Copyright 2016-2018 Toradex AG
- *
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this
dual
- * licensing only applies to this file, and not this project as a
- * whole.
- *
- * a) This file is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * version 2 as published by the Free Software Foundation.
- *
- * This file is distributed in the hope that it will be useful
- * but WITHOUT ANY WARRANTY; without even the implied warranty
of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * Or, alternatively
- *
- * b) Permission is hereby granted, free of charge, to any person
- * obtaining a copy of this software and associated
documentation
- *     files (the "Software"), to deal in the Software without
- *     restriction, including without limitation the rights to use
- *     copy, modify, merge, publish, distribute, sublicense, and/or
- *     sell copies of the Software, and to permit persons to whom
the
- * Software is furnished to do so, subject to the following
- * conditions:
- *
- * The above copyright notice and this permission notice shall
be
- * included in all copies or substantial portions of the
Software.
- *
- * THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
WARRANTIES
- *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
- *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- *     OTHER DEALINGS IN THE SOFTWARE.

Quoted 3 lines

*/
#include "tegra124.dtsi"

[1] https://lore.kernel.org/lkml/[email protected]/

Philippe Ombredanne

2018-07-19 16:44 UTC #3 lore raw

Re: [PATCH 2/3] ARM: tegra: apalis-tk1: Add SPDX license (GPL-2.0 OR X11) identifiers

In reply to Krzysztof Kozlowski

Hi Krzysztof,

Quoted 14 lines · Krzysztof Kozlowski

Three files dual-licensed were missing the SPDX license identifiers.
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 arch/arm/boot/dts/tegra124-apalis-emc.dtsi | 38 +-----------------------------
 arch/arm/boot/dts/tegra124-apalis-eval.dts | 38 +-----------------------------
 arch/arm/boot/dts/tegra124-apalis.dtsi     | 38 +-----------------------------
 3 files changed, 3 insertions(+), 111 deletions(-)
arch/arm/boot/dts/tegra124-apalis-emc.dtsi +0 -0
index ca2c3a557895..cdbbb3562fb9 100644

arch/arm/boot/dts/tegra124-apalis-emc.dtsi line 7

Quoted 8 lines

arch/arm/boot/dts/tegra124-apalis-emc.dtsi +1 -5

@@ -1,42 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0 OR X11
 /*
  * Copyright 2016 Toradex AG
- *
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this dual
- * licensing only applies to this file, and not this project as a
- * whole.

This is weirdly enough not what is called an X11 license [1] even though it is named this way here... but this is an MIT license [2] with a small variation. (See below)

Quoted 15 lines

arch/arm/boot/dts/tegra124-apalis-emc.dtsi +0 ~~-15~~

- *
- *  a) This file is free software; you can redistribute it and/or
- *     modify it under the terms of the GNU General Public License
- *     version 2 as published by the Free Software Foundation.
- *
- *     This file is distributed in the hope that it will be useful
- *     but WITHOUT ANY WARRANTY; without even the implied warranty of
- *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *     GNU General Public License for more details.
- *
- * Or, alternatively
- *
- *  b) Permission is hereby granted, free of charge, to any person
- *     obtaining a copy of this software and associated documentation
- *     files (the "Software"), to deal in the Software without

arch/arm/boot/dts/tegra124-apalis-emc.dtsi line 32

Quoted 10 lines

arch/arm/boot/dts/tegra124-apalis-emc.dtsi +0 ~~-10~~

- *     restriction, including without limitation the rights to use
- *     copy, modify, merge, publish, distribute, sublicense, and/or
- *     sell copies of the Software, and to permit persons to whom the
- *     Software is furnished to do so, subject to the following
- *     conditions:
- *
- *     The above copyright notice and this permission notice shall be
- *     included in all copies or substantial portions of the Software.
- *
- *     THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND

The MIT standard text [2] has a few extra commas and states instead:

THE SOFTWARE IS PROVIDED "AS IS",

Here "AS IS" is omitted. I am not sure this is material but IMHO it would be good to get Toradex signoff on this.

arch/arm/boot/dts/tegra124-apalis-emc.dtsi line 4

Quoted 8 lines

arch/arm/boot/dts/tegra124-apalis-emc.dtsi +0 -7

- *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
- *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
- *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- *     OTHER DEALINGS IN THE SOFTWARE.
  */

<snip>

With all this said, I think that your expression should be this instead (and this applies to other places too):

SPDX-License-Identifier: GPL-2.0 OR MIT

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/other/X11?h=v4.18-rc5
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred/MIT?h=v4.18-rc5

Signature · 2 lines

Cordially
Philippe Ombredanne

Krzysztof Kozlowski

author

2018-07-19 17:32 UTC #4 lore raw

Re: [PATCH 2/3] ARM: tegra: apalis-tk1: Add SPDX license (GPL-2.0 OR X11) identifiers

Quoted 21 lines · Philippe Ombredanne

Hi Krzysztof,
Quoted 18 lines · Krzysztof Kozlowski
Three files dual-licensed were missing the SPDX license identifiers.
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 arch/arm/boot/dts/tegra124-apalis-emc.dtsi | 38 +-----------------------------
 arch/arm/boot/dts/tegra124-apalis-eval.dts | 38 +-----------------------------
 arch/arm/boot/dts/tegra124-apalis.dtsi     | 38 +-----------------------------
 3 files changed, 3 insertions(+), 111 deletions(-)
arch/arm/boot/dts/tegra124-apalis-emc.dtsi +1 -1
index ca2c3a557895..cdbbb3562fb9 100644
@@ -1,42 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0 OR X11
 /*
  * Copyright 2016 Toradex AG
- *

Quoted 8 lines

arch/arm/boot/dts/tegra124-apalis-emc.dtsi line 7
Quoted 4 lines
arch/arm/boot/dts/tegra124-apalis-emc.dtsi +0 -4
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this dual
- * licensing only applies to this file, and not this project as a
- * whole.
This is weirdly enough not what is called an X11 license [1] even though it is named this way here... but this is an MIT license [2] with a small variation. (See below)

Indeed... I checked the text just briefly and in 90% these licenses are the same.

Quoted 42 lines

Quoted 15 lines

arch/arm/boot/dts/tegra124-apalis-emc.dtsi +0 ~~-15~~

- *
- *  a) This file is free software; you can redistribute it and/or
- *     modify it under the terms of the GNU General Public License
- *     version 2 as published by the Free Software Foundation.
- *
- *     This file is distributed in the hope that it will be useful
- *     but WITHOUT ANY WARRANTY; without even the implied warranty of
- *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *     GNU General Public License for more details.
- *
- * Or, alternatively
- *
- *  b) Permission is hereby granted, free of charge, to any person
- *     obtaining a copy of this software and associated documentation
- *     files (the "Software"), to deal in the Software without

arch/arm/boot/dts/tegra124-apalis-emc.dtsi line 32

Quoted 10 lines

arch/arm/boot/dts/tegra124-apalis-emc.dtsi +0 ~~-10~~

- *     restriction, including without limitation the rights to use
- *     copy, modify, merge, publish, distribute, sublicense, and/or
- *     sell copies of the Software, and to permit persons to whom the
- *     Software is furnished to do so, subject to the following
- *     conditions:
- *
- *     The above copyright notice and this permission notice shall be
- *     included in all copies or substantial portions of the Software.
- *
- *     THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND

The MIT standard text [2] has a few extra commas and states instead:

THE SOFTWARE IS PROVIDED "AS IS",

Here "AS IS" is omitted. I am not sure this is material but IMHO it would be good to get Toradex signoff on this.

arch/arm/boot/dts/tegra124-apalis-emc.dtsi line 4

Quoted 8 lines

arch/arm/boot/dts/tegra124-apalis-emc.dtsi +0 -7

- *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
- *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
- *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- *     OTHER DEALINGS IN THE SOFTWARE.
  */

Quoted 7 lines

<snip>
With all this said, I think that your expression should be this instead (and this applies to other places too):
SPDX-License-Identifier: GPL-2.0 OR MIT

Right, Marcel from Toradex already replied that he tries to switch to MIT license. Since this is already MIT-like license then maybe relicensing will not be needed and could be done fast (e.g. without signs of all involved people).

In such case let's skip this patch.

Best regards,
Krzysztof

Krzysztof Kozlowski

author

2018-07-18 19:48 UTC #5 lore raw

PATCH 3/3 ARM: tegra: tegra20: Fix mixed tabs-spaces indentation

In reply to Krzysztof Kozlowski

Fix indentation and alignment when spaces were used instead of tabs. This fixes checkpatch errors like:

    ERROR: code indent should use tabs where possible
    #306: FILE: arch/arm/boot/dts/tegra20-paz00.dts:306:
    +^I^I         <&tegra_car TEGRA20_CLK_PLL_P_OUT3>;$

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 arch/arm/boot/dts/tegra20-colibri.dtsi | 2 +-
 arch/arm/boot/dts/tegra20-paz00.dts    | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

arch/arm/boot/dts/tegra20-colibri.dtsi +1 -1

index e7b9ab09908a..fa1af2dc276c 100644
@@ -541,7 +541,7 @@
 
 	sound {
 		compatible = "nvidia,tegra-audio-wm9712-colibri_t20",
-			         "nvidia,tegra-audio-wm9712";
+			     "nvidia,tegra-audio-wm9712";
 		nvidia,model = "Colibri T20 AC97 Audio";
 
 		nvidia,audio-routing =

arch/arm/boot/dts/tegra20-paz00.dts +3 -3

index ef245291924f..7d8aef6ebd3a 100644
@@ -303,7 +303,7 @@
 		request-gpios = <&gpio TEGRA_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
 		slave-addr = <138>;
 		clocks = <&tegra_car TEGRA20_CLK_I2C3>,
-		         <&tegra_car TEGRA20_CLK_PLL_P_OUT3>;
+			 <&tegra_car TEGRA20_CLK_PLL_P_OUT3>;
 		clock-names = "div-clk", "fast-clk";
 		resets = <&tegra_car 67>;
 		reset-names = "i2c";

@@ -599,8 +599,8 @@
 			GPIO_ACTIVE_HIGH>;
 
 		clocks = <&tegra_car TEGRA20_CLK_PLL_A>,
-		         <&tegra_car TEGRA20_CLK_PLL_A_OUT0>,
-		         <&tegra_car TEGRA20_CLK_CDEV1>;
+			 <&tegra_car TEGRA20_CLK_PLL_A_OUT0>,
+			 <&tegra_car TEGRA20_CLK_CDEV1>;
 		clock-names = "pll_a", "pll_a_out0", "mclk";
 	};
 };

Signature · 1 line

2.14.1

Marcel Ziswiler

Acked-by on v1 3/3

2018-07-18 20:46 UTC #6 lore raw

Re: [PATCH 3/3] ARM: tegra: tegra20: Fix mixed tabs-spaces indentation

Quoted 8 lines · Krzysztof Kozlowski

Fix indentation and alignment when spaces were used instead of tabs. This fixes checkpatch errors like:
    ERROR: code indent should use tabs where possible
    #306: FILE: arch/arm/boot/dts/tegra20-paz00.dts:306:
    +^I^I         <&tegra_car TEGRA20_CLK_PLL_P_OUT3>;$
Signed-off-by Krzysztof Kozlowski <[email protected]>

Acked-by Marcel Ziswiler <[email protected]>

Quoted 36 lines

---
 arch/arm/boot/dts/tegra20-colibri.dtsi | 2 +-
 arch/arm/boot/dts/tegra20-paz00.dts    | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

arch/arm/boot/dts/tegra20-colibri.dtsi +1 -1

index e7b9ab09908a..fa1af2dc276c 100644
@@ -541,7 +541,7 @@
 
 	sound {
 		compatible = "nvidia,tegra-audio-wm9712-
 colibri_t20",
-			         "nvidia,tegra-audio-wm9712";
+			     "nvidia,tegra-audio-wm9712";
 		nvidia,model = "Colibri T20 AC97 Audio";

arch/arm/boot/dts/tegra20-colibri.dtsi +0 -0

 		nvidia,audio-routing =

arch/arm/boot/dts/tegra20-paz00.dts +1 -1

index ef245291924f..7d8aef6ebd3a 100644
@@ -303,7 +303,7 @@
 		request-gpios = <&gpio TEGRA_GPIO(V, 2)
 GPIO_ACTIVE_HIGH>;
 		slave-addr = <138>;
 		clocks = <&tegra_car TEGRA20_CLK_I2C3>,
-		         <&tegra_car TEGRA20_CLK_PLL_P_OUT3>;
+			 <&tegra_car TEGRA20_CLK_PLL_P_OUT3>;
 		clock-names = "div-clk", "fast-clk";
 		resets = <&tegra_car 67>;

arch/arm/boot/dts/tegra20-paz00.dts +0 -0

 		reset-names = "i2c";

arch/arm/boot/dts/tegra20-paz00.dts line 606

Quoted 10 lines

arch/arm/boot/dts/tegra20-paz00.dts +2 -2

@@ -599,8 +599,8 @@
 			GPIO_ACTIVE_HIGH>;
 
 		clocks = <&tegra_car TEGRA20_CLK_PLL_A>,
-		         <&tegra_car TEGRA20_CLK_PLL_A_OUT0>,
-		         <&tegra_car TEGRA20_CLK_CDEV1>;
+			 <&tegra_car TEGRA20_CLK_PLL_A_OUT0>,
+			 <&tegra_car TEGRA20_CLK_CDEV1>;
 		clock-names = "pll_a", "pll_a_out0", "mclk";
 	};
 };

BTW: I am anyway in the process of sending out a major revamp of all our device trees targeting the Tegras and likewise made sure they do pass checkpatch (;-p).

Marcel Ziswiler

2018-07-18 20:37 UTC #7 lore raw

In reply to Krzysztof Kozlowski

Quoted 1 line · Krzysztof Kozlowski

Fix incorrect format used for OR clause in SPDX license identifier.

Can you please elaborate how you got to that conclusion as there are various other device trees having it specified the exact same way. Plus I was actually even in discussion with Philippe on that patch set back when I introduced those.

Quoted 23 lines

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts | 2 +-
 arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts +1 -1

index 8a8d5fa0ecd1..e2c0d8efb358 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+// SPDX-License-Identifier: GPL-2.0 OR MIT
 /*
  * Copyright 2016-2018 Toradex AG
  */

arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi +0 -0

index 573aaa50fff1..5ef84b6b3356 100644

arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi line 4

Quoted 5 lines

arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi +1 -1

@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+// SPDX-License-Identifier: GPL-2.0 OR MIT
 /*
  * Copyright 2016-2018 Toradex AG
  */

[1] https://lore.kernel.org/lkml/C651C677-D157-41A3-B206-CB02B986AD19@z
iswiler.com/

Krzysztof Kozlowski

author

2018-07-19 06:53 UTC #8 lore raw

Quoted 7 lines · Marcel Ziswiler

Quoted 1 line · Krzysztof Kozlowski
Fix incorrect format used for OR clause in SPDX license identifier.
Can you please elaborate how you got to that conclusion as there are various other device trees having it specified the exact same way. Plus I was actually even in discussion with Philippe on that patch set back when I introduced those.

Hi,

I thought these were pointed by checkpatch but it was my mistake - checkpatch complained about missing SPDX in tegra124-apalis.dtsi, not about these files. Maybe I was mislead by the in-kernel example [1]... although SPDX specification uses them so I think this patch can be abandoned.

[1] https://elixir.bootlin.com/linux/v4.18-rc5/source/Documentation/process/license-rules.rst#L130

Best regards,
Krzysztof

Marcel Ziswiler

2018-07-18 20:57 UTC #9 lore raw

In reply to Krzysztof Kozlowski

Quoted 14 lines · Krzysztof Kozlowski

Fix incorrect format used for OR clause in SPDX license identifier.
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts | 2 +-
 arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts +0 -0
index 8a8d5fa0ecd1..e2c0d8efb358 100644

arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts line 1

Quoted 1 line

arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts +0 -1
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR MIT)

At least the SPDX wiki suggests our exact used notation with brackets (OK, lower case or but I guess that now really does not matter (;-p).

Quoted 10 lines

arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts +1 -0
+// SPDX-License-Identifier: GPL-2.0 OR MIT
 /*
  * Copyright 2016-2018 Toradex AG
  */
arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi +0 -0
index 573aaa50fff1..5ef84b6b3356 100644

arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi line 4

Quoted 5 lines

arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi +1 -1

@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+// SPDX-License-Identifier: GPL-2.0 OR MIT
 /*
  * Copyright 2016-2018 Toradex AG
  */

[1] https://wiki.spdx.org/view/SPDX_FAQ